[Qemu-devel] [PATCH] fsdev: fix memory leak in main()

ZhiPeng Lu posted 1 patch 6 years, 8 months ago
Patches applied successfully (tree, apply log)
git fetch https://github.com/patchew-project/qemu tags/patchew/1501115502-15185-1-git-send-email-lu.zhipeng@zte.com.cn
Test FreeBSD passed
Test checkpatch passed
Test s390x passed
fsdev/virtfs-proxy-helper.c | 2 ++
1 file changed, 2 insertions(+)
[Qemu-devel] [PATCH] fsdev: fix memory leak in main()
Posted by ZhiPeng Lu 6 years, 8 months ago
@rpath and @ sock_name are not freed and leaked.

Signed-off-by: Zhipeng Lu lu.zhipeng@zte.com.cn
---
 fsdev/virtfs-proxy-helper.c | 2 ++
 1 file changed, 2 insertions(+)

diff --git a/fsdev/virtfs-proxy-helper.c b/fsdev/virtfs-proxy-helper.c
index 6c066ec..8e48500 100644
--- a/fsdev/virtfs-proxy-helper.c
+++ b/fsdev/virtfs-proxy-helper.c
@@ -1162,6 +1162,8 @@ int main(int argc, char **argv)
 
     process_requests(sock);
 error:
+    g_free(rpath);
+    g_free(sock_name);
     do_log(LOG_INFO, "Done\n");
     closelog();
     return 0;
-- 
1.8.3.1



Re: [Qemu-devel] [PATCH] fsdev: fix memory leak in main()
Posted by Greg Kurz 6 years, 8 months ago
On Thu, 27 Jul 2017 08:31:42 +0800
ZhiPeng Lu <lu.zhipeng@zte.com.cn> wrote:
> @rpath and @ sock_name are not freed and leaked.
> 

The leak is harmless since the process is expected to terminate when main()
returns. So, even if I fully agree that we should always take care of allocated
memory, I will push it to my 9p-next branch and wait for 2.11 before pushing it
upstream.

> Signed-off-by: Zhipeng Lu lu.zhipeng@zte.com.cn
> ---
>  fsdev/virtfs-proxy-helper.c | 2 ++
>  1 file changed, 2 insertions(+)
> 
> diff --git a/fsdev/virtfs-proxy-helper.c b/fsdev/virtfs-proxy-helper.c
> index 6c066ec..8e48500 100644
> --- a/fsdev/virtfs-proxy-helper.c
> +++ b/fsdev/virtfs-proxy-helper.c
> @@ -1162,6 +1162,8 @@ int main(int argc, char **argv)
>  
>      process_requests(sock);
>  error:
> +    g_free(rpath);
> +    g_free(sock_name);
>      do_log(LOG_INFO, "Done\n");
>      closelog();
>      return 0;