[Qemu-devel] [PATCH 0/4] mc146818rtc: implement UIP latching as intended

Paolo Bonzini posted 4 patches 6 years, 9 months ago
Patches applied successfully (tree, apply log)
git fetch https://github.com/patchew-project/qemu tags/patchew/1500990514-30326-1-git-send-email-pbonzini@redhat.com
Test FreeBSD passed
Test checkpatch failed
Test s390x passed
hw/timer/mc146818rtc.c |  37 ++++++------
tests/rtc-test.c       | 156 +++++++++++++++++++++++++++++++++++++++----------
2 files changed, 145 insertions(+), 48 deletions(-)
[Qemu-devel] [PATCH 0/4] mc146818rtc: implement UIP latching as intended
Posted by Paolo Bonzini 6 years, 9 months ago
Based on discussions with Peng Hao.  It is not clear to me what
causes UIP to get stuck in his case, but these changes test one
such scenario.

Paolo

Paolo Bonzini (4):
  rtc-test: cleanup register_b_set_flag test
  rtc-test: introduce more update tests
  mc146818rtc: simplify check_update_timer
  mc146818rtc: implement UIP latching as intended

 hw/timer/mc146818rtc.c |  37 ++++++------
 tests/rtc-test.c       | 156 +++++++++++++++++++++++++++++++++++++++----------
 2 files changed, 145 insertions(+), 48 deletions(-)

-- 
1.8.3.1


Re: [Qemu-devel] [PATCH 0/4] mc146818rtc: implement UIP latching as intended
Posted by no-reply@patchew.org 6 years, 9 months ago
Hi,

This series seems to have some coding style problems. See output below for
more information:

Type: series
Subject: [Qemu-devel] [PATCH 0/4] mc146818rtc: implement UIP latching as intended
Message-id: 1500990514-30326-1-git-send-email-pbonzini@redhat.com

=== TEST SCRIPT BEGIN ===
#!/bin/bash

BASE=base
n=1
total=$(git log --oneline $BASE.. | wc -l)
failed=0

git config --local diff.renamelimit 0
git config --local diff.renames True

commits="$(git log --format=%H --reverse $BASE..)"
for c in $commits; do
    echo "Checking PATCH $n/$total: $(git log -n 1 --format=%s $c)..."
    if ! git show $c --format=email | ./scripts/checkpatch.pl --mailback -; then
        failed=1
        echo
    fi
    n=$((n+1))
done

exit $failed
=== TEST SCRIPT END ===

Updating 3c8cf5a9c21ff8782164d1def7f44bd888713384
Switched to a new branch 'test'
c07cd6a mc146818rtc: implement UIP latching as intended
f4817e4 mc146818rtc: simplify check_update_timer
fba1b07 rtc-test: introduce more update tests
cac9365 rtc-test: cleanup register_b_set_flag test

=== OUTPUT BEGIN ===
Checking PATCH 1/4: rtc-test: cleanup register_b_set_flag test...
ERROR: space required before the open parenthesis '('
#73: FILE: tests/rtc-test.c:344:
+    } while(0)

total: 1 errors, 0 warnings, 115 lines checked

Your patch has style problems, please review.  If any of these errors
are false positives report them to the maintainer, see
CHECKPATCH in MAINTAINERS.

Checking PATCH 2/4: rtc-test: introduce more update tests...
Checking PATCH 3/4: mc146818rtc: simplify check_update_timer...
Checking PATCH 4/4: mc146818rtc: implement UIP latching as intended...
=== OUTPUT END ===

Test command exited with code: 1


---
Email generated automatically by Patchew [http://patchew.org/].
Please send your feedback to patchew-devel@freelists.org