[Qemu-devel] [PATCH V3 0/4] Optimize COLO-compare performance

Zhang Chen posted 4 patches 6 years, 8 months ago
Patches applied successfully (tree, apply log)
git fetch https://github.com/patchew-project/qemu tags/patchew/1500449399-19107-1-git-send-email-zhangchen.fnst@cn.fujitsu.com
Test FreeBSD passed
Test checkpatch failed
Test docker passed
Test s390x passed
There is a newer version of this series
net/colo-compare.c | 83 +++++++++++++++++++++++++++++++++++++++---------------
1 file changed, 60 insertions(+), 23 deletions(-)
[Qemu-devel] [PATCH V3 0/4] Optimize COLO-compare performance
Posted by Zhang Chen 6 years, 8 months ago
In this serise, we do a lot of job to optimize COLO net performance.
Mainly focus on TCP protocol.

V3:
 - Rebase on upstream.
 - Remove origin p2.
 - Move the "checkpoint_time_ms" to CompareState,
   in order to aviod multi colo-compare instance conflict.
 - Add "TODO comments" for reset s->checkpoint_time_ms.
 - Add a new patch fix comments and scheme.

V2:
 - Rename p2's subject.


Zhang Chen (4):
  net/colo-compare.c: Add checkpoint min period to optimize performance
  net/colo-compare.c: Optimize unpredictable tcp options  comparison
  net/colo-compare.c: Adjust net queue pop order for performance
  net/colo-compare.c: Fix comments and scheme

 net/colo-compare.c | 83 +++++++++++++++++++++++++++++++++++++++---------------
 1 file changed, 60 insertions(+), 23 deletions(-)

-- 
2.7.4




Re: [Qemu-devel] [PATCH V3 0/4] Optimize COLO-compare performance
Posted by no-reply@patchew.org 6 years, 8 months ago
Hi,

This series seems to have some coding style problems. See output below for
more information:

Subject: [Qemu-devel] [PATCH V3 0/4] Optimize COLO-compare performance
Message-id: 1500449399-19107-1-git-send-email-zhangchen.fnst@cn.fujitsu.com
Type: series

=== TEST SCRIPT BEGIN ===
#!/bin/bash

BASE=base
n=1
total=$(git log --oneline $BASE.. | wc -l)
failed=0

git config --local diff.renamelimit 0
git config --local diff.renames True

commits="$(git log --format=%H --reverse $BASE..)"
for c in $commits; do
    echo "Checking PATCH $n/$total: $(git log -n 1 --format=%s $c)..."
    if ! git show $c --format=email | ./scripts/checkpatch.pl --mailback -; then
        failed=1
        echo
    fi
    n=$((n+1))
done

exit $failed
=== TEST SCRIPT END ===

Updating 3c8cf5a9c21ff8782164d1def7f44bd888713384
From https://github.com/patchew-project/qemu
 - [tag update]      patchew/1500448182-21376-1-git-send-email-armbru@redhat.com -> patchew/1500448182-21376-1-git-send-email-armbru@redhat.com
 * [new tag]         patchew/20170719095033.20482-1-david@redhat.com -> patchew/20170719095033.20482-1-david@redhat.com
Switched to a new branch 'test'
fcb0d9f net/colo-compare.c: Fix comments and scheme
1b4531a net/colo-compare.c: Adjust net queue pop order for performance
8433e86 net/colo-compare.c: Optimize unpredictable tcp options comparison
384fa35 net/colo-compare.c: Add checkpoint min period to optimize performance

=== OUTPUT BEGIN ===
Checking PATCH 1/4: net/colo-compare.c: Add checkpoint min period to optimize performance...
Checking PATCH 2/4: net/colo-compare.c: Optimize unpredictable tcp options comparison...
Checking PATCH 3/4: net/colo-compare.c: Adjust net queue pop order for performance...
Checking PATCH 4/4: net/colo-compare.c: Fix comments and scheme...
ERROR: spaces required around that '|' (ctx:ExV)
#18: FILE: net/colo-compare.c:50:
+  |conn list      +--->conn           +--------->conn           |---> .......
   ^

ERROR: spaces required around that '+' (ctx:WxO)
#18: FILE: net/colo-compare.c:50:
+  |conn list      +--->conn           +--------->conn           |---> .......
                   ^

ERROR: spaces required around that '+' (ctx:WxO)
#18: FILE: net/colo-compare.c:50:
+  |conn list      +--->conn           +--------->conn           |---> .......
                                       ^

ERROR: spaces required around that '|' (ctx:WxO)
#18: FILE: net/colo-compare.c:50:
+  |conn list      +--->conn           +--------->conn           |---> .......
                                                                 ^

ERROR: spaces prohibited around that '->' (ctx:OxW)
#18: FILE: net/colo-compare.c:50:
+  |conn list      +--->conn           +--------->conn           |---> .......
                                                                    ^

total: 5 errors, 0 warnings, 40 lines checked

Your patch has style problems, please review.  If any of these errors
are false positives report them to the maintainer, see
CHECKPATCH in MAINTAINERS.

=== OUTPUT END ===

Test command exited with code: 1


---
Email generated automatically by Patchew [http://patchew.org/].
Please send your feedback to patchew-devel@freelists.org
Re: [Qemu-devel] [PATCH V3 0/4] Optimize COLO-compare performance
Posted by Zhang Chen 6 years, 7 months ago
Hi~~ All~

No one review this series for a long time.

Ping...


Thanks

Zhang Chen


On 07/19/2017 03:29 PM, Zhang Chen wrote:
> In this serise, we do a lot of job to optimize COLO net performance.
> Mainly focus on TCP protocol.
>
> V3:
>   - Rebase on upstream.
>   - Remove origin p2.
>   - Move the "checkpoint_time_ms" to CompareState,
>     in order to aviod multi colo-compare instance conflict.
>   - Add "TODO comments" for reset s->checkpoint_time_ms.
>   - Add a new patch fix comments and scheme.
>
> V2:
>   - Rename p2's subject.
>
>
> Zhang Chen (4):
>    net/colo-compare.c: Add checkpoint min period to optimize performance
>    net/colo-compare.c: Optimize unpredictable tcp options  comparison
>    net/colo-compare.c: Adjust net queue pop order for performance
>    net/colo-compare.c: Fix comments and scheme
>
>   net/colo-compare.c | 83 +++++++++++++++++++++++++++++++++++++++---------------
>   1 file changed, 60 insertions(+), 23 deletions(-)
>

-- 
Thanks
Zhang Chen




Re: [Qemu-devel] [PATCH V3 0/4] Optimize COLO-compare performance
Posted by Jason Wang 6 years, 7 months ago

On 2017年08月21日 09:45, Zhang Chen wrote:
> Hi~~ All~
>
> No one review this series for a long time.
>
> Ping...
>
>

Looks ok to me. But I don't like patch 1 since it adds more TODO 
especially for a non-exist function colo_notify_checkpoint().

I tend to have it after colo_notify_checkpoint() is implemented or merged.

Thanks


Re: [Qemu-devel] [PATCH V3 0/4] Optimize COLO-compare performance
Posted by Zhang Chen 6 years, 7 months ago

On 08/21/2017 11:55 AM, Jason Wang wrote:
>
>
> On 2017年08月21日 09:45, Zhang Chen wrote:
>> Hi~~ All~
>>
>> No one review this series for a long time.
>>
>> Ping...
>>
>>
>
> Looks ok to me. But I don't like patch 1 since it adds more TODO 
> especially for a non-exist function colo_notify_checkpoint().
>
> I tend to have it after colo_notify_checkpoint() is implemented or 
> merged.
>

I got your point, I will send the V4 without patch1.

Thanks
Zhang Chen

> Thanks
>
>
>
>

-- 
Thanks
Zhang Chen