[v3] add Qcow2 compress format extension

[Qemu-devel] [PATCH V3 0/9] add Qcow2 compress format extension

Peter Lieven posted 9 patches 6 years, 9 months ago

Diff against v2 v4 v5
Download series mbox

Patches applied successfully (tree, apply log)
git fetch https://github.com/patchew-project/qemu tags/patchew/1500026205-15542-1-git-send-email-pl@kamp.de

Test FreeBSD passed

Test checkpatch passed

Test docker passed

Test s390x passed

There is a newer version of this series

block/qcow2-cluster.c     |  73 +++++++++-----
block/qcow2.c             | 239 ++++++++++++++++++++++++++++++++++++++--------
block/qcow2.h             |  21 +++-
configure                 |   2 +-
docs/interop/qcow2.txt    |  35 ++++++-
include/block/block_int.h |   2 +
qapi/block-core.json      |  48 ++++++++++
qemu-img.texi             |  21 ++++
8 files changed, 370 insertions(+), 71 deletions(-)

Expand all Fold all

[Qemu-devel] [PATCH V3 0/9] add Qcow2 compress format extension

Posted by Peter Lieven 6 years, 9 months ago

this adds a create option for Qcow2 images to specify the compression format
and level for compressed clusters. The series adds 2 algorithms to choose from:
zlib and lzo. zlib is the current default, but with unoptimal settings.
If no compress.format option is specified the old zlib with the old parameters
is used and the created images are backwards compatible with older QEMU version.
As soon as a compression format is specified a new compress format header extension
is written and the Qcow2 images are incompatible with older QEMU versions.

Some numbers for an uncompressed Debian 9 QCOW2 image (size 1148MB):

compress.format     compress time    compressed size   decompress time
none                35.7s            339MB             3.4s
zlib (default)      30.5s            320MB             3.2s
zlib (level 1)      12.8s            348MB             3.2s
lzo                  4.2s            429MB             1.6s

Changes V2->V3:
  - rebase to current master (qcow2 crypto extension)
  - patch 1: explicitly list valid format names, list valid compression levels,
             remove extra_data and extra_data_size for now [Kevin]
  - patch 2: don't hook the compression options in the blockdev-add options [Kevin, Daniel]
  - patch 3: parse compress settings from the qapi struct [Daniel]
  - patch 4: mention valid values for zlib, mention incompatiblity for QEMU < 2.10 [Kevin]
  - patch 5: use qapi to parse the compress format from header [Daniel]
  - added patch 6

Changes V1->V2:
  - split the series into more patches
  - added an qapi scheme for the compression settings
  - renamed compression_algorithm to compress.format and added compress.level+
  - updated the header extension to carry a variable extra payload and compress
    level.
  - removed extra reservations for header extensions
  - added missing lzo_init and fixed compress overhead for lzo

Peter Lieven (9):
  specs/qcow2: add compress format extension
  qapi/block-core: add Qcow2Compress parameters
  block/qcow2: parse compress create options
  qemu-img: add documentation for compress settings
  block/qcow2: read and write the compress format extension
  block/qcow2: simplify ret usage in qcow2_create
  block/qcow2: optimize qcow2_co_pwritev_compressed
  block/qcow2: start using the compress format extension
  block/qcow2: add lzo compress format

 block/qcow2-cluster.c     |  73 +++++++++-----
 block/qcow2.c             | 239 ++++++++++++++++++++++++++++++++++++++--------
 block/qcow2.h             |  21 +++-
 configure                 |   2 +-
 docs/interop/qcow2.txt    |  35 ++++++-
 include/block/block_int.h |   2 +
 qapi/block-core.json      |  48 ++++++++++
 qemu-img.texi             |  21 ++++
 8 files changed, 370 insertions(+), 71 deletions(-)

-- 
1.9.1