[Qemu-devel] [PULL 00/41] Misc patches for QEMU 2.10 soft freeze

Paolo Bonzini posted 41 patches 6 years, 8 months ago
Patches applied successfully (tree, apply log)
git fetch https://github.com/patchew-project/qemu tags/patchew/1499955874-10954-1-git-send-email-pbonzini@redhat.com
Test FreeBSD passed
Test checkpatch failed
Test docker passed
Test s390x passed
There is a newer version of this series
MAINTAINERS                   |  18 +--
accel/tcg/translate-all.c     |   5 -
backends/rng-egd.c            |   2 +-
block/nbd-client.c            |  22 +--
block/nbd-client.h            |   3 +-
block/nbd.c                   |  16 ++-
bsd-user/qemu.h               |   2 +
chardev/char-fe.c             |  16 ++-
chardev/char-mux.c            |   1 +
chardev/char-socket.c         |   2 +
chardev/char.c                | 164 ++++++++++++++++++-----
configure                     |   2 +-
exec.c                        |  43 ++++--
gdbstub.c                     | 119 ++++++++---------
hmp-commands.hx               |  18 ++-
hmp.c                         |  34 +++++
hmp.h                         |   1 +
hw/alpha/typhoon.c            |  31 +++--
hw/arm/pxa2xx.c               |   3 +-
hw/arm/strongarm.c            |   4 +-
hw/char/bcm2835_aux.c         |   2 +-
hw/char/cadence_uart.c        |   4 +-
hw/char/debugcon.c            |   4 +-
hw/char/digic-uart.c          |   2 +-
hw/char/escc.c                |   8 +-
hw/char/etraxfs_ser.c         |   2 +-
hw/char/exynos4210_uart.c     |   4 +-
hw/char/grlib_apbuart.c       |   4 +-
hw/char/imx_serial.c          |   2 +-
hw/char/ipoctal232.c          |   4 +-
hw/char/lm32_juart.c          |   2 +-
hw/char/lm32_uart.c           |   2 +-
hw/char/mcf_uart.c            |   2 +-
hw/char/milkymist-uart.c      |   2 +-
hw/char/parallel.c            |   8 +-
hw/char/pl011.c               |   2 +-
hw/char/sclpconsole-lm.c      |   4 +-
hw/char/sclpconsole.c         |   4 +-
hw/char/serial.c              |  63 +++++++--
hw/char/sh_serial.c           |   4 +-
hw/char/spapr_vty.c           |   4 +-
hw/char/stm32f2xx_usart.c     |   3 +-
hw/char/terminal3270.c        |   4 +-
hw/char/virtio-console.c      |  35 ++++-
hw/char/xen_console.c         |   4 +-
hw/char/xilinx_uartlite.c     |   2 +-
hw/dma/rc4030.c               |  34 +++--
hw/i386/amd_iommu.c           |  33 +++--
hw/i386/amd_iommu.h           |   5 +-
hw/i386/intel_iommu.c         |  42 ++++--
hw/i386/kvmvapic.c            |  85 ++++++------
hw/ipmi/ipmi_bmc_extern.c     |   4 +-
hw/mips/boston.c              |   2 +-
hw/mips/mips_jazz.c           |   2 +-
hw/mips/mips_malta.c          |   2 +-
hw/misc/ivshmem.c             |   6 +-
hw/pci-host/apb.c             |  29 ++--
hw/ppc/spapr_iommu.c          |  42 ++++--
hw/s390x/s390-pci-bus.c       |  29 ++--
hw/s390x/s390-pci-bus.h       |   3 +-
hw/s390x/s390-pci-inst.c      |  11 +-
hw/usb/ccid-card-passthru.c   |   6 +-
hw/usb/dev-serial.c           |   7 +-
hw/usb/redirect.c             |   7 +-
hw/vfio/common.c              |  12 +-
hw/vfio/spapr.c               |   3 +-
include/block/nbd.h           |  58 ++++++--
include/chardev/char-fe.h     |  22 +++
include/chardev/char.h        |  19 +++
include/exec/gdbstub.h        |   9 --
include/exec/memory.h         |  94 +++++++++----
include/hw/i386/intel_iommu.h |   5 +-
include/hw/mips/mips.h        |   2 +-
include/hw/ppc/spapr.h        |   7 +-
include/hw/vfio/vfio-common.h |   2 +-
include/qemu/typedefs.h       |   1 +
include/qom/cpu.h             |   2 -
linux-user/syscall.c          |   1 -
memory.c                      | 113 +++++++++++-----
monitor.c                     |   4 +-
nbd/client.c                  | 283 +++++++++++++++++++++++++++++++++------
nbd/common.c                  |  92 +++++++++++++
nbd/nbd-internal.h            |  13 +-
nbd/server.c                  | 304 +++++++++++++++++++++++++++++++++++-------
nbd/trace-events              |  25 ++--
net/colo-compare.c            |  10 +-
net/filter-mirror.c           |   8 +-
net/slirp.c                   |   2 +-
net/vhost-user.c              |   7 +-
qapi-schema.json              |  40 ++++++
qemu-nbd.c                    |  10 +-
qtest.c                       |   2 +-
target/xtensa/xtensa-semi.c   |   2 +-
tests/test-char.c             | 275 ++++++++++++++++++++++++++++----------
tests/test-hmp.c              |   1 +
tests/vhost-user-test.c       |   2 +-
vl.c                          |   8 +-
97 files changed, 1831 insertions(+), 643 deletions(-)
[Qemu-devel] [PULL 00/41] Misc patches for QEMU 2.10 soft freeze
Posted by Paolo Bonzini 6 years, 8 months ago
The following changes since commit f0d2ead97cddf622a0478086886cc70a8ed6aeaf:

  Merge remote-tracking branch 'remotes/yongbok/tags/mips-20170711' into staging (2017-07-13 12:48:37 +0100)

are available in the git repository at:


  git://github.com/bonzini/qemu.git tags/for-upstream

for you to fetch changes up to a5c8d75361054dbf953b87bc9675ecb11433762a:

  translate-all: remove redundant !tcg_enabled check in dump_exec_info (2017-07-13 15:43:45 +0200)

----------------------------------------------------------------
* gdbstub fixes (Alex)
* IOMMU MemoryRegion subclass (Alexey)
* Chardev hotswap (Anton)
* NBD_OPT_GO support (Eric)
* Misc bugfixes
* MAINTAINERS updates (Philippe)

----------------------------------------------------------------
I'm away next week, I'd be able to resubmit if there are issues on July 23.

Alex Bennée (4):
      gdbstub: modernise DEBUG_GDB
      gdbstub: rename cpu_index -> cpu_gdb_index
      qom/cpu: remove host_tid field
      gdbstub: don't fail on vCont; C04:0; c packets

Alexey Kardashevskiy (2):
      memory/iommu: QOM'fy IOMMU MemoryRegion
      memory/iommu: introduce IOMMUMemoryRegionClass

Anton Nefedov (13):
      char: move QemuOpts->ChardevBackend translation to a separate func
      char: add backend hotswap handler
      char: chardevice hotswap
      char: forbid direct chardevice access for hotswap devices
      char: avoid chardevice direct access
      test-char: destroy chardev-udp after test
      test-char: split char_udp_test
      test-char: split char_file_test
      test-char: add hotswap test
      hmp: add hmp analogue for qmp-chardev-change
      virtio-console: chardev hotswap support
      serial: move TIOCM update to a separate function
      serial: chardev hotswap support

Emilio G. Cota (2):
      vl: fix breakage of -tb-size
      translate-all: remove redundant !tcg_enabled check in dump_exec_info

Eric Blake (9):
      nbd: Create struct for tracking export info
      nbd: Don't bother tracing an NBD_OPT_ABORT response failure
      nbd: Expose and debug more NBD constants
      nbd: Simplify trace of client flags in negotiation
      nbd: Refactor reply to NBD_OPT_EXPORT_NAME
      nbd: Implement NBD_OPT_GO on server
      nbd: Implement NBD_OPT_GO on client
      nbd: Implement NBD_INFO_BLOCK_SIZE on server
      nbd: Implement NBD_INFO_BLOCK_SIZE on client

Marc-André Lureau (1):
      chardev: block during sync read

Paolo Bonzini (1):
      build: add -Wexpansion-to-defined

Peng Hao (1):
      chardev: fix parallel device can't be reconnect

Philippe Mathieu-Daudé (5):
      MAINTAINERS: update TCG entries
      MAINTAINERS: update KVM entries
      MAINTAINERS: update Xen entries
      MAINTAINERS: update TCI entry
      MAINTAINERS: add entry for "Unimplemented" device

Pranith Kumar (2):
      Revert "exec.c: Fix breakpoint invalidation race"
      mttcg/i386: Patch instruction using async_safe_* framework

Prasad J Pandit (1):
      exec: use qemu_ram_ptr_length to access guest ram

 MAINTAINERS                   |  18 +--
 accel/tcg/translate-all.c     |   5 -
 backends/rng-egd.c            |   2 +-
 block/nbd-client.c            |  22 +--
 block/nbd-client.h            |   3 +-
 block/nbd.c                   |  16 ++-
 bsd-user/qemu.h               |   2 +
 chardev/char-fe.c             |  16 ++-
 chardev/char-mux.c            |   1 +
 chardev/char-socket.c         |   2 +
 chardev/char.c                | 164 ++++++++++++++++++-----
 configure                     |   2 +-
 exec.c                        |  43 ++++--
 gdbstub.c                     | 119 ++++++++---------
 hmp-commands.hx               |  18 ++-
 hmp.c                         |  34 +++++
 hmp.h                         |   1 +
 hw/alpha/typhoon.c            |  31 +++--
 hw/arm/pxa2xx.c               |   3 +-
 hw/arm/strongarm.c            |   4 +-
 hw/char/bcm2835_aux.c         |   2 +-
 hw/char/cadence_uart.c        |   4 +-
 hw/char/debugcon.c            |   4 +-
 hw/char/digic-uart.c          |   2 +-
 hw/char/escc.c                |   8 +-
 hw/char/etraxfs_ser.c         |   2 +-
 hw/char/exynos4210_uart.c     |   4 +-
 hw/char/grlib_apbuart.c       |   4 +-
 hw/char/imx_serial.c          |   2 +-
 hw/char/ipoctal232.c          |   4 +-
 hw/char/lm32_juart.c          |   2 +-
 hw/char/lm32_uart.c           |   2 +-
 hw/char/mcf_uart.c            |   2 +-
 hw/char/milkymist-uart.c      |   2 +-
 hw/char/parallel.c            |   8 +-
 hw/char/pl011.c               |   2 +-
 hw/char/sclpconsole-lm.c      |   4 +-
 hw/char/sclpconsole.c         |   4 +-
 hw/char/serial.c              |  63 +++++++--
 hw/char/sh_serial.c           |   4 +-
 hw/char/spapr_vty.c           |   4 +-
 hw/char/stm32f2xx_usart.c     |   3 +-
 hw/char/terminal3270.c        |   4 +-
 hw/char/virtio-console.c      |  35 ++++-
 hw/char/xen_console.c         |   4 +-
 hw/char/xilinx_uartlite.c     |   2 +-
 hw/dma/rc4030.c               |  34 +++--
 hw/i386/amd_iommu.c           |  33 +++--
 hw/i386/amd_iommu.h           |   5 +-
 hw/i386/intel_iommu.c         |  42 ++++--
 hw/i386/kvmvapic.c            |  85 ++++++------
 hw/ipmi/ipmi_bmc_extern.c     |   4 +-
 hw/mips/boston.c              |   2 +-
 hw/mips/mips_jazz.c           |   2 +-
 hw/mips/mips_malta.c          |   2 +-
 hw/misc/ivshmem.c             |   6 +-
 hw/pci-host/apb.c             |  29 ++--
 hw/ppc/spapr_iommu.c          |  42 ++++--
 hw/s390x/s390-pci-bus.c       |  29 ++--
 hw/s390x/s390-pci-bus.h       |   3 +-
 hw/s390x/s390-pci-inst.c      |  11 +-
 hw/usb/ccid-card-passthru.c   |   6 +-
 hw/usb/dev-serial.c           |   7 +-
 hw/usb/redirect.c             |   7 +-
 hw/vfio/common.c              |  12 +-
 hw/vfio/spapr.c               |   3 +-
 include/block/nbd.h           |  58 ++++++--
 include/chardev/char-fe.h     |  22 +++
 include/chardev/char.h        |  19 +++
 include/exec/gdbstub.h        |   9 --
 include/exec/memory.h         |  94 +++++++++----
 include/hw/i386/intel_iommu.h |   5 +-
 include/hw/mips/mips.h        |   2 +-
 include/hw/ppc/spapr.h        |   7 +-
 include/hw/vfio/vfio-common.h |   2 +-
 include/qemu/typedefs.h       |   1 +
 include/qom/cpu.h             |   2 -
 linux-user/syscall.c          |   1 -
 memory.c                      | 113 +++++++++++-----
 monitor.c                     |   4 +-
 nbd/client.c                  | 283 +++++++++++++++++++++++++++++++++------
 nbd/common.c                  |  92 +++++++++++++
 nbd/nbd-internal.h            |  13 +-
 nbd/server.c                  | 304 +++++++++++++++++++++++++++++++++++-------
 nbd/trace-events              |  25 ++--
 net/colo-compare.c            |  10 +-
 net/filter-mirror.c           |   8 +-
 net/slirp.c                   |   2 +-
 net/vhost-user.c              |   7 +-
 qapi-schema.json              |  40 ++++++
 qemu-nbd.c                    |  10 +-
 qtest.c                       |   2 +-
 target/xtensa/xtensa-semi.c   |   2 +-
 tests/test-char.c             | 275 ++++++++++++++++++++++++++++----------
 tests/test-hmp.c              |   1 +
 tests/vhost-user-test.c       |   2 +-
 vl.c                          |   8 +-
 97 files changed, 1831 insertions(+), 643 deletions(-)
-- 
1.8.3.1


Re: [Qemu-devel] [PULL 00/41] Misc patches for QEMU 2.10 soft freeze
Posted by no-reply@patchew.org 6 years, 8 months ago
Hi,

This series seems to have some coding style problems. See output below for
more information:

Type: series
Message-id: 1499955874-10954-1-git-send-email-pbonzini@redhat.com
Subject: [Qemu-devel] [PULL 00/41] Misc patches for QEMU 2.10 soft freeze

=== TEST SCRIPT BEGIN ===
#!/bin/bash

BASE=base
n=1
total=$(git log --oneline $BASE.. | wc -l)
failed=0

git config --local diff.renamelimit 0
git config --local diff.renames True

commits="$(git log --format=%H --reverse $BASE..)"
for c in $commits; do
    echo "Checking PATCH $n/$total: $(git log -n 1 --format=%s $c)..."
    if ! git show $c --format=email | ./scripts/checkpatch.pl --mailback -; then
        failed=1
        echo
    fi
    n=$((n+1))
done

exit $failed
=== TEST SCRIPT END ===

Updating 3c8cf5a9c21ff8782164d1def7f44bd888713384
From https://github.com/patchew-project/qemu
 - [tag update]      patchew/1499955697-28045-1-git-send-email-peter.maydell@linaro.org -> patchew/1499955697-28045-1-git-send-email-peter.maydell@linaro.org
 * [new tag]         patchew/1499955874-10954-1-git-send-email-pbonzini@redhat.com -> patchew/1499955874-10954-1-git-send-email-pbonzini@redhat.com
 * [new tag]         patchew/1499958932-23839-1-git-send-email-peter.maydell@linaro.org -> patchew/1499958932-23839-1-git-send-email-peter.maydell@linaro.org
 - [tag update]      patchew/20170713110237.6712-1-lprosek@redhat.com -> patchew/20170713110237.6712-1-lprosek@redhat.com
 * [new tag]         patchew/20170713144352.2212-1-berrange@redhat.com -> patchew/20170713144352.2212-1-berrange@redhat.com
 * [new tag]         patchew/20170713153028.31065-1-el13635@mail.ntua.gr -> patchew/20170713153028.31065-1-el13635@mail.ntua.gr
Switched to a new branch 'test'
6d67cf3 translate-all: remove redundant !tcg_enabled check in dump_exec_info
46b92a9 vl: fix breakage of -tb-size
4c7de34 nbd: Implement NBD_INFO_BLOCK_SIZE on client
280da19 nbd: Implement NBD_INFO_BLOCK_SIZE on server
8abe2ce nbd: Implement NBD_OPT_GO on client
0a397be nbd: Implement NBD_OPT_GO on server
2bbad3f nbd: Refactor reply to NBD_OPT_EXPORT_NAME
474ef00 nbd: Simplify trace of client flags in negotiation
080f569 nbd: Expose and debug more NBD constants
c5ea916 nbd: Don't bother tracing an NBD_OPT_ABORT response failure
8921348 nbd: Create struct for tracking export info
c36ec9b memory/iommu: introduce IOMMUMemoryRegionClass
9897b91 memory/iommu: QOM'fy IOMMU MemoryRegion
eb1a75c chardev: fix parallel device can't be reconnect
a862860 gdbstub: don't fail on vCont; C04:0; c packets
d47bd46 qom/cpu: remove host_tid field
4220a85 gdbstub: rename cpu_index -> cpu_gdb_index
2810341 gdbstub: modernise DEBUG_GDB
3b7ce63 mttcg/i386: Patch instruction using async_safe_* framework
bdbca69 Revert "exec.c: Fix breakpoint invalidation race"
d060d0e exec: use qemu_ram_ptr_length to access guest ram
c76c3bb serial: chardev hotswap support
79796d4 serial: move TIOCM update to a separate function
be08fcf virtio-console: chardev hotswap support
e522bda hmp: add hmp analogue for qmp-chardev-change
64ce47e test-char: add hotswap test
e54fca6 test-char: split char_file_test
d971065 test-char: split char_udp_test
b823a3b test-char: destroy chardev-udp after test
e7ba7f5 char: avoid chardevice direct access
4638b74 char: forbid direct chardevice access for hotswap devices
f560498 char: chardevice hotswap
919f86c char: add backend hotswap handler
d00a58a char: move QemuOpts->ChardevBackend translation to a separate func
97d7b48 chardev: block during sync read
e5b1de4 MAINTAINERS: add entry for "Unimplemented" device
d55179c MAINTAINERS: update TCI entry
e6b5227 MAINTAINERS: update Xen entries
b35e727 MAINTAINERS: update KVM entries
4b2ee70 MAINTAINERS: update TCG entries
cd26684 build: add -Wexpansion-to-defined

=== OUTPUT BEGIN ===
Checking PATCH 1/41: build: add -Wexpansion-to-defined...
Checking PATCH 2/41: MAINTAINERS: update TCG entries...
Checking PATCH 3/41: MAINTAINERS: update KVM entries...
Checking PATCH 4/41: MAINTAINERS: update Xen entries...
Checking PATCH 5/41: MAINTAINERS: update TCI entry...
Checking PATCH 6/41: MAINTAINERS: add entry for "Unimplemented" device...
Checking PATCH 7/41: chardev: block during sync read...
Checking PATCH 8/41: char: move QemuOpts->ChardevBackend translation to a separate func...
Checking PATCH 9/41: char: add backend hotswap handler...
WARNING: line over 80 characters
#725: FILE: target/xtensa/xtensa-semi.c:161:
+    qemu_chr_fe_set_handlers(&console, NULL, NULL, NULL, NULL, NULL, NULL, true);

total: 0 errors, 1 warnings, 544 lines checked

Your patch has style problems, please review.  If any of these errors
are false positives report them to the maintainer, see
CHECKPATCH in MAINTAINERS.
Checking PATCH 10/41: char: chardevice hotswap...
Checking PATCH 11/41: char: forbid direct chardevice access for hotswap devices...
Checking PATCH 12/41: char: avoid chardevice direct access...
Checking PATCH 13/41: test-char: destroy chardev-udp after test...
Checking PATCH 14/41: test-char: split char_udp_test...
Checking PATCH 15/41: test-char: split char_file_test...
Checking PATCH 16/41: test-char: add hotswap test...
Checking PATCH 17/41: hmp: add hmp analogue for qmp-chardev-change...
Checking PATCH 18/41: virtio-console: chardev hotswap support...
Checking PATCH 19/41: serial: move TIOCM update to a separate function...
Checking PATCH 20/41: serial: chardev hotswap support...
Checking PATCH 21/41: exec: use qemu_ram_ptr_length to access guest ram...
Checking PATCH 22/41: Revert "exec.c: Fix breakpoint invalidation race"...
Checking PATCH 23/41: mttcg/i386: Patch instruction using async_safe_* framework...
Checking PATCH 24/41: gdbstub: modernise DEBUG_GDB...
Checking PATCH 25/41: gdbstub: rename cpu_index -> cpu_gdb_index...
Checking PATCH 26/41: qom/cpu: remove host_tid field...
Checking PATCH 27/41: gdbstub: don't fail on vCont; C04:0; c packets...
Checking PATCH 28/41: chardev: fix parallel device can't be reconnect...
Checking PATCH 29/41: memory/iommu: QOM'fy IOMMU MemoryRegion...
ERROR: spaces required around that '*' (ctx:WxO)
#133: FILE: hw/dma/rc4030.c:720:
+DeviceState *rc4030_init(rc4030_dma **dmas, IOMMUMemoryRegion **dma_mr)
                                     ^

total: 1 errors, 0 warnings, 772 lines checked

Your patch has style problems, please review.  If any of these errors
are false positives report them to the maintainer, see
CHECKPATCH in MAINTAINERS.

Checking PATCH 30/41: memory/iommu: introduce IOMMUMemoryRegionClass...
Checking PATCH 31/41: nbd: Create struct for tracking export info...
Checking PATCH 32/41: nbd: Don't bother tracing an NBD_OPT_ABORT response failure...
Checking PATCH 33/41: nbd: Expose and debug more NBD constants...
Checking PATCH 34/41: nbd: Simplify trace of client flags in negotiation...
Checking PATCH 35/41: nbd: Refactor reply to NBD_OPT_EXPORT_NAME...
Checking PATCH 36/41: nbd: Implement NBD_OPT_GO on server...
Checking PATCH 37/41: nbd: Implement NBD_OPT_GO on client...
Checking PATCH 38/41: nbd: Implement NBD_INFO_BLOCK_SIZE on server...
Checking PATCH 39/41: nbd: Implement NBD_INFO_BLOCK_SIZE on client...
Checking PATCH 40/41: vl: fix breakage of -tb-size...
Checking PATCH 41/41: translate-all: remove redundant !tcg_enabled check in dump_exec_info...
=== OUTPUT END ===

Test command exited with code: 1


---
Email generated automatically by Patchew [http://patchew.org/].
Please send your feedback to patchew-devel@freelists.org
Re: [Qemu-devel] [PULL 00/41] Misc patches for QEMU 2.10 soft freeze
Posted by Paolo Bonzini 6 years, 8 months ago
On 13/07/2017 18:05, no-reply@patchew.org wrote:
> Hi,
> 
> This series seems to have some coding style problems. See output below for
> more information:
> 

False positive due to non-camelcase type in hw/dma/rc4030.c.

> Checking PATCH 29/41: memory/iommu: QOM'fy IOMMU MemoryRegion...
> ERROR: spaces required around that '*' (ctx:WxO)
> #133: FILE: hw/dma/rc4030.c:720:
> +DeviceState *rc4030_init(rc4030_dma **dmas, IOMMUMemoryRegion **dma_mr)
Thanks,

Paolo