[Qemu-devel] [PATCH 0/4] qapi: Handle some keyval fallout

Markus Armbruster posted 4 patches 6 years, 11 months ago
Patches applied successfully (tree, apply log)
git fetch https://github.com/patchew-project/qemu tags/patchew/1495471335-23707-1-git-send-email-armbru@redhat.com
Test checkpatch passed
Test docker passed
Test s390x passed
include/qapi/visitor.h                             |  4 ++
qapi/qobject-input-visitor.c                       |  3 +-
scripts/qapi.py                                    | 19 ++++++-
tests/Makefile.include                             |  2 +
tests/qapi-schema/alternate-clash.json             |  2 +-
tests/qapi-schema/alternate-conflict-dict.json     |  2 +-
tests/qapi-schema/alternate-conflict-enum-bool.err |  1 +
.../qapi-schema/alternate-conflict-enum-bool.exit  |  1 +
.../qapi-schema/alternate-conflict-enum-bool.json  |  6 +++
tests/qapi-schema/alternate-conflict-enum-bool.out |  0
tests/qapi-schema/alternate-conflict-enum-int.err  |  1 +
tests/qapi-schema/alternate-conflict-enum-int.exit |  1 +
tests/qapi-schema/alternate-conflict-enum-int.json |  6 +++
tests/qapi-schema/alternate-conflict-enum-int.out  |  0
tests/qapi-schema/alternate-conflict-string.err    |  2 +-
tests/qapi-schema/alternate-conflict-string.json   |  6 +--
tests/qapi-schema/alternate-nested.json            |  2 +-
tests/qapi-schema/args-alternate.json              |  2 +-
tests/qapi-schema/doc-bad-alternate-member.json    |  2 +-
tests/qapi-schema/qapi-schema-test.json            | 13 +++--
tests/qapi-schema/qapi-schema-test.out             | 34 ++++++------
tests/qapi-schema/returns-alternate.json           |  2 +-
tests/test-clone-visitor.c                         | 23 ++++----
tests/test-keyval.c                                | 18 ++++---
tests/test-qobject-input-visitor.c                 | 62 ++++++++++++----------
tests/test-qobject-output-visitor.c                |  4 +-
util/keyval.c                                      | 10 ++--
27 files changed, 140 insertions(+), 88 deletions(-)
create mode 100644 tests/qapi-schema/alternate-conflict-enum-bool.err
create mode 100644 tests/qapi-schema/alternate-conflict-enum-bool.exit
create mode 100644 tests/qapi-schema/alternate-conflict-enum-bool.json
create mode 100644 tests/qapi-schema/alternate-conflict-enum-bool.out
create mode 100644 tests/qapi-schema/alternate-conflict-enum-int.err
create mode 100644 tests/qapi-schema/alternate-conflict-enum-int.exit
create mode 100644 tests/qapi-schema/alternate-conflict-enum-int.json
create mode 100644 tests/qapi-schema/alternate-conflict-enum-int.out
[Qemu-devel] [PATCH 0/4] qapi: Handle some keyval fallout
Posted by Markus Armbruster 6 years, 11 months ago
Markus Armbruster (4):
  qobject-input-visitor: Reject non-finite numbers with keyval
  qapi: Document visit_type_any() issues with keyval input
  tests/qapi-schema: Avoid 'str' in alternate test cases
  qapi: Reject alternates that can't work with keyval_parse()

 include/qapi/visitor.h                             |  4 ++
 qapi/qobject-input-visitor.c                       |  3 +-
 scripts/qapi.py                                    | 19 ++++++-
 tests/Makefile.include                             |  2 +
 tests/qapi-schema/alternate-clash.json             |  2 +-
 tests/qapi-schema/alternate-conflict-dict.json     |  2 +-
 tests/qapi-schema/alternate-conflict-enum-bool.err |  1 +
 .../qapi-schema/alternate-conflict-enum-bool.exit  |  1 +
 .../qapi-schema/alternate-conflict-enum-bool.json  |  6 +++
 tests/qapi-schema/alternate-conflict-enum-bool.out |  0
 tests/qapi-schema/alternate-conflict-enum-int.err  |  1 +
 tests/qapi-schema/alternate-conflict-enum-int.exit |  1 +
 tests/qapi-schema/alternate-conflict-enum-int.json |  6 +++
 tests/qapi-schema/alternate-conflict-enum-int.out  |  0
 tests/qapi-schema/alternate-conflict-string.err    |  2 +-
 tests/qapi-schema/alternate-conflict-string.json   |  6 +--
 tests/qapi-schema/alternate-nested.json            |  2 +-
 tests/qapi-schema/args-alternate.json              |  2 +-
 tests/qapi-schema/doc-bad-alternate-member.json    |  2 +-
 tests/qapi-schema/qapi-schema-test.json            | 13 +++--
 tests/qapi-schema/qapi-schema-test.out             | 34 ++++++------
 tests/qapi-schema/returns-alternate.json           |  2 +-
 tests/test-clone-visitor.c                         | 23 ++++----
 tests/test-keyval.c                                | 18 ++++---
 tests/test-qobject-input-visitor.c                 | 62 ++++++++++++----------
 tests/test-qobject-output-visitor.c                |  4 +-
 util/keyval.c                                      | 10 ++--
 27 files changed, 140 insertions(+), 88 deletions(-)
 create mode 100644 tests/qapi-schema/alternate-conflict-enum-bool.err
 create mode 100644 tests/qapi-schema/alternate-conflict-enum-bool.exit
 create mode 100644 tests/qapi-schema/alternate-conflict-enum-bool.json
 create mode 100644 tests/qapi-schema/alternate-conflict-enum-bool.out
 create mode 100644 tests/qapi-schema/alternate-conflict-enum-int.err
 create mode 100644 tests/qapi-schema/alternate-conflict-enum-int.exit
 create mode 100644 tests/qapi-schema/alternate-conflict-enum-int.json
 create mode 100644 tests/qapi-schema/alternate-conflict-enum-int.out

-- 
2.7.4


Re: [Qemu-devel] [PATCH 0/4] qapi: Handle some keyval fallout
Posted by Marc-André Lureau 6 years, 10 months ago
On Mon, May 22, 2017 at 8:45 PM Markus Armbruster <armbru@redhat.com> wrote:

> Markus Armbruster (4):
>   qobject-input-visitor: Reject non-finite numbers with keyval
>   qapi: Document visit_type_any() issues with keyval input
>   tests/qapi-schema: Avoid 'str' in alternate test cases
>   qapi: Reject alternates that can't work with keyval_parse()
>
>  include/qapi/visitor.h                             |  4 ++
>  qapi/qobject-input-visitor.c                       |  3 +-
>  scripts/qapi.py                                    | 19 ++++++-
>  tests/Makefile.include                             |  2 +
>  tests/qapi-schema/alternate-clash.json             |  2 +-
>  tests/qapi-schema/alternate-conflict-dict.json     |  2 +-
>  tests/qapi-schema/alternate-conflict-enum-bool.err |  1 +
>  .../qapi-schema/alternate-conflict-enum-bool.exit  |  1 +
>  .../qapi-schema/alternate-conflict-enum-bool.json  |  6 +++
>  tests/qapi-schema/alternate-conflict-enum-bool.out |  0
>  tests/qapi-schema/alternate-conflict-enum-int.err  |  1 +
>  tests/qapi-schema/alternate-conflict-enum-int.exit |  1 +
>  tests/qapi-schema/alternate-conflict-enum-int.json |  6 +++
>  tests/qapi-schema/alternate-conflict-enum-int.out  |  0
>  tests/qapi-schema/alternate-conflict-string.err    |  2 +-
>  tests/qapi-schema/alternate-conflict-string.json   |  6 +--
>  tests/qapi-schema/alternate-nested.json            |  2 +-
>  tests/qapi-schema/args-alternate.json              |  2 +-
>  tests/qapi-schema/doc-bad-alternate-member.json    |  2 +-
>  tests/qapi-schema/qapi-schema-test.json            | 13 +++--
>  tests/qapi-schema/qapi-schema-test.out             | 34 ++++++------
>  tests/qapi-schema/returns-alternate.json           |  2 +-
>  tests/test-clone-visitor.c                         | 23 ++++----
>  tests/test-keyval.c                                | 18 ++++---
>  tests/test-qobject-input-visitor.c                 | 62
> ++++++++++++----------
>  tests/test-qobject-output-visitor.c                |  4 +-
>  util/keyval.c                                      | 10 ++--
>  27 files changed, 140 insertions(+), 88 deletions(-)
>  create mode 100644 tests/qapi-schema/alternate-conflict-enum-bool.err
>  create mode 100644 tests/qapi-schema/alternate-conflict-enum-bool.exit
>  create mode 100644 tests/qapi-schema/alternate-conflict-enum-bool.json
>  create mode 100644 tests/qapi-schema/alternate-conflict-enum-bool.out
>  create mode 100644 tests/qapi-schema/alternate-conflict-enum-int.err
>  create mode 100644 tests/qapi-schema/alternate-conflict-enum-int.exit
>  create mode 100644 tests/qapi-schema/alternate-conflict-enum-int.json
>  create mode 100644 tests/qapi-schema/alternate-conflict-enum-int.out
>
>
Reviewed-by: Marc-André Lureau <marcandre.lureau@redhat.com>


-- 
Marc-André Lureau