[Qemu-devel] [PATCH RESEND V2 0/3] Optimize filter-mirror and filter-rewriter

Zhang Chen posted 3 patches 6 years, 10 months ago
Patches applied successfully (tree, apply log)
git fetch https://github.com/patchew-project/qemu tags/patchew/1494829102-1812-1-git-send-email-zhangchen.fnst@cn.fujitsu.com
Test checkpatch passed
Test docker passed
Test s390x passed
There is a newer version of this series
net/filter-mirror.c | 35 ++++++++++++++++-------------------
qemu-options.hx     |  2 +-
2 files changed, 17 insertions(+), 20 deletions(-)
[Qemu-devel] [PATCH RESEND V2 0/3] Optimize filter-mirror and filter-rewriter
Posted by Zhang Chen 6 years, 10 months ago
Fix some duplicate codes and remove unused codes.

v2: Address Eric's comment on patch 3.

Zhang Chen (3):
  net/filter-mirror.c: Remove duplicate check code.
  net/filter-mirror.c: Rename filter_mirror_send() and fix codestyle
  net/filter-rewriter: Remove unused option in filter-rewriter

 net/filter-mirror.c | 35 ++++++++++++++++-------------------
 qemu-options.hx     |  2 +-
 2 files changed, 17 insertions(+), 20 deletions(-)

-- 
2.7.4




Re: [Qemu-devel] [PATCH RESEND V2 0/3] Optimize filter-mirror and filter-rewriter
Posted by Jason Wang 6 years, 10 months ago

On 2017年05月15日 14:18, Zhang Chen wrote:
> Fix some duplicate codes and remove unused codes.
>
> v2: Address Eric's comment on patch 3.
>
> Zhang Chen (3):
>    net/filter-mirror.c: Remove duplicate check code.
>    net/filter-mirror.c: Rename filter_mirror_send() and fix codestyle
>    net/filter-rewriter: Remove unused option in filter-rewriter
>
>   net/filter-mirror.c | 35 ++++++++++++++++-------------------
>   qemu-options.hx     |  2 +-
>   2 files changed, 17 insertions(+), 20 deletions(-)
>

Hi:

What's the difference compared with V2? I think I should apply this series?

Thanks

Re: [Qemu-devel] [PATCH RESEND V2 0/3] Optimize filter-mirror and filter-rewriter
Posted by Zhang Chen 6 years, 10 months ago

On 05/16/2017 02:48 PM, Jason Wang wrote:
>
>
> On 2017年05月15日 14:18, Zhang Chen wrote:
>> Fix some duplicate codes and remove unused codes.
>>
>> v2: Address Eric's comment on patch 3.
>>
>> Zhang Chen (3):
>>    net/filter-mirror.c: Remove duplicate check code.
>>    net/filter-mirror.c: Rename filter_mirror_send() and fix codestyle
>>    net/filter-rewriter: Remove unused option in filter-rewriter
>>
>>   net/filter-mirror.c | 35 ++++++++++++++++-------------------
>>   qemu-options.hx     |  2 +-
>>   2 files changed, 17 insertions(+), 20 deletions(-)
>>
>
> Hi:
>
> What's the difference compared with V2? I think I should apply this 
> series?

In V2 I forgot remove "," in patch 3/3, Yes, please apply this series.

>
> Thanks
>
>
>

-- 
Thanks
Zhang Chen




Re: [Qemu-devel] [PATCH RESEND V2 0/3] Optimize filter-mirror and filter-rewriter
Posted by Eric Blake 6 years, 10 months ago
On 05/16/2017 03:22 AM, Zhang Chen wrote:

>>
>> What's the difference compared with V2? I think I should apply this
>> series?
> 
> In V2 I forgot remove "," in patch 3/3, Yes, please apply this series.

If you changed the patches, even just to add a ',', then it's best to
post the resend as "v3", not "RESEND V2".  Also, documenting what
changed between versions, rather than just blindly titling a message
RESEND (or even explaining WHY you are resending without change, such as
to correct an incorrect cc to save people the problem of bounce replies
when replying to the thread), is good netiquette.

-- 
Eric Blake, Principal Software Engineer
Red Hat, Inc.           +1-919-301-3266
Virtualization:  qemu.org | libvirt.org

Re: [Qemu-devel] [PATCH RESEND V2 0/3] Optimize filter-mirror and filter-rewriter
Posted by Zhang Chen 6 years, 10 months ago

On 05/16/2017 10:42 PM, Eric Blake wrote:
> On 05/16/2017 03:22 AM, Zhang Chen wrote:
>
>>> What's the difference compared with V2? I think I should apply this
>>> series?
>> In V2 I forgot remove "," in patch 3/3, Yes, please apply this series.
> If you changed the patches, even just to add a ',', then it's best to
> post the resend as "v3", not "RESEND V2".  Also, documenting what
> changed between versions, rather than just blindly titling a message
> RESEND (or even explaining WHY you are resending without change, such as
> to correct an incorrect cc to save people the problem of bounce replies
> when replying to the thread), is good netiquette.

OK, I got your point, will send the V3 later.

Thanks
Zhang Chen

>

-- 
Thanks
Zhang Chen