From nobody Sun May 5 17:39:49 2024 Delivered-To: importer@patchew.org Received-SPF: pass (zoho.com: domain of gnu.org designates 208.118.235.17 as permitted sender) client-ip=208.118.235.17; envelope-from=qemu-devel-bounces+importer=patchew.org@nongnu.org; helo=lists.gnu.org; Authentication-Results: mx.zoho.com; spf=pass (zoho.com: domain of gnu.org designates 208.118.235.17 as permitted sender) smtp.mailfrom=qemu-devel-bounces+importer=patchew.org@nongnu.org; Return-Path: Received: from lists.gnu.org (lists.gnu.org [208.118.235.17]) by mx.zohomail.com with SMTPS id 149436913526829.32952806180083; Tue, 9 May 2017 15:32:15 -0700 (PDT) Received: from localhost ([::1]:39700 helo=lists.gnu.org) by lists.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1d8Dfw-00021N-SP for importer@patchew.org; Tue, 09 May 2017 18:32:12 -0400 Received: from eggs.gnu.org ([2001:4830:134:3::10]:41703) by lists.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1d8Df7-0001jL-25 for qemu-devel@nongnu.org; Tue, 09 May 2017 18:31:21 -0400 Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71) (envelope-from ) id 1d8Df1-0002LD-Su for qemu-devel@nongnu.org; Tue, 09 May 2017 18:31:20 -0400 Received: from mga03.intel.com ([134.134.136.65]:36913) by eggs.gnu.org with esmtps (TLS1.0:DHE_RSA_AES_256_CBC_SHA1:32) (Exim 4.71) (envelope-from ) id 1d8Df1-0002Kr-KO for qemu-devel@nongnu.org; Tue, 09 May 2017 18:31:15 -0400 Received: from fmsmga004.fm.intel.com ([10.253.24.48]) by orsmga103.jf.intel.com with ESMTP/TLS/DHE-RSA-AES256-GCM-SHA384; 09 May 2017 15:31:11 -0700 Received: from xps7800.sc.intel.com ([10.3.52.155]) by fmsmga004.fm.intel.com with ESMTP; 09 May 2017 15:31:11 -0700 X-ExtLoop1: 1 X-IronPort-AV: E=Sophos;i="5.38,316,1491289200"; d="scan'208";a="259190742" From: Anthony Xu To: qemu-devel@nongnu.org Date: Tue, 9 May 2017 15:37:12 -0700 Message-Id: <1494369432-15418-1-git-send-email-anthony.xu@intel.com> X-Mailer: git-send-email 1.8.3.1 X-detected-operating-system: by eggs.gnu.org: Genre and OS details not recognized. X-Received-From: 134.134.136.65 Subject: [Qemu-devel] [PATCH] trace: add sanity check X-BeenThere: qemu-devel@nongnu.org X-Mailman-Version: 2.1.21 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Cc: pbonzini@redhat.com, Anthony Xu , stefanha@redhat.com Errors-To: qemu-devel-bounces+importer=patchew.org@nongnu.org Sender: "Qemu-devel" X-ZohoMail: RSF_0 Z_629925259 SPT_0 Content-Transfer-Encoding: quoted-printable MIME-Version: 1.0 Content-Type: text/plain; charset="utf-8" If trace backend is set to TRACE_NOP, trace_get_vcpu_event_count returns 0, cause bitmap_new call abort. Signed-off-by: Anthony Xu --- qom/cpu.c | 6 +++++- 1 file changed, 5 insertions(+), 1 deletion(-) diff --git a/qom/cpu.c b/qom/cpu.c index f02e9c0..f9111a0 100644 --- a/qom/cpu.c +++ b/qom/cpu.c @@ -382,6 +382,7 @@ static void cpu_common_unrealizefn(DeviceState *dev, Er= ror **errp) =20 static void cpu_common_initfn(Object *obj) { + uint32_t count; CPUState *cpu =3D CPU(obj); CPUClass *cc =3D CPU_GET_CLASS(obj); =20 @@ -396,7 +397,10 @@ static void cpu_common_initfn(Object *obj) QTAILQ_INIT(&cpu->breakpoints); QTAILQ_INIT(&cpu->watchpoints); =20 - cpu->trace_dstate =3D bitmap_new(trace_get_vcpu_event_count()); + count =3D trace_get_vcpu_event_count(); + if (count) { + cpu->trace_dstate =3D bitmap_new(count); + } =20 cpu_exec_initfn(cpu); } --=20 1.8.3.1