[v2] kvm: irqchip: skip msi update when msi disabled

[Qemu-devel] [PATCH v2 0/3] kvm: irqchip: skip msi update when msi disabled

Peter Xu posted 3 patches 6 years, 11 months ago

Diff against v1
Download series mbox

Patches applied successfully (tree, apply log)
git fetch https://github.com/patchew-project/qemu tags/patchew/1494309644-18743-1-git-send-email-peterx@redhat.com

Test checkpatch passed

Test docker passed

Test s390x passed

hw/pci/msix.c       | 11 +++++++++--
hw/pci/trace-events |  3 +++
kvm-all.c           |  4 +++-
target/i386/kvm.c   | 13 +++++++++----
trace-events        |  3 ++-
5 files changed, 26 insertions(+), 8 deletions(-)

Expand all Fold all

[Qemu-devel] [PATCH v2 0/3] kvm: irqchip: skip msi update when msi disabled

Posted by Peter Xu 6 years, 11 months ago

v2:
- missed one line in last patch to include msix header

First two patches are new traces, please collect them if needed.

The third patch is a fix to a qemu crash reported here:

  https://bugzilla.redhat.com/show_bug.cgi?id=1448813

Please see its commit message for more information.

Please review. Thanks.

Peter Xu (3):
  kvm: irqchip: trace changes on msi add/remove
  msix: trace control bit write op
  kvm: irqchip: skip update msi when disabled

 hw/pci/msix.c       | 11 +++++++++--
 hw/pci/trace-events |  3 +++
 kvm-all.c           |  4 +++-
 target/i386/kvm.c   | 13 +++++++++----
 trace-events        |  3 ++-
 5 files changed, 26 insertions(+), 8 deletions(-)

-- 
2.7.4

Re: [Qemu-devel] [PATCH v2 0/3] kvm: irqchip: skip msi update when msi disabled

Posted by Paolo Bonzini 6 years, 11 months ago


On 09/05/2017 08:00, Peter Xu wrote:
> v2:
> - missed one line in last patch to include msix header
> 
> First two patches are new traces, please collect them if needed.
> 
> The third patch is a fix to a qemu crash reported here:
> 
>   https://bugzilla.redhat.com/show_bug.cgi?id=1448813
> 
> Please see its commit message for more information.
> 
> Please review. Thanks.
> 
> Peter Xu (3):
>   kvm: irqchip: trace changes on msi add/remove
>   msix: trace control bit write op
>   kvm: irqchip: skip update msi when disabled
> 
>  hw/pci/msix.c       | 11 +++++++++--
>  hw/pci/trace-events |  3 +++
>  kvm-all.c           |  4 +++-
>  target/i386/kvm.c   | 13 +++++++++----
>  trace-events        |  3 ++-
>  5 files changed, 26 insertions(+), 8 deletions(-)
> 

Looks good, queued for 2.10.  Michael, would you like to ack patch 2?

Thanks,

Paolo