From nobody Sun Apr 28 00:44:46 2024 Delivered-To: importer@patchew.org Received-SPF: pass (zoho.com: domain of gnu.org designates 208.118.235.17 as permitted sender) client-ip=208.118.235.17; envelope-from=qemu-devel-bounces+importer=patchew.org@nongnu.org; helo=lists.gnu.org; Authentication-Results: mx.zoho.com; dkim=fail spf=pass (zoho.com: domain of gnu.org designates 208.118.235.17 as permitted sender) smtp.mailfrom=qemu-devel-bounces+importer=patchew.org@nongnu.org; Return-Path: Received: from lists.gnu.org (lists.gnu.org [208.118.235.17]) by mx.zohomail.com with SMTPS id 14914867238251014.373082921916; Thu, 6 Apr 2017 06:52:03 -0700 (PDT) Received: from localhost ([::1]:45965 helo=lists.gnu.org) by lists.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1cw7pS-0000Qe-L7 for importer@patchew.org; Thu, 06 Apr 2017 09:52:02 -0400 Received: from eggs.gnu.org ([2001:4830:134:3::10]:52611) by lists.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1cw7Ge-0003C3-W8 for qemu-devel@nongnu.org; Thu, 06 Apr 2017 09:16:05 -0400 Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71) (envelope-from ) id 1cw7Gc-00035b-Jr for qemu-devel@nongnu.org; Thu, 06 Apr 2017 09:16:04 -0400 Received: from mail-pg0-x241.google.com ([2607:f8b0:400e:c05::241]:36426) by eggs.gnu.org with esmtps (TLS1.0:RSA_AES_128_CBC_SHA1:16) (Exim 4.71) (envelope-from ) id 1cw7Gc-00034r-DI; Thu, 06 Apr 2017 09:16:02 -0400 Received: by mail-pg0-x241.google.com with SMTP id 81so8447863pgh.3; Thu, 06 Apr 2017 06:16:02 -0700 (PDT) Received: from localhost.localdomain ([123.206.110.226]) by smtp.gmail.com with ESMTPSA id n7sm4029624pfn.0.2017.04.06.06.15.58 (version=TLS1_2 cipher=ECDHE-RSA-AES128-GCM-SHA256 bits=128/128); Thu, 06 Apr 2017 06:16:01 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20161025; h=from:to:cc:subject:date:message-id:in-reply-to:references; bh=n5LH2L2kyUrfG7i8fN1C98hsbTqus6cJvRYI/Xye954=; b=hb8W0MISqaiR4TznvpjYkoOT/WYYmQCch872xtZqJpmwy8n6+BDMyRDZ1ioFEdndVd rxj5Yvr1wLYgxWU3eNMzPv6h2gvpXUYJGMGXrwWqD2nsqllOmgs5+jnroj0RWZvpNXst uSC4NZgZtcjp3/mvMTAvOD62aOrTntuGVsUNXY6P3h+00qfPuathLO1upIZH646cOELH K/tJ+iSTB4IHUr4yFIVdrGSX00jLh081qszGplJA0flm/wjQG7YgVaRawy+Nn09QkM97 4LSDULeIGO+XAeSVMkXkukwZ1QXxR+8Y0UT9EvVVd0Qg2PmRDLd/IfZl1P15hbxUV6Pd vppA== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:from:to:cc:subject:date:message-id:in-reply-to :references; bh=n5LH2L2kyUrfG7i8fN1C98hsbTqus6cJvRYI/Xye954=; b=tlHJ9MNcXybtI4cTpnsJNAa8Gr4tbPSgICr7F8p3hRhCKtshwmnAlhbAw4gX/oYqTg WRbORM4gnDIHJ6f1DFz9OktzlMb8fxOmgzw9CQcs1vs67pLdngNhPkZP0KhAO+rx/2o2 KgLIi0kMt6k0xLjrX366r7eDIqfSs+53EYUXqs0sasWSaBA+4mrLMW2WSlhM1IFf6nBw mzxOH7OxaZ5uwqxCzhX6urzQPsXdgNEI5T2or2ntPHWWXpE0VW9nNbzXUo515W5j0Fr7 UrkVkVtuNrsZy4LA4GfGmRexzeWEYi/g51v4nHhHVP5djuxigFQQhS5G/QywtY7+xQDZ UZZw== X-Gm-Message-State: AFeK/H07NqFawjbI4oP7nKNsHCzpYIxSHgFOGcedE52/9BlZDz43k9H00nhbGXV2KR8MoA== X-Received: by 10.99.227.69 with SMTP id o5mr36575357pgj.133.1491484561668; Thu, 06 Apr 2017 06:16:01 -0700 (PDT) From: jemmy858585@gmail.com X-Google-Original-From: lidongchen@tencent.com To: qemu-devel@nongnu.org Date: Thu, 6 Apr 2017 21:15:35 +0800 Message-Id: <1491484536-22776-2-git-send-email-lidongchen@tencent.com> X-Mailer: git-send-email 1.8.3.1 In-Reply-To: <1491484536-22776-1-git-send-email-lidongchen@tencent.com> References: <1491484536-22776-1-git-send-email-lidongchen@tencent.com> X-detected-operating-system: by eggs.gnu.org: GNU/Linux 2.2.x-3.x [generic] X-Received-From: 2607:f8b0:400e:c05::241 Subject: [Qemu-devel] [PATCH 1/2] block: make bdrv_get_cluster_size public X-BeenThere: qemu-devel@nongnu.org X-Mailman-Version: 2.1.21 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Cc: kwolf@redhat.com, famz@redhat.com, qemu-block@nongnu.org, quintela@redhat.com, dgilbert@redhat.com, mreitz@redhat.com, stefanha@redhat.com, Lidong Chen Errors-To: qemu-devel-bounces+importer=patchew.org@nongnu.org Sender: "Qemu-devel" X-ZohoMail-DKIM: fail (Header signature does not verify) X-ZohoMail: RDKM_2 RSF_0 Z_629925259 SPT_0 Content-Transfer-Encoding: quoted-printable MIME-Version: 1.0 Content-Type: text/plain; charset="utf-8" From: Lidong Chen The bdrv_get_cluster_size function is need by block migration to optimize zero cluster. Signed-off-by: Lidong Chen --- block/io.c | 2 +- include/block/block.h | 1 + 2 files changed, 2 insertions(+), 1 deletion(-) diff --git a/block/io.c b/block/io.c index 2709a70..1c31c2b 100644 --- a/block/io.c +++ b/block/io.c @@ -459,7 +459,7 @@ void bdrv_round_to_clusters(BlockDriverState *bs, } } =20 -static int bdrv_get_cluster_size(BlockDriverState *bs) +int bdrv_get_cluster_size(BlockDriverState *bs) { BlockDriverInfo bdi; int ret; diff --git a/include/block/block.h b/include/block/block.h index 5149260..a0d78fc 100644 --- a/include/block/block.h +++ b/include/block/block.h @@ -473,6 +473,7 @@ void bdrv_round_to_clusters(BlockDriverState *bs, int64_t offset, unsigned int bytes, int64_t *cluster_offset, unsigned int *cluster_bytes); +int bdrv_get_cluster_size(BlockDriverState *bs); =20 const char *bdrv_get_encrypted_filename(BlockDriverState *bs); void bdrv_get_backing_filename(BlockDriverState *bs, --=20 1.8.3.1 From nobody Sun Apr 28 00:44:46 2024 Delivered-To: importer@patchew.org Received-SPF: pass (zoho.com: domain of gnu.org designates 208.118.235.17 as permitted sender) client-ip=208.118.235.17; envelope-from=qemu-devel-bounces+importer=patchew.org@nongnu.org; helo=lists.gnu.org; Authentication-Results: mx.zoho.com; dkim=fail spf=pass (zoho.com: domain of gnu.org designates 208.118.235.17 as permitted sender) smtp.mailfrom=qemu-devel-bounces+importer=patchew.org@nongnu.org; Return-Path: Received: from lists.gnu.org (lists.gnu.org [208.118.235.17]) by mx.zohomail.com with SMTPS id 1491486886881158.92975378042172; Thu, 6 Apr 2017 06:54:46 -0700 (PDT) Received: from localhost ([::1]:45984 helo=lists.gnu.org) by lists.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1cw7s5-0002XZ-KR for importer@patchew.org; Thu, 06 Apr 2017 09:54:45 -0400 Received: from eggs.gnu.org ([2001:4830:134:3::10]:52666) by lists.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1cw7Gl-0003I5-3c for qemu-devel@nongnu.org; Thu, 06 Apr 2017 09:16:15 -0400 Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71) (envelope-from ) id 1cw7Gf-000399-DS for qemu-devel@nongnu.org; Thu, 06 Apr 2017 09:16:11 -0400 Received: from mail-pg0-x242.google.com ([2607:f8b0:400e:c05::242]:33578) by eggs.gnu.org with esmtps (TLS1.0:RSA_AES_128_CBC_SHA1:16) (Exim 4.71) (envelope-from ) id 1cw7Gf-00038m-8Q; Thu, 06 Apr 2017 09:16:05 -0400 Received: by mail-pg0-x242.google.com with SMTP id 79so8461330pgf.0; Thu, 06 Apr 2017 06:16:05 -0700 (PDT) Received: from localhost.localdomain ([123.206.110.226]) by smtp.gmail.com with ESMTPSA id n7sm4029624pfn.0.2017.04.06.06.16.01 (version=TLS1_2 cipher=ECDHE-RSA-AES128-GCM-SHA256 bits=128/128); Thu, 06 Apr 2017 06:16:04 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20161025; h=from:to:cc:subject:date:message-id:in-reply-to:references; bh=oZTW+0JiSeRjS4LsF3WJss7Vj4ad1+CO3mx9SbANm+Y=; b=TIekhfPspsvd6Z9rsDviKldDZq5zn2hhVc3C1nyW3rb8nqXTvu/9s+/u4yORMTsOAM kscBRFZ0HLEYU2chmGnmjMKxY8UQEyYy5Ax2AhWWohOcrhxQniH28pPXMox194RSRZ+b WYfQhfia9RYI/cwLJKpYObGrI12ivXP0OXbSMD8TlwKY57o2kK4W6Y4117Gsz0VoLiVr FQbJAgvlVjJEjv7E6HfPcUvll9RVgm9/e6nHljhrhPM/s7dJBlgQmKjYbfojUwGNqnSL aZsvcv45tRUulp/FbwSU6z/uSP3PqJuMrGjxS5lpeqfPyK0deNstoMb1tj7Ry6CvQrL4 wquQ== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:from:to:cc:subject:date:message-id:in-reply-to :references; bh=oZTW+0JiSeRjS4LsF3WJss7Vj4ad1+CO3mx9SbANm+Y=; b=Uoywl+g8UEYKRpqJ3Mw94kzCNCLJqO7LWMaT6xZXOhIJSiS/aKK9ArR/o7c23EfBa7 a+Yk3A33V5JUs7S9dpUb5pEUpiwOmFAHiUcWurEKFKUqvf2AgKiWdx4GOnJSA9A+PpgQ 0txWxud8e5EXbHPUbSAU/I0C6UwCBFkke3Yp1/PPvkaqadNzPMT46Wb0ySFLQQgFhMEL WrzCu01mBD6Dr3mG4h12flr8pIeddPr6C2q/boolCg/6b0Z0Laxs3FqJ5IbQBH5oyjNh LxjRsV9C4gYOiPmGYCpf1IlKcQeRA34piHiRJ5pttgXMcJjwX7vGU4NHrxbZeSskCdSW 6gcw== X-Gm-Message-State: AFeK/H0us5e7ldQ9TOVIwAfUQpC2WX+CUbhuGx1i+vk+8Wjlu0BJtx2x7NwuD61NJSMPXw== X-Received: by 10.84.238.22 with SMTP id u22mr43669002plk.137.1491484564418; Thu, 06 Apr 2017 06:16:04 -0700 (PDT) From: jemmy858585@gmail.com X-Google-Original-From: lidongchen@tencent.com To: qemu-devel@nongnu.org Date: Thu, 6 Apr 2017 21:15:36 +0800 Message-Id: <1491484536-22776-3-git-send-email-lidongchen@tencent.com> X-Mailer: git-send-email 1.8.3.1 In-Reply-To: <1491484536-22776-1-git-send-email-lidongchen@tencent.com> References: <1491484536-22776-1-git-send-email-lidongchen@tencent.com> X-detected-operating-system: by eggs.gnu.org: GNU/Linux 2.2.x-3.x [generic] X-Received-From: 2607:f8b0:400e:c05::242 Subject: [Qemu-devel] [PATCH 2/2] migration/block: use blk_pwrite_zeroes for each zero cluster X-BeenThere: qemu-devel@nongnu.org X-Mailman-Version: 2.1.21 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Cc: kwolf@redhat.com, famz@redhat.com, qemu-block@nongnu.org, quintela@redhat.com, dgilbert@redhat.com, mreitz@redhat.com, stefanha@redhat.com, Lidong Chen Errors-To: qemu-devel-bounces+importer=patchew.org@nongnu.org Sender: "Qemu-devel" X-ZohoMail-DKIM: fail (Header signature does not verify) X-ZohoMail: RDKM_2 RSF_0 Z_629925259 SPT_0 Content-Transfer-Encoding: quoted-printable MIME-Version: 1.0 Content-Type: text/plain; charset="utf-8" From: Lidong Chen BLOCK_SIZE is (1 << 20), qcow2 cluster size is 65536 by default, this maybe cause the qcow2 file size is bigger after migration. This patch check each cluster, use blk_pwrite_zeroes for each zero cluster. Signed-off-by: Lidong Chen --- migration/block.c | 34 ++++++++++++++++++++++++++++++++-- 1 file changed, 32 insertions(+), 2 deletions(-) diff --git a/migration/block.c b/migration/block.c index 7734ff7..1fce9b9 100644 --- a/migration/block.c +++ b/migration/block.c @@ -885,6 +885,10 @@ static int block_load(QEMUFile *f, void *opaque, int v= ersion_id) int64_t total_sectors =3D 0; int nr_sectors; int ret; + int i; + int cluster_size; + int64_t addr_offset; + uint8_t *buf_offset; =20 do { addr =3D qemu_get_be64(f); @@ -934,8 +938,34 @@ static int block_load(QEMUFile *f, void *opaque, int v= ersion_id) } else { buf =3D g_malloc(BLOCK_SIZE); qemu_get_buffer(f, buf, BLOCK_SIZE); - ret =3D blk_pwrite(blk, addr * BDRV_SECTOR_SIZE, buf, - nr_sectors * BDRV_SECTOR_SIZE, 0); + + cluster_size =3D bdrv_get_cluster_size(blk_bs(blk)); + + if (cluster_size > 0) { + for (i =3D 0; i < BLOCK_SIZE / cluster_size; i++) { + addr_offset =3D addr * BDRV_SECTOR_SIZE + + i * cluster_size; + buf_offset =3D buf + i * cluster_size; + + if (buffer_is_zero(buf_offset, cluster_size)) { + ret =3D blk_pwrite_zeroes(blk, addr_offset, + cluster_size, + BDRV_REQ_MAY_UNMAP); + } else { + ret =3D blk_pwrite(blk, addr_offset, + buf_offset, cluster_size, 0); + } + + if (ret < 0) { + g_free(buf); + return ret; + } + } + } else { + ret =3D blk_pwrite(blk, addr * BDRV_SECTOR_SIZE, buf, + nr_sectors * BDRV_SECTOR_SIZE, 0); + } + g_free(buf); } =20 --=20 1.8.3.1