[Qemu-devel] [PATCH 00/14] TCX/CG3 adapter cleanups

Mark Cave-Ayland posted 14 patches 6 years, 11 months ago
Patches applied successfully (tree, apply log)
git fetch https://github.com/patchew-project/qemu tags/patchew/1491381329-3995-1-git-send-email-mark.cave-ayland@ilande.co.uk
Test checkpatch passed
Test docker passed
Test s390x passed
There is a newer version of this series
hw/display/cg3.c |   23 ++---
hw/display/tcx.c |  298 +++++++++++-------------------------------------------
hw/sparc/sun4m.c |    2 -
3 files changed, 69 insertions(+), 254 deletions(-)
[Qemu-devel] [PATCH 00/14] TCX/CG3 adapter cleanups
Posted by Mark Cave-Ayland 6 years, 11 months ago
This started as part of the work on Gerd's thread-safe display patches
but ended up turning into something a lot more comprehensive. It contains
lots of cleanupm and fixes for display invalidation (particularly on 24-bit
TCX) exposed by testing the thread-safe patchset.

Signed-off-by: Mark Cave-Ayland <mark.cave-ayland@ilande.co.uk>

Mark Cave-Ayland (14):
  cg3: remove TARGET_PAGE_SIZE rounding on dirty page detection
  cg3: fix up size parameter for memory_region_get_dirty()
  cg3: remove unused width and height variables
  cg3: switch to load_image_mr() and remove prom-addr hack
  tcx: alter tcx_set_dirty() to accept address and length parameters
  tcx: ensure tcx_set_dirty() also invalidates the 24-bit plane and
    cplane
  tcx: alter tcx24_check_dirty() to accept address and length
    parameters
  tcx: alter tcx24_reset_dirty() to accept address and length
    parameters
  tcx: remove page24 and cpage from tcx24_update_display()
  tcx: remove TARGET_PAGE_SIZE from tcx_update_display()
  tcx: remove TARGET_PAGE_SIZE from tcx24_update_display()
  tcx: remove primitives for non-32-bit surfaces
  tcx: use tcx_set_dirty() for accelerated ops
  tcx: switch to load_image_mr() and remove prom_addr hack

 hw/display/cg3.c |   23 ++---
 hw/display/tcx.c |  298 +++++++++++-------------------------------------------
 hw/sparc/sun4m.c |    2 -
 3 files changed, 69 insertions(+), 254 deletions(-)

-- 
1.7.10.4


Re: [Qemu-devel] [PATCH 00/14] TCX/CG3 adapter cleanups
Posted by Gerd Hoffmann 6 years, 11 months ago
On Mi, 2017-04-05 at 09:35 +0100, Mark Cave-Ayland wrote:
> This started as part of the work on Gerd's thread-safe display patches
> but ended up turning into something a lot more comprehensive. It contains
> lots of cleanupm and fixes for display invalidation (particularly on 24-bit
> TCX) exposed by testing the thread-safe patchset.
> 
> Signed-off-by: Mark Cave-Ayland <mark.cave-ayland@ilande.co.uk>

Looks all fine to me.

Reviewed-by: Gerd Hoffmann <kraxel@redhat.com>

You'll merge them through the sparc queue I guess?

cheers,
  Gerd


Re: [Qemu-devel] [PATCH 00/14] TCX/CG3 adapter cleanups
Posted by Mark Cave-Ayland 6 years, 11 months ago
On 07/04/17 11:28, Gerd Hoffmann wrote:

> On Mi, 2017-04-05 at 09:35 +0100, Mark Cave-Ayland wrote:
>> This started as part of the work on Gerd's thread-safe display patches
>> but ended up turning into something a lot more comprehensive. It contains
>> lots of cleanupm and fixes for display invalidation (particularly on 24-bit
>> TCX) exposed by testing the thread-safe patchset.
>>
>> Signed-off-by: Mark Cave-Ayland <mark.cave-ayland@ilande.co.uk>
> 
> Looks all fine to me.
> 
> Reviewed-by: Gerd Hoffmann <kraxel@redhat.com>
> 
> You'll merge them through the sparc queue I guess?

Yes, I can do. I think it makes sense to merge them before your display
thread-safety series, so if that still works for you I'll send a pull
request early on when the tree opens for 2.10 to clear the way for your
updates.


ATB,

Mark.


Re: [Qemu-devel] [PATCH 00/14] TCX/CG3 adapter cleanups
Posted by Gerd Hoffmann 6 years, 11 months ago
  Hi,

> Yes, I can do. I think it makes sense to merge them before your display
> thread-safety series, so if that still works for you I'll send a pull
> request early on when the tree opens for 2.10 to clear the way for your
> updates.

Sounds good.  Maybe I split the series anyway, first merge the snapshot
infrastructure patches, then all the display updates, finally revert the
temporary workaround, to reduce the ordering headaches.

cheers,
  Gerd