From nobody Tue May 7 04:22:09 2024 Delivered-To: importer@patchew.org Received-SPF: pass (zoho.com: domain of gnu.org designates 208.118.235.17 as permitted sender) client-ip=208.118.235.17; envelope-from=qemu-devel-bounces+importer=patchew.org@nongnu.org; helo=lists.gnu.org; Authentication-Results: mx.zoho.com; spf=pass (zoho.com: domain of gnu.org designates 208.118.235.17 as permitted sender) smtp.mailfrom=qemu-devel-bounces+importer=patchew.org@nongnu.org; Return-Path: Received: from lists.gnu.org (lists.gnu.org [208.118.235.17]) by mx.zohomail.com with SMTPS id 1491224852809944.6322596491749; Mon, 3 Apr 2017 06:07:32 -0700 (PDT) Received: from localhost ([::1]:59302 helo=lists.gnu.org) by lists.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1cv1hj-0000q9-Ci for importer@patchew.org; Mon, 03 Apr 2017 09:07:31 -0400 Received: from eggs.gnu.org ([2001:4830:134:3::10]:58710) by lists.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1cv1ek-00074N-Tj for qemu-devel@nongnu.org; Mon, 03 Apr 2017 09:04:28 -0400 Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71) (envelope-from ) id 1cv1ej-00024s-U2 for qemu-devel@nongnu.org; Mon, 03 Apr 2017 09:04:26 -0400 Received: from orth.archaic.org.uk ([2001:8b0:1d0::2]:49057) by eggs.gnu.org with esmtps (TLS1.0:RSA_AES_128_CBC_SHA1:16) (Exim 4.71) (envelope-from ) id 1cv1ej-0001yW-OB for qemu-devel@nongnu.org; Mon, 03 Apr 2017 09:04:25 -0400 Received: from pm215 by orth.archaic.org.uk with local (Exim 4.84_2) (envelope-from ) id 1cv1ea-0007fu-9Y; Mon, 03 Apr 2017 14:04:16 +0100 From: Peter Maydell To: qemu-devel@nongnu.org Date: Mon, 3 Apr 2017 14:04:15 +0100 Message-Id: <1491224655-5776-1-git-send-email-peter.maydell@linaro.org> X-Mailer: git-send-email 2.7.4 X-detected-operating-system: by eggs.gnu.org: GNU/Linux 2.2.x-3.x [generic] X-Received-From: 2001:8b0:1d0::2 Subject: [Qemu-devel] [PATCH for-2.9] configure: on Windows minimum glib version must be 2.30 X-BeenThere: qemu-devel@nongnu.org X-Mailman-Version: 2.1.21 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Cc: Stefan Weil , Mark Cave-Ayland , patches@linaro.org Errors-To: qemu-devel-bounces+importer=patchew.org@nongnu.org Sender: "Qemu-devel" X-ZohoMail: RSF_0 Z_629925259 SPT_0 Content-Transfer-Encoding: quoted-printable MIME-Version: 1.0 Content-Type: text/plain; charset="utf-8" In the 2.7 release we stated in the ChangeLog that the minimum glib version for Windows hosts was 2.30, but we didn't update configure to enforce this because we were very close to the release at the point where we noticed the issue, and it only affected building the test suite. We then forgot that we needed to do it. Fix the omission. (The reason for the 2.30 requirement is use of g_dir_make_tmp() -- our fallback implementation uses mkdtemp(), which isn't available on Windows.) Reported-by: Mark Cave-Ayland Signed-off-by: Peter Maydell Reviewed-by: Philippe Mathieu-Daud=C3=A9 --- configure | 6 +++++- 1 file changed, 5 insertions(+), 1 deletion(-) diff --git a/configure b/configure index 4b3b5cd..be4d326 100755 --- a/configure +++ b/configure @@ -3073,7 +3073,11 @@ fi ########################################## # glib support probe =20 -glib_req_ver=3D2.22 +if test "$mingw32" =3D yes; then + glib_req_ver=3D2.30 +else + glib_req_ver=3D2.22 +fi glib_modules=3Dgthread-2.0 if test "$modules" =3D yes; then glib_modules=3D"$glib_modules gmodule-2.0" --=20 2.7.4