[Qemu-devel] [PATCH v4 for-2.9 00/10] rbd: Clean up API and code

Markus Armbruster posted 10 patches 7 years ago
Patches applied successfully (tree, apply log)
git fetch https://github.com/patchew-project/qemu tags/patchew/1490691368-32099-1-git-send-email-armbru@redhat.com
Test checkpatch passed
Test docker passed
Test s390x passed
block/rbd.c          | 319 ++++++++++++++-------------------------------------
qapi-schema.json     |  21 ++--
qapi/block-core.json |  30 +----
3 files changed, 100 insertions(+), 270 deletions(-)
[Qemu-devel] [PATCH v4 for-2.9 00/10] rbd: Clean up API and code
Posted by Markus Armbruster 7 years ago
I really, really want to correct a few issues in external interfaces
before while I can.  Bonus: several minor bug fixes.

Thanks to Jeff Cody for testing this series.

v4:
* PATCH 01,04-06 unchanged
* PATCH 02 commit message fixed up [Jeff]
* PATCH 03 commit message tweak [Jeff]
* PATCH 07 fixed to use qdict_get_try_str() [Max]
* PATCH 08 commit message amended [Eric]
* PATCH 09 fixed to revert the code change, too [Jeff]
* old PATCH 10 dropped, PATCH 11 trivially rebased [Eric]

v3:
* PATCH 01-07 unchanged except for a doc tweak in PATCH 06
* PATCH 08-10 replace PATCH 9
* PATCH 8 becomes PATCH 11, rebased on top of 08-10, commit message
  updated, R-by dropped

Markus Armbruster (10):
  rbd: Reject -blockdev server.*.{numeric,to,ipv4,ipv6}
  rbd: Fix to cleanly reject -drive without pool or image
  rbd: Don't limit length of parameter values
  rbd: Clean up after the previous commit
  rbd: Don't accept -drive driver=rbd,keyvalue-pairs=...
  rbd: Clean up runtime_opts, fix -drive to reject filename
  rbd: Clean up qemu_rbd_create()'s detour through QemuOpts
  rbd: Revert -blockdev and -drive parameter auth-supported
  rbd: Revert -blockdev parameter password-secret
  rbd: Fix bugs around -drive parameter "server"

 block/rbd.c          | 319 ++++++++++++++-------------------------------------
 qapi-schema.json     |  21 ++--
 qapi/block-core.json |  30 +----
 3 files changed, 100 insertions(+), 270 deletions(-)

-- 
2.7.4


Re: [Qemu-devel] [PATCH v4 for-2.9 00/10] rbd: Clean up API and code
Posted by Jeff Cody 7 years ago
On Tue, Mar 28, 2017 at 10:55:58AM +0200, Markus Armbruster wrote:
> I really, really want to correct a few issues in external interfaces
> before while I can.  Bonus: several minor bug fixes.
> 
> Thanks to Jeff Cody for testing this series.
> 
> v4:
> * PATCH 01,04-06 unchanged
> * PATCH 02 commit message fixed up [Jeff]
> * PATCH 03 commit message tweak [Jeff]
> * PATCH 07 fixed to use qdict_get_try_str() [Max]
> * PATCH 08 commit message amended [Eric]
> * PATCH 09 fixed to revert the code change, too [Jeff]
> * old PATCH 10 dropped, PATCH 11 trivially rebased [Eric]
> 
> v3:
> * PATCH 01-07 unchanged except for a doc tweak in PATCH 06
> * PATCH 08-10 replace PATCH 9
> * PATCH 8 becomes PATCH 11, rebased on top of 08-10, commit message
>   updated, R-by dropped
> 
> Markus Armbruster (10):
>   rbd: Reject -blockdev server.*.{numeric,to,ipv4,ipv6}
>   rbd: Fix to cleanly reject -drive without pool or image
>   rbd: Don't limit length of parameter values
>   rbd: Clean up after the previous commit
>   rbd: Don't accept -drive driver=rbd,keyvalue-pairs=...
>   rbd: Clean up runtime_opts, fix -drive to reject filename
>   rbd: Clean up qemu_rbd_create()'s detour through QemuOpts
>   rbd: Revert -blockdev and -drive parameter auth-supported
>   rbd: Revert -blockdev parameter password-secret
>   rbd: Fix bugs around -drive parameter "server"
> 
>  block/rbd.c          | 319 ++++++++++++++-------------------------------------
>  qapi-schema.json     |  21 ++--
>  qapi/block-core.json |  30 +----
>  3 files changed, 100 insertions(+), 270 deletions(-)
> 
> -- 
> 2.7.4
> 

Thanks,

Applied to my block branch:

git://github.com/codyprime/qemu-kvm-jtc.git block

-Jeff