[Qemu-devel] [PATCH] e1000: disable debug by default

Jason Wang posted 1 patch 7 years ago
Patches applied successfully (tree, apply log)
git fetch https://github.com/patchew-project/qemu tags/patchew/1490152052-9660-1-git-send-email-jasowang@redhat.com
Test checkpatch passed
Test docker passed
Test s390x passed
hw/net/e1000.c | 2 +-
1 file changed, 1 insertion(+), 1 deletion(-)
[Qemu-devel] [PATCH] e1000: disable debug by default
Posted by Jason Wang 7 years ago
Disable debug output by default, the information were not needed for
release.

Cc: Peter Maydell <peter.maydell@linaro.org>
Cc: Stefan Hajnoczi <stefanha@gmail.com>
Cc: Leonid Bloch <leonid.bloch@ravellosystems.com>
Cc: Dmitry Fleytman <dmitry.fleytman@ravellosystems.com>
Cc: qemu-stable@nongnu.org
Signed-off-by: Jason Wang <jasowang@redhat.com>
---
 hw/net/e1000.c | 2 +-
 1 file changed, 1 insertion(+), 1 deletion(-)

diff --git a/hw/net/e1000.c b/hw/net/e1000.c
index 9324949..f2e5072 100644
--- a/hw/net/e1000.c
+++ b/hw/net/e1000.c
@@ -40,7 +40,7 @@
 
 static const uint8_t bcast[] = {0xff, 0xff, 0xff, 0xff, 0xff, 0xff};
 
-#define E1000_DEBUG
+/* #define E1000_DEBUG */
 
 #ifdef E1000_DEBUG
 enum {
-- 
2.7.4


Re: [Qemu-devel] [PATCH] e1000: disable debug by default
Posted by Philippe Mathieu-Daudé 7 years ago
On 03/22/2017 12:07 AM, Jason Wang wrote:
> Disable debug output by default, the information were not needed for
> release.
>
> Cc: Peter Maydell <peter.maydell@linaro.org>
> Cc: Stefan Hajnoczi <stefanha@gmail.com>
> Cc: Leonid Bloch <leonid.bloch@ravellosystems.com>
> Cc: Dmitry Fleytman <dmitry.fleytman@ravellosystems.com>
> Cc: qemu-stable@nongnu.org
> Signed-off-by: Jason Wang <jasowang@redhat.com>

Reviewed-by: Philippe Mathieu-Daudé <f4bug@amsat.org>

> ---
>  hw/net/e1000.c | 2 +-
>  1 file changed, 1 insertion(+), 1 deletion(-)
>
> diff --git a/hw/net/e1000.c b/hw/net/e1000.c
> index 9324949..f2e5072 100644
> --- a/hw/net/e1000.c
> +++ b/hw/net/e1000.c
> @@ -40,7 +40,7 @@
>
>  static const uint8_t bcast[] = {0xff, 0xff, 0xff, 0xff, 0xff, 0xff};
>
> -#define E1000_DEBUG
> +/* #define E1000_DEBUG */
>
>  #ifdef E1000_DEBUG
>  enum {
>

Re: [Qemu-devel] [PATCH] e1000: disable debug by default
Posted by Stefan Hajnoczi 7 years ago
On Wed, Mar 22, 2017 at 11:07:32AM +0800, Jason Wang wrote:
> Disable debug output by default, the information were not needed for
> release.
> 
> Cc: Peter Maydell <peter.maydell@linaro.org>
> Cc: Stefan Hajnoczi <stefanha@gmail.com>
> Cc: Leonid Bloch <leonid.bloch@ravellosystems.com>
> Cc: Dmitry Fleytman <dmitry.fleytman@ravellosystems.com>
> Cc: qemu-stable@nongnu.org
> Signed-off-by: Jason Wang <jasowang@redhat.com>
> ---
>  hw/net/e1000.c | 2 +-
>  1 file changed, 1 insertion(+), 1 deletion(-)

Reviewed-by: Stefan Hajnoczi <stefanha@redhat.com>
Re: [Qemu-devel] [PATCH] e1000: disable debug by default
Posted by Jason Wang 7 years ago

On 2017年03月22日 11:07, Jason Wang wrote:
> Disable debug output by default, the information were not needed for
> release.
>
> Cc: Peter Maydell <peter.maydell@linaro.org>
> Cc: Stefan Hajnoczi <stefanha@gmail.com>
> Cc: Leonid Bloch <leonid.bloch@ravellosystems.com>
> Cc: Dmitry Fleytman <dmitry.fleytman@ravellosystems.com>
> Cc: qemu-stable@nongnu.org
> Signed-off-by: Jason Wang <jasowang@redhat.com>
> ---
>   hw/net/e1000.c | 2 +-
>   1 file changed, 1 insertion(+), 1 deletion(-)
>
> diff --git a/hw/net/e1000.c b/hw/net/e1000.c
> index 9324949..f2e5072 100644
> --- a/hw/net/e1000.c
> +++ b/hw/net/e1000.c
> @@ -40,7 +40,7 @@
>   
>   static const uint8_t bcast[] = {0xff, 0xff, 0xff, 0xff, 0xff, 0xff};
>   
> -#define E1000_DEBUG
> +/* #define E1000_DEBUG */
>   
>   #ifdef E1000_DEBUG
>   enum {

Applied, thanks.