cputlb.c | 81 ++++++++++++++----------- hw/misc/Makefile.objs | 1 + hw/misc/mmio_interface.c | 128 +++++++++++++++++++++++++++++++++++++++ hw/ssi/xilinx_spips.c | 74 ++++++++++++++++------ include/exec/memory.h | 35 +++++++++++ include/hw/misc/mmio_interface.h | 49 +++++++++++++++ include/hw/qdev-properties.h | 2 + memory.c | 57 +++++++++++++++++ 8 files changed, 372 insertions(+), 55 deletions(-) create mode 100644 hw/misc/mmio_interface.c create mode 100644 include/hw/misc/mmio_interface.h
From: KONRAD Frederic <fred.konrad@greensocs.com> This series allows to execute code from mmio areas. The main goal of this is to be able to run code for example from an SPI device. The three first patch fixes the way get_page_addr_code fills the TLB. The fourth patch implements the mmio execution helpers: the device must implement the request_ptr callback of the MemoryRegion and will be notified when the guest wants to execute code from it. The fifth patch introduces mmio_interface device which allows to dynamically map a host pointer somewhere into the memory. The sixth patch implements the execution from the SPI memories in the xilinx_spips model. Thanks, Fred V1 -> V2: * Fix the DPRINTF error. RFC -> V1: * Use an interface (mmio-interface) to fix any reference leak issue. KONRAD Frederic (7): cputlb: cleanup get_page_addr_code to use VICTIM_TLB_HIT cputlb: move get_page_addr_code cputlb: fix the way get_page_addr_code fills the tlb exec: allow to get a pointer for some mmio memory region qdev: add MemoryRegion property introduce mmio_interface xilinx_spips: allow mmio execution cputlb.c | 81 ++++++++++++++----------- hw/misc/Makefile.objs | 1 + hw/misc/mmio_interface.c | 128 +++++++++++++++++++++++++++++++++++++++ hw/ssi/xilinx_spips.c | 74 ++++++++++++++++------ include/exec/memory.h | 35 +++++++++++ include/hw/misc/mmio_interface.h | 49 +++++++++++++++ include/hw/qdev-properties.h | 2 + memory.c | 57 +++++++++++++++++ 8 files changed, 372 insertions(+), 55 deletions(-) create mode 100644 hw/misc/mmio_interface.c create mode 100644 include/hw/misc/mmio_interface.h -- 1.8.3.1
Ping! Would be nice for us if we can get this into 2.9. Thanks, Fred Le 17/02/2017 à 21:17, fred.konrad@greensocs.com a écrit : > From: KONRAD Frederic <fred.konrad@greensocs.com> > > This series allows to execute code from mmio areas. > The main goal of this is to be able to run code for example from an SPI device. > > The three first patch fixes the way get_page_addr_code fills the TLB. > > The fourth patch implements the mmio execution helpers: the device must > implement the request_ptr callback of the MemoryRegion and will be notified when > the guest wants to execute code from it. > > The fifth patch introduces mmio_interface device which allows to dynamically > map a host pointer somewhere into the memory. > > The sixth patch implements the execution from the SPI memories in the > xilinx_spips model. > > Thanks, > Fred > > V1 -> V2: > * Fix the DPRINTF error. > RFC -> V1: > * Use an interface (mmio-interface) to fix any reference leak issue. > > KONRAD Frederic (7): > cputlb: cleanup get_page_addr_code to use VICTIM_TLB_HIT > cputlb: move get_page_addr_code > cputlb: fix the way get_page_addr_code fills the tlb > exec: allow to get a pointer for some mmio memory region > qdev: add MemoryRegion property > introduce mmio_interface > xilinx_spips: allow mmio execution > > cputlb.c | 81 ++++++++++++++----------- > hw/misc/Makefile.objs | 1 + > hw/misc/mmio_interface.c | 128 +++++++++++++++++++++++++++++++++++++++ > hw/ssi/xilinx_spips.c | 74 ++++++++++++++++------ > include/exec/memory.h | 35 +++++++++++ > include/hw/misc/mmio_interface.h | 49 +++++++++++++++ > include/hw/qdev-properties.h | 2 + > memory.c | 57 +++++++++++++++++ > 8 files changed, 372 insertions(+), 55 deletions(-) > create mode 100644 hw/misc/mmio_interface.c > create mode 100644 include/hw/misc/mmio_interface.h >
On 21/02/2017 09:51, KONRAD Frederic wrote: > Ping! > > Would be nice for us if we can get this into 2.9. Sorry, I've been much busier with icount than I would have liked. :( Paolo > Thanks, > Fred > > Le 17/02/2017 à 21:17, fred.konrad@greensocs.com a écrit : >> From: KONRAD Frederic <fred.konrad@greensocs.com> >> >> This series allows to execute code from mmio areas. >> The main goal of this is to be able to run code for example from an >> SPI device. >> >> The three first patch fixes the way get_page_addr_code fills the TLB. >> >> The fourth patch implements the mmio execution helpers: the device must >> implement the request_ptr callback of the MemoryRegion and will be >> notified when >> the guest wants to execute code from it. >> >> The fifth patch introduces mmio_interface device which allows to >> dynamically >> map a host pointer somewhere into the memory. >> >> The sixth patch implements the execution from the SPI memories in the >> xilinx_spips model. >> >> Thanks, >> Fred >> >> V1 -> V2: >> * Fix the DPRINTF error. >> RFC -> V1: >> * Use an interface (mmio-interface) to fix any reference leak issue. >> >> KONRAD Frederic (7): >> cputlb: cleanup get_page_addr_code to use VICTIM_TLB_HIT >> cputlb: move get_page_addr_code >> cputlb: fix the way get_page_addr_code fills the tlb >> exec: allow to get a pointer for some mmio memory region >> qdev: add MemoryRegion property >> introduce mmio_interface >> xilinx_spips: allow mmio execution >> >> cputlb.c | 81 ++++++++++++++----------- >> hw/misc/Makefile.objs | 1 + >> hw/misc/mmio_interface.c | 128 >> +++++++++++++++++++++++++++++++++++++++ >> hw/ssi/xilinx_spips.c | 74 ++++++++++++++++------ >> include/exec/memory.h | 35 +++++++++++ >> include/hw/misc/mmio_interface.h | 49 +++++++++++++++ >> include/hw/qdev-properties.h | 2 + >> memory.c | 57 +++++++++++++++++ >> 8 files changed, 372 insertions(+), 55 deletions(-) >> create mode 100644 hw/misc/mmio_interface.c >> create mode 100644 include/hw/misc/mmio_interface.h >>
Hi All, Any feedback for the 4 last patches? Thanks, Fred On 02/17/2017 09:17 PM, fred.konrad@greensocs.com wrote: > From: KONRAD Frederic <fred.konrad@greensocs.com> > > This series allows to execute code from mmio areas. > The main goal of this is to be able to run code for example from an SPI device. > > The three first patch fixes the way get_page_addr_code fills the TLB. > > The fourth patch implements the mmio execution helpers: the device must > implement the request_ptr callback of the MemoryRegion and will be notified when > the guest wants to execute code from it. > > The fifth patch introduces mmio_interface device which allows to dynamically > map a host pointer somewhere into the memory. > > The sixth patch implements the execution from the SPI memories in the > xilinx_spips model. > > Thanks, > Fred > > V1 -> V2: > * Fix the DPRINTF error. > RFC -> V1: > * Use an interface (mmio-interface) to fix any reference leak issue. > > KONRAD Frederic (7): > cputlb: cleanup get_page_addr_code to use VICTIM_TLB_HIT > cputlb: move get_page_addr_code > cputlb: fix the way get_page_addr_code fills the tlb > exec: allow to get a pointer for some mmio memory region > qdev: add MemoryRegion property > introduce mmio_interface > xilinx_spips: allow mmio execution > > cputlb.c | 81 ++++++++++++++----------- > hw/misc/Makefile.objs | 1 + > hw/misc/mmio_interface.c | 128 +++++++++++++++++++++++++++++++++++++++ > hw/ssi/xilinx_spips.c | 74 ++++++++++++++++------ > include/exec/memory.h | 35 +++++++++++ > include/hw/misc/mmio_interface.h | 49 +++++++++++++++ > include/hw/qdev-properties.h | 2 + > memory.c | 57 +++++++++++++++++ > 8 files changed, 372 insertions(+), 55 deletions(-) > create mode 100644 hw/misc/mmio_interface.c > create mode 100644 include/hw/misc/mmio_interface.h >
On Fri, Feb 17, 2017 at 09:17:06PM +0100, fred.konrad@greensocs.com wrote: > From: KONRAD Frederic <fred.konrad@greensocs.com> > > This series allows to execute code from mmio areas. > The main goal of this is to be able to run code for example from an SPI device. > > The three first patch fixes the way get_page_addr_code fills the TLB. > > The fourth patch implements the mmio execution helpers: the device must > implement the request_ptr callback of the MemoryRegion and will be notified when > the guest wants to execute code from it. > > The fifth patch introduces mmio_interface device which allows to dynamically > map a host pointer somewhere into the memory. > > The sixth patch implements the execution from the SPI memories in the > xilinx_spips model. I had a comment on the possible break of bisection, but the series looks good to me. If you fix up the ordering: Reviewed-by: Edgar E. Iglesias <edgar.iglesias@xilinx.com> Cheers, Edgar > > Thanks, > Fred > > V1 -> V2: > * Fix the DPRINTF error. > RFC -> V1: > * Use an interface (mmio-interface) to fix any reference leak issue. > > KONRAD Frederic (7): > cputlb: cleanup get_page_addr_code to use VICTIM_TLB_HIT > cputlb: move get_page_addr_code > cputlb: fix the way get_page_addr_code fills the tlb > exec: allow to get a pointer for some mmio memory region > qdev: add MemoryRegion property > introduce mmio_interface > xilinx_spips: allow mmio execution > > cputlb.c | 81 ++++++++++++++----------- > hw/misc/Makefile.objs | 1 + > hw/misc/mmio_interface.c | 128 +++++++++++++++++++++++++++++++++++++++ > hw/ssi/xilinx_spips.c | 74 ++++++++++++++++------ > include/exec/memory.h | 35 +++++++++++ > include/hw/misc/mmio_interface.h | 49 +++++++++++++++ > include/hw/qdev-properties.h | 2 + > memory.c | 57 +++++++++++++++++ > 8 files changed, 372 insertions(+), 55 deletions(-) > create mode 100644 hw/misc/mmio_interface.c > create mode 100644 include/hw/misc/mmio_interface.h > > -- > 1.8.3.1 > >
© 2016 - 2024 Red Hat, Inc.