[Qemu-devel] [PULL 00/23] Misc patches for 2017-02-16

Paolo Bonzini posted 23 patches 7 years, 2 months ago
Patches applied successfully (tree, apply log)
git fetch https://github.com/patchew-project/qemu tags/patchew/1487255507-106654-1-git-send-email-pbonzini@redhat.com
Test checkpatch failed
Test docker passed
Test s390x passed
There is a newer version of this series
Makefile                  |   6 +-
chardev/char-pty.c        |   2 +-
chardev/char-socket.c     |  10 +++
cpu-exec.c                |  86 ++++++++++---------
cpus.c                    |  42 ++++++++++
gdbstub.c                 | 209 +++++++++++++++++++++++++++++++++++-----------
hw/char/mcf_uart.c        | 102 ++++++++++++++++------
hw/i386/kvm/ioapic.c      |  13 ++-
hw/intc/apic_common.c     |   2 +
hw/intc/ioapic.c          |   6 +-
hw/m68k/mcf5208.c         |   6 +-
hw/misc/pvpanic.c         |   2 +-
hw/ppc/spapr_rtas.c       |   3 +-
include/exec/exec-all.h   |   1 +
include/hw/m68k/mcf.h     |   6 +-
include/qom/cpu.h         |  10 +++
include/sysemu/sysemu.h   |   4 +-
kvm-all.c                 |   3 +-
qapi-schema.json          |  24 ++++++
qapi/event.json           |   6 +-
qemu-nbd.c                | 172 ++++++++++++++++++++++++++++++++++++--
qemu-options.hx           |   4 +-
qom/cpu.c                 |  11 +++
target/i386/cpu.c         |  51 +++++++++++
target/i386/cpu.h         |   5 +-
target/i386/excp_helper.c |  11 +--
target/i386/helper.h      |   1 -
target/i386/misc_helper.c |  24 +++---
target/i386/seg_helper.c  |   6 +-
target/i386/svm_helper.c  |  65 +++++++-------
target/s390x/kvm.c        |   4 +-
tests/test-vmstate.c      |  11 ---
vl.c                      |  56 +++++--------
33 files changed, 711 insertions(+), 253 deletions(-)
[Qemu-devel] [PULL 00/23] Misc patches for 2017-02-16
Posted by Paolo Bonzini 7 years, 2 months ago
The following changes since commit 5dae13cd71f0755a1395b5a4cde635b8a6ee3f58:

  Merge remote-tracking branch 'remotes/rth/tags/pull-or-20170214' into staging (2017-02-14 09:55:48 +0000)

are available in the git repository at:


  git://github.com/bonzini/qemu.git tags/for-upstream

for you to fetch changes up to 395d41a549f69f4ec603afa3d3ade1e2005777d5:

  target-i386: correctly propagate retaddr into SVM helpers (2017-02-16 15:30:49 +0100)

----------------------------------------------------------------
* GUEST_PANICKED improvements (Anton)
* vCont gdbstub rewrite (Claudio)
* Fix CPU creation with -device (Liyang)
* Logging fixes for pty chardevs (Ed)
* Makefile "move if changed" fix (Lin)
* First part of cpu_exec refactoring (me)
* SVM emulation fix (me)
* apic_delivered fix (Pavel)
* "info ioapic" fix (Peter)
* qemu-nbd socket activation (Richard)
* QOMification of mcf_uart (Thomas)

----------------------------------------------------------------
Alberto Garcia (1):
      qemu-doc: Clarify that -vga std is now the default

Anton Nefedov (4):
      qemu-char: socket backend: disconnect on write error
      i386/cpu: add crash-information QOM property
      report guest crash information in GUEST_PANICKED event
      vl: log available guest crash information

Claudio Imbrenda (2):
      move vm_start to cpus.c
      gdbstub: Fix vCont behaviour

Dou Liyang (1):
      vl: Move the cpu_synchronize_all_post_init() after generic devices initialization

Ed Swierk (1):
      char: drop data written to a disconnected pty

Lin Ma (1):
      Makefile: avoid leaving the temporary QEMU_PKGVERSION header file

Paolo Bonzini (7):
      test-vmstate: remove yield_until_fd_readable
      cpu-exec: fix icount out-of-bounds access
      cpu-exec: tighten barrier on TCG_EXIT_REQUESTED
      cpu-exec: avoid cpu_loop_exit in cpu_handle_interrupt
      cpu-exec: avoid repeated sigsetjmp on interrupts
      cpu-exec: remove outermost infinite loop
      target-i386: correctly propagate retaddr into SVM helpers

Pavel Dovgalyuk (1):
      apic: reset apic_delivered global variable on machine reset

Peter Xu (3):
      kvm/ioapic: dump real object instead of a fake one
      ioapic: fix error report value of def version
      kvm/ioapic: correct kvm ioapic version

Richard W.M. Jones (1):
      qemu-nbd: Implement socket activation.

Thomas Huth (1):
      hw/char/mcf_uart: QOMify the ColdFire UART

 Makefile                  |   6 +-
 chardev/char-pty.c        |   2 +-
 chardev/char-socket.c     |  10 +++
 cpu-exec.c                |  86 ++++++++++---------
 cpus.c                    |  42 ++++++++++
 gdbstub.c                 | 209 +++++++++++++++++++++++++++++++++++-----------
 hw/char/mcf_uart.c        | 102 ++++++++++++++++------
 hw/i386/kvm/ioapic.c      |  13 ++-
 hw/intc/apic_common.c     |   2 +
 hw/intc/ioapic.c          |   6 +-
 hw/m68k/mcf5208.c         |   6 +-
 hw/misc/pvpanic.c         |   2 +-
 hw/ppc/spapr_rtas.c       |   3 +-
 include/exec/exec-all.h   |   1 +
 include/hw/m68k/mcf.h     |   6 +-
 include/qom/cpu.h         |  10 +++
 include/sysemu/sysemu.h   |   4 +-
 kvm-all.c                 |   3 +-
 qapi-schema.json          |  24 ++++++
 qapi/event.json           |   6 +-
 qemu-nbd.c                | 172 ++++++++++++++++++++++++++++++++++++--
 qemu-options.hx           |   4 +-
 qom/cpu.c                 |  11 +++
 target/i386/cpu.c         |  51 +++++++++++
 target/i386/cpu.h         |   5 +-
 target/i386/excp_helper.c |  11 +--
 target/i386/helper.h      |   1 -
 target/i386/misc_helper.c |  24 +++---
 target/i386/seg_helper.c  |   6 +-
 target/i386/svm_helper.c  |  65 +++++++-------
 target/s390x/kvm.c        |   4 +-
 tests/test-vmstate.c      |  11 ---
 vl.c                      |  56 +++++--------
 33 files changed, 711 insertions(+), 253 deletions(-)
-- 
1.8.3.1


Re: [Qemu-devel] [PULL 00/23] Misc patches for 2017-02-16
Posted by no-reply@patchew.org 7 years, 2 months ago
Hi,

This series seems to have some coding style problems. See output below for
more information:

Type: series
Subject: [Qemu-devel] [PULL 00/23] Misc patches for 2017-02-16
Message-id: 1487255507-106654-1-git-send-email-pbonzini@redhat.com

=== TEST SCRIPT BEGIN ===
#!/bin/bash

BASE=base
n=1
total=$(git log --oneline $BASE.. | wc -l)
failed=0

# Useful git options
git config --local diff.renamelimit 0
git config --local diff.renames True

commits="$(git log --format=%H --reverse $BASE..)"
for c in $commits; do
    echo "Checking PATCH $n/$total: $(git log -n 1 --format=%s $c)..."
    if ! git show $c --format=email | ./scripts/checkpatch.pl --mailback -; then
        failed=1
        echo
    fi
    n=$((n+1))
done

exit $failed
=== TEST SCRIPT END ===

Updating 3c8cf5a9c21ff8782164d1def7f44bd888713384
From https://github.com/patchew-project/qemu
 * [new tag]         patchew/1487255507-106654-1-git-send-email-pbonzini@redhat.com -> patchew/1487255507-106654-1-git-send-email-pbonzini@redhat.com
Switched to a new branch 'test'
a842dba target-i386: correctly propagate retaddr into SVM helpers
36f0d76 vl: log available guest crash information
5951e60 report guest crash information in GUEST_PANICKED event
e3d0196 i386/cpu: add crash-information QOM property
b22a547 Makefile: avoid leaving the temporary QEMU_PKGVERSION header file
1ac46cf vl: Move the cpu_synchronize_all_post_init() after generic devices initialization
ad5c282 qemu-nbd: Implement socket activation.
511652d qemu-doc: Clarify that -vga std is now the default
7ab8e56 cpu-exec: remove outermost infinite loop
8a13214 cpu-exec: avoid repeated sigsetjmp on interrupts
03e16ce cpu-exec: avoid cpu_loop_exit in cpu_handle_interrupt
4ff5c14 cpu-exec: tighten barrier on TCG_EXIT_REQUESTED
942cdfa cpu-exec: fix icount out-of-bounds access
91aa9ee hw/char/mcf_uart: QOMify the ColdFire UART
f437c15 gdbstub: Fix vCont behaviour
239bca2 move vm_start to cpus.c
5aab44b char: drop data written to a disconnected pty
f50cc4e apic: reset apic_delivered global variable on machine reset
d4b7bdc qemu-char: socket backend: disconnect on write error
26e8792 test-vmstate: remove yield_until_fd_readable
8394c0b kvm/ioapic: correct kvm ioapic version
30cb597 ioapic: fix error report value of def version
342745d kvm/ioapic: dump real object instead of a fake one

=== OUTPUT BEGIN ===
Checking PATCH 1/23: kvm/ioapic: dump real object instead of a fake one...
Checking PATCH 2/23: ioapic: fix error report value of def version...
Checking PATCH 3/23: kvm/ioapic: correct kvm ioapic version...
Checking PATCH 4/23: test-vmstate: remove yield_until_fd_readable...
Checking PATCH 5/23: qemu-char: socket backend: disconnect on write error...
Checking PATCH 6/23: apic: reset apic_delivered global variable on machine reset...
Checking PATCH 7/23: char: drop data written to a disconnected pty...
Checking PATCH 8/23: move vm_start to cpus.c...
Checking PATCH 9/23: gdbstub: Fix vCont behaviour...
Checking PATCH 10/23: hw/char/mcf_uart: QOMify the ColdFire UART...
Checking PATCH 11/23: cpu-exec: fix icount out-of-bounds access...
Checking PATCH 12/23: cpu-exec: tighten barrier on TCG_EXIT_REQUESTED...
ERROR: memory barrier without comment
#51: FILE: cpu-exec.c:559:
+        smp_mb();

total: 1 errors, 0 warnings, 13 lines checked

Your patch has style problems, please review.  If any of these errors
are false positives report them to the maintainer, see
CHECKPATCH in MAINTAINERS.

Checking PATCH 13/23: cpu-exec: avoid cpu_loop_exit in cpu_handle_interrupt...
Checking PATCH 14/23: cpu-exec: avoid repeated sigsetjmp on interrupts...
Checking PATCH 15/23: cpu-exec: remove outermost infinite loop...
WARNING: line over 80 characters
#51: FILE: cpu-exec.c:633:
+         * Newer versions of gcc would complain about this code (-Wclobbered). */

total: 0 errors, 1 warnings, 68 lines checked

Your patch has style problems, please review.  If any of these errors
are false positives report them to the maintainer, see
CHECKPATCH in MAINTAINERS.
Checking PATCH 16/23: qemu-doc: Clarify that -vga std is now the default...
Checking PATCH 17/23: qemu-nbd: Implement socket activation....
Checking PATCH 18/23: vl: Move the cpu_synchronize_all_post_init() after generic devices initialization...
Checking PATCH 19/23: Makefile: avoid leaving the temporary QEMU_PKGVERSION header file...
Checking PATCH 20/23: i386/cpu: add crash-information QOM property...
Checking PATCH 21/23: report guest crash information in GUEST_PANICKED event...
Checking PATCH 22/23: vl: log available guest crash information...
Checking PATCH 23/23: target-i386: correctly propagate retaddr into SVM helpers...
WARNING: line over 80 characters
#76: FILE: target/i386/excp_helper.c:57:
+            cpu_vmexit(env, SVM_EXIT_SHUTDOWN, 0, retaddr); /* does not return */

total: 0 errors, 1 warnings, 368 lines checked

Your patch has style problems, please review.  If any of these errors
are false positives report them to the maintainer, see
CHECKPATCH in MAINTAINERS.
=== OUTPUT END ===

Test command exited with code: 1


---
Email generated automatically by Patchew [http://patchew.org/].
Please send your feedback to patchew-devel@freelists.org
Re: [Qemu-devel] [PULL 00/23] Misc patches for 2017-02-16
Posted by Peter Maydell 7 years, 2 months ago
On 16 February 2017 at 14:31, Paolo Bonzini <pbonzini@redhat.com> wrote:
> The following changes since commit 5dae13cd71f0755a1395b5a4cde635b8a6ee3f58:
>
>   Merge remote-tracking branch 'remotes/rth/tags/pull-or-20170214' into staging (2017-02-14 09:55:48 +0000)
>
> are available in the git repository at:
>
>
>   git://github.com/bonzini/qemu.git tags/for-upstream
>
> for you to fetch changes up to 395d41a549f69f4ec603afa3d3ade1e2005777d5:
>
>   target-i386: correctly propagate retaddr into SVM helpers (2017-02-16 15:30:49 +0100)
>
> ----------------------------------------------------------------
> * GUEST_PANICKED improvements (Anton)
> * vCont gdbstub rewrite (Claudio)
> * Fix CPU creation with -device (Liyang)
> * Logging fixes for pty chardevs (Ed)
> * Makefile "move if changed" fix (Lin)
> * First part of cpu_exec refactoring (me)
> * SVM emulation fix (me)
> * apic_delivered fix (Pavel)
> * "info ioapic" fix (Peter)
> * qemu-nbd socket activation (Richard)
> * QOMification of mcf_uart (Thomas)

Fails to build on 32-bit ARM:

/home/petmay01/qemu/target/i386/svm_helper.c:63:6: error: conflicting
types for 'cpu_v
mexit'
 void cpu_vmexit(CPUX86State *nenv, uint32_t exit_code, uint64_t exit_info_1,
      ^
In file included from /home/petmay01/qemu/target/i386/svm_helper.c:21:0:
/home/petmay01/qemu/target/i386/cpu.h:1625:6: note: previous
declaration of 'cpu_vmexit' was here
 void cpu_vmexit(CPUX86State *nenv, uint32_t exit_code, uint64_t exit_info_1,
      ^
/home/petmay01/qemu/rules.mak:69: recipe for target
'target/i386/svm_helper.o' failed

The problem is in the bit of the prototype the error message
doesn't quote:

Prototype in cpu.h:
  void cpu_vmexit(CPUX86State *nenv, uint32_t exit_code, uint64_t exit_info_1,
                  uintptr_t retaddr);

svm_helper.c stub version;
  void cpu_vmexit(CPUX86State *nenv, uint32_t exit_code, uint64_t exit_info_1,
                  uint64_t retaddr)

svm_helper.c real version:
  void cpu_vmexit(CPUX86State *env, uint32_t exit_code, uint64_t exit_info_1,
                  uintptr_t retaddr)

On 32-bit uintptr_t and uint64_t aren't the same thing.

thanks
-- PMM

Re: [Qemu-devel] [PULL 00/23] Misc patches for 2017-02-16
Posted by Paolo Bonzini 7 years, 2 months ago
> The problem is in the bit of the prototype the error message
> doesn't quote:
> 
> Prototype in cpu.h:
>   void cpu_vmexit(CPUX86State *nenv, uint32_t exit_code, uint64_t
>   exit_info_1,
>                   uintptr_t retaddr);
> 
> svm_helper.c stub version;
>   void cpu_vmexit(CPUX86State *nenv, uint32_t exit_code, uint64_t
>   exit_info_1,
>                   uint64_t retaddr)
> 
> svm_helper.c real version:
>   void cpu_vmexit(CPUX86State *env, uint32_t exit_code, uint64_t exit_info_1,
>                   uintptr_t retaddr)
> 
> On 32-bit uintptr_t and uint64_t aren't the same thing.

Saw the same on mingw, must have forgotten to "commit --amend".

Paolo