A few VLAN-related bugfixes for RX packet abstraction

[Qemu-devel] [PATCH 0/5] A few VLAN-related bugfixes for RX packet abstraction

Posted by Dmitry Fleytman 7 years, 2 months ago

This series fix a few issues related
to processing of RX packets with VLAN headers.

See commit messages of specific patches
for information regarding affected devices.

Dmitry Fleytman (5):
  eth: Extend vlan stripping functions
  NetRxPkt: Fix memory corruption on VLAN header stripping
  NetRxPkt: Do not try to pull more data than present
  NetRxPkt: Account buffer with ETH header in IOV length
  NetRxPkt: Remove code duplication in net_rx_pkt_pull_data()

 hw/net/net_rx_pkt.c | 40 +++++++++++++++++++++-------------------
 include/net/eth.h   |  4 ++--
 net/eth.c           | 25 ++++++++++++++-----------
 3 files changed, 37 insertions(+), 32 deletions(-)

-- 
2.7.4

Re: [Qemu-devel] [PATCH 0/5] A few VLAN-related bugfixes for RX packet abstraction

Posted by Peter Maydell 7 years, 2 months ago

On 16 February 2017 at 12:29, Dmitry Fleytman <dmitry@daynix.com> wrote:
> This series fix a few issues related
> to processing of RX packets with VLAN headers.
>
> See commit messages of specific patches
> for information regarding affected devices.

I think at least the "fix buffer overrun" parts of this
patchset should be cc:stable ?

thanks
-- PMM

Re: [Qemu-devel] [PATCH 0/5] A few VLAN-related bugfixes for RX packet abstraction

Posted by Jason Wang 7 years, 2 months ago


On 2017年02月16日 20:39, Peter Maydell wrote:
> On 16 February 2017 at 12:29, Dmitry Fleytman <dmitry@daynix.com> wrote:
>> This series fix a few issues related
>> to processing of RX packets with VLAN headers.
>>
>> See commit messages of specific patches
>> for information regarding affected devices.
> I think at least the "fix buffer overrun" parts of this
> patchset should be cc:stable ?
>
> thanks
> -- PMM

Yes, I add cc:stable to patch 1 - 4.

Thanks

Re: [Qemu-devel] [PATCH 0/5] A few VLAN-related bugfixes for RX packet abstraction

Posted by Dmitry Fleytman 7 years, 2 months ago


> On 17 Feb 2017, at 5:05, Jason Wang <jasowang@redhat.com> wrote:
> 
> 
> 
>> On 2017年02月16日 20:39, Peter Maydell wrote:
>>> On 16 February 2017 at 12:29, Dmitry Fleytman <dmitry@daynix.com> wrote:
>>> This series fix a few issues related
>>> to processing of RX packets with VLAN headers.
>>> 
>>> See commit messages of specific patches
>>> for information regarding affected devices.
>> I think at least the "fix buffer overrun" parts of this
>> patchset should be cc:stable ?
>> 
>> thanks
>> -- PMM
> 
> Yes, I add cc:stable to patch 1 - 4.

Thanks, Jason!

> 
> Thanks

Re: [Qemu-devel] [PATCH 0/5] A few VLAN-related bugfixes for RX packet abstraction

Posted by Jason Wang 7 years, 2 months ago


On 2017年02月16日 20:29, Dmitry Fleytman wrote:
> This series fix a few issues related
> to processing of RX packets with VLAN headers.
>
> See commit messages of specific patches
> for information regarding affected devices.
>
> Dmitry Fleytman (5):
>    eth: Extend vlan stripping functions
>    NetRxPkt: Fix memory corruption on VLAN header stripping
>    NetRxPkt: Do not try to pull more data than present
>    NetRxPkt: Account buffer with ETH header in IOV length
>    NetRxPkt: Remove code duplication in net_rx_pkt_pull_data()
>
>   hw/net/net_rx_pkt.c | 40 +++++++++++++++++++++-------------------
>   include/net/eth.h   |  4 ++--
>   net/eth.c           | 25 ++++++++++++++-----------
>   3 files changed, 37 insertions(+), 32 deletions(-)
>

Applied. Thanks

Re: [Qemu-devel] [PATCH 0/5] A few VLAN-related bugfixes for RX packet abstraction

Posted by Peter Maydell 7 years, 1 month ago

On 17 February 2017 at 03:04, Jason Wang <jasowang@redhat.com> wrote:
>
>
> On 2017年02月16日 20:29, Dmitry Fleytman wrote:
>>
>> This series fix a few issues related
>> to processing of RX packets with VLAN headers.
>>
>> See commit messages of specific patches
>> for information regarding affected devices.
>>
>> Dmitry Fleytman (5):
>>    eth: Extend vlan stripping functions
>>    NetRxPkt: Fix memory corruption on VLAN header stripping
>>    NetRxPkt: Do not try to pull more data than present
>>    NetRxPkt: Account buffer with ETH header in IOV length
>>    NetRxPkt: Remove code duplication in net_rx_pkt_pull_data()
>>
>>   hw/net/net_rx_pkt.c | 40 +++++++++++++++++++++-------------------
>>   include/net/eth.h   |  4 ++--
>>   net/eth.c           | 25 ++++++++++++++-----------
>>   3 files changed, 37 insertions(+), 32 deletions(-)
>>
>
> Applied. Thanks

Hi Jason -- what's the status of these patches? I don't
see them in master and I don't think you have them in a pull
request yet (though I may have missed it in the deluge of
freeze-deadline pulls...)

thanks
-- PMM

Re: [Qemu-devel] [PATCH 0/5] A few VLAN-related bugfixes for RX packet abstraction

Posted by Jason Wang 7 years, 1 month ago


On 2017年03月03日 20:06, Peter Maydell wrote:
> On 17 February 2017 at 03:04, Jason Wang <jasowang@redhat.com> wrote:
>>
>> On 2017年02月16日 20:29, Dmitry Fleytman wrote:
>>> This series fix a few issues related
>>> to processing of RX packets with VLAN headers.
>>>
>>> See commit messages of specific patches
>>> for information regarding affected devices.
>>>
>>> Dmitry Fleytman (5):
>>>     eth: Extend vlan stripping functions
>>>     NetRxPkt: Fix memory corruption on VLAN header stripping
>>>     NetRxPkt: Do not try to pull more data than present
>>>     NetRxPkt: Account buffer with ETH header in IOV length
>>>     NetRxPkt: Remove code duplication in net_rx_pkt_pull_data()
>>>
>>>    hw/net/net_rx_pkt.c | 40 +++++++++++++++++++++-------------------
>>>    include/net/eth.h   |  4 ++--
>>>    net/eth.c           | 25 ++++++++++++++-----------
>>>    3 files changed, 37 insertions(+), 32 deletions(-)
>>>
>> Applied. Thanks
> Hi Jason -- what's the status of these patches? I don't
> see them in master and I don't think you have them in a pull
> request yet (though I may have missed it in the deluge of
> freeze-deadline pulls...)
>
> thanks
> -- PMM
>

Already queued but haven't sent the pull request.

Plan to send it next Monday.

Thanks