[Qemu-devel] [PATCH v2 0/3] hw: Deprecate unwanted use -drive if=scsi

Markus Armbruster posted 3 patches 7 years, 1 month ago
Patches applied successfully (tree, apply log)
git fetch https://github.com/patchew-project/qemu tags/patchew/1487161136-9018-1-git-send-email-armbru@redhat.com
Test checkpatch failed
Test docker passed
Test s390x passed
hw/arm/realview.c             |  2 +-
hw/arm/versatilepb.c          |  2 +-
hw/i386/pc.c                  |  6 +++++
hw/scsi/esp-pci.c             |  3 ---
hw/scsi/esp.c                 |  6 -----
hw/scsi/lsi53c895a.c          | 10 +++++---
hw/scsi/megasas.c             |  4 ----
hw/scsi/mptsas.c              |  4 ----
hw/scsi/scsi-bus.c            | 56 +++++++++++++++++++++++++++++++++++++------
hw/scsi/spapr_vscsi.c         |  5 ++--
hw/scsi/virtio-scsi.c         |  8 -------
include/hw/pci/pci.h          |  2 ++
include/hw/scsi/scsi.h        |  3 ++-
qemu-options.hx               |  5 ----
tests/qemu-iotests/051.pc.out | 12 ++++++----
vl.c                          | 10 ++++++++
16 files changed, 88 insertions(+), 50 deletions(-)
[Qemu-devel] [PATCH v2 0/3] hw: Deprecate unwanted use -drive if=scsi
Posted by Markus Armbruster 7 years, 1 month ago
Drives defined with if=scsi get connected to buses created with
-device, unlike other interface types.  Deprecate this usage.

There is no good default SCSI HBA for PC machines.  Deprecate if=scsi
there entirely.

Before this series, frontends for -drive if=scsi get created by SCSI
HBAs.  Frontends for other interface types get created by machine
initialization.

After this series, they get created by machine initialization, except
for deprecated cases, which get created by new function
scsi_legacy_handle_cmdline().

Based on "[PATCH v3 0/8] More sensible default for -drive interface
type".

v2:
* Trivially rebased
* PATCH 2: Suppress warning for default drives
* PATCH 3: Update user manual and qemu-iotests/051.pc.out

Markus Armbruster (3):
  hw/scsi: Concentrate -drive if=scsi auto-create in one place
  hw: Deprecate -drive if=scsi with non-onboard HBAs
  hw/i386: Deprecate -drive if=scsi with PC machine types

 hw/arm/realview.c             |  2 +-
 hw/arm/versatilepb.c          |  2 +-
 hw/i386/pc.c                  |  6 +++++
 hw/scsi/esp-pci.c             |  3 ---
 hw/scsi/esp.c                 |  6 -----
 hw/scsi/lsi53c895a.c          | 10 +++++---
 hw/scsi/megasas.c             |  4 ----
 hw/scsi/mptsas.c              |  4 ----
 hw/scsi/scsi-bus.c            | 56 +++++++++++++++++++++++++++++++++++++------
 hw/scsi/spapr_vscsi.c         |  5 ++--
 hw/scsi/virtio-scsi.c         |  8 -------
 include/hw/pci/pci.h          |  2 ++
 include/hw/scsi/scsi.h        |  3 ++-
 qemu-options.hx               |  5 ----
 tests/qemu-iotests/051.pc.out | 12 ++++++----
 vl.c                          | 10 ++++++++
 16 files changed, 88 insertions(+), 50 deletions(-)

-- 
2.7.4


Re: [Qemu-devel] [PATCH v2 0/3] hw: Deprecate unwanted use -drive if=scsi
Posted by no-reply@patchew.org 7 years, 1 month ago
Hi,

Your series seems to have some coding style problems. See output below for
more information:

Subject: [Qemu-devel] [PATCH v2 0/3] hw: Deprecate unwanted use -drive if=scsi
Message-id: 1487161136-9018-1-git-send-email-armbru@redhat.com
Type: series

=== TEST SCRIPT BEGIN ===
#!/bin/bash

BASE=base
n=1
total=$(git log --oneline $BASE.. | wc -l)
failed=0

# Useful git options
git config --local diff.renamelimit 0
git config --local diff.renames True

commits="$(git log --format=%H --reverse $BASE..)"
for c in $commits; do
    echo "Checking PATCH $n/$total: $(git log -n 1 --format=%s $c)..."
    if ! git show $c --format=email | ./scripts/checkpatch.pl --mailback -; then
        failed=1
        echo
    fi
    n=$((n+1))
done

exit $failed
=== TEST SCRIPT END ===

Updating 3c8cf5a9c21ff8782164d1def7f44bd888713384
From https://github.com/patchew-project/qemu
 * [new tag]         patchew/1487161136-9018-1-git-send-email-armbru@redhat.com -> patchew/1487161136-9018-1-git-send-email-armbru@redhat.com
Switched to a new branch 'test'
81f37e5 hw/i386: Deprecate -drive if=scsi with PC machine types
e00ebe5 hw: Deprecate -drive if=scsi with non-onboard HBAs
ab0e183 hw/scsi: Concentrate -drive if=scsi auto-create in one place

=== OUTPUT BEGIN ===
Checking PATCH 1/3: hw/scsi: Concentrate -drive if=scsi auto-create in one place...
Checking PATCH 2/3: hw: Deprecate -drive if=scsi with non-onboard HBAs...
Checking PATCH 3/3: hw/i386: Deprecate -drive if=scsi with PC machine types...
ERROR: Invalid UTF-8, patch and commit message should be encoded in UTF-8
#70: FILE: tests/qemu-iotests/051.pc.out:122:
+qququiquit
  ^

ERROR: Invalid UTF-8, patch and commit message should be encoded in UTF-8
#90: FILE: tests/qemu-iotests/051.pc.out:178:
+qququiquit
  ^

ERROR: Invalid UTF-8, patch and commit message should be encoded in UTF-8
#100: FILE: tests/qemu-iotests/051.pc.out:188:
+qququiquit
  ^

total: 3 errors, 0 warnings, 63 lines checked

Your patch has style problems, please review.  If any of these errors
are false positives report them to the maintainer, see
CHECKPATCH in MAINTAINERS.

=== OUTPUT END ===

Test command exited with code: 1


---
Email generated automatically by Patchew [http://patchew.org/].
Please send your feedback to patchew-devel@freelists.org
Re: [Qemu-devel] [PATCH v2 0/3] hw: Deprecate unwanted use -drive if=scsi
Posted by Paolo Bonzini 7 years, 1 month ago

On 15/02/2017 13:18, Markus Armbruster wrote:
> Drives defined with if=scsi get connected to buses created with
> -device, unlike other interface types.  Deprecate this usage.
> 
> There is no good default SCSI HBA for PC machines.  Deprecate if=scsi
> there entirely.
> 
> Before this series, frontends for -drive if=scsi get created by SCSI
> HBAs.  Frontends for other interface types get created by machine
> initialization.
> 
> After this series, they get created by machine initialization, except
> for deprecated cases, which get created by new function
> scsi_legacy_handle_cmdline().
> 
> Based on "[PATCH v3 0/8] More sensible default for -drive interface
> type".
> 
> v2:
> * Trivially rebased
> * PATCH 2: Suppress warning for default drives
> * PATCH 3: Update user manual and qemu-iotests/051.pc.out
> 
> Markus Armbruster (3):
>   hw/scsi: Concentrate -drive if=scsi auto-create in one place
>   hw: Deprecate -drive if=scsi with non-onboard HBAs
>   hw/i386: Deprecate -drive if=scsi with PC machine types
> 
>  hw/arm/realview.c             |  2 +-
>  hw/arm/versatilepb.c          |  2 +-
>  hw/i386/pc.c                  |  6 +++++
>  hw/scsi/esp-pci.c             |  3 ---
>  hw/scsi/esp.c                 |  6 -----
>  hw/scsi/lsi53c895a.c          | 10 +++++---
>  hw/scsi/megasas.c             |  4 ----
>  hw/scsi/mptsas.c              |  4 ----
>  hw/scsi/scsi-bus.c            | 56 +++++++++++++++++++++++++++++++++++++------
>  hw/scsi/spapr_vscsi.c         |  5 ++--
>  hw/scsi/virtio-scsi.c         |  8 -------
>  include/hw/pci/pci.h          |  2 ++
>  include/hw/scsi/scsi.h        |  3 ++-
>  qemu-options.hx               |  5 ----
>  tests/qemu-iotests/051.pc.out | 12 ++++++----
>  vl.c                          | 10 ++++++++
>  16 files changed, 88 insertions(+), 50 deletions(-)
> 

Because of the ESC characters in 051.pc.out, please send the pull
request for this yourself.

Paolo