[Qemu-devel] [PATCH 00/12] Multifd v4

Juan Quintela posted 12 patches 7 years, 1 month ago
Failed in applying to current master (apply log)
Test checkpatch passed
Test docker passed
Test s390x passed
hmp.c                         |  18 ++
include/migration/migration.h |  17 ++
migration/migration.c         |  77 ++++++-
migration/ram.c               | 499 +++++++++++++++++++++++++++++++++++++++++-
migration/socket.c            |  64 +++++-
qapi-schema.json              |  29 ++-
6 files changed, 690 insertions(+), 14 deletions(-)
[Qemu-devel] [PATCH 00/12] Multifd v4
Posted by Juan Quintela 7 years, 1 month ago
Hi

[v4]

- Address reviews
- move synchronization to semaphores (faster).  Paolo suggestion
- improvements overall (see invidiual patches)
- fix all the checkpatch warnings
- fix all [HACKS] except for one

Please review.

[v3]

This is the 3rd version of multifd. Changes:
- comments for previous verion addressed
- lots of bugs fixed
- remove DPRINTF from ram.c

- add multifd-group parameter, it gives how many pages we sent each
  time to the worker threads.  I am open to better names.
- Better flush support.
- with migration_set_speed 2G it is able to migrate "stress -vm 2
  -vm-bytes 512M" over loopback.

Please review.

Thanks, Juan.

[v2]

This is a version against current code.  It is based on top of QIO
work. It improves the thread synchronization and fixes the problem
when we could have two threads handing the same page.

Please comment, Juan.


The following changes since commit df96bfab49dab2d0373e49b51bbb51ce72e1601e:

  Merge remote-tracking branch 'remotes/kraxel/tags/pull-vga-20170213-1' into staging (2017-02-13 10:54:49 +0000)

are available in the git repository at:

  git://github.com/juanquintela/qemu.git tags/multifd/20170213

for you to fetch changes up to 733be4d2d815c6331b86364f68f6980699e9bb48:

  migration: Test new fd infrastructure (2017-02-13 18:14:06 +0100)

----------------------------------------------------------------
multifd/next for 20170213

----------------------------------------------------------------
Juan Quintela (12):
      migration: Test for disabled features on reception
      migration: Don't create decompression threads if not enabled
      migration: Add multifd capability
      migration: Create x-multifd-threads parameter
      migration: Create x-multifd-group parameter
      migration: Create multifd migration threads
      migration: Start of multiple fd work
      migration: Create ram_multifd_page
      migration: Create thread infrastructure for multifd send side
      migration: Really use multiple pages at a time
      migration: Send the fd number which we are going to use for this page
      migration: Test new fd infrastructure

 hmp.c                         |  18 ++
 include/migration/migration.h |  17 ++
 migration/migration.c         |  77 ++++++-
 migration/ram.c               | 499 +++++++++++++++++++++++++++++++++++++++++-
 migration/socket.c            |  64 +++++-
 qapi-schema.json              |  29 ++-
 6 files changed, 690 insertions(+), 14 deletions(-)

Re: [Qemu-devel] [PATCH 00/12] Multifd v4
Posted by Peter Maydell 7 years, 1 month ago
On 13 February 2017 at 17:19, Juan Quintela <quintela@redhat.com> wrote:
> Hi
>
> [v4]
>
> - Address reviews
> - move synchronization to semaphores (faster).  Paolo suggestion
> - improvements overall (see invidiual patches)
> - fix all the checkpatch warnings
> - fix all [HACKS] except for one
> Please review.


Is this a patch series or a pull request? The subject line
says "PATCH" and the body says 'please review' but it's in
the form of a pull request email...

thanks
-- PMM

Re: [Qemu-devel] [PATCH 00/12] Multifd v4
Posted by Paolo Bonzini 7 years, 1 month ago

On 13/02/2017 18:19, Juan Quintela wrote:
> [v4]
> 
> - Address reviews
> - move synchronization to semaphores (faster).  Paolo suggestion
> - improvements overall (see invidiual patches)
> - fix all the checkpatch warnings
> - fix all [HACKS] except for one
> 
> Please review.

I think you can simplify the receive threads much more.  I left comments
on patch 11.

Paolo