Second version, had to remove a long web link (over 90 chars).


Juro Bystricky (1):
  nios2: Add Altera JTAG UART emulation

 default-configs/nios2-softmmu.mak |   1 +
 hw/char/Makefile.objs             |   1 +
 hw/char/altera_juart.c            | 265 ++++++++++++++++++++++++++++++++++++++
 include/hw/char/altera_juart.h    |  44 +++++++
 4 files changed, 311 insertions(+)
 create mode 100644 hw/char/altera_juart.c
 create mode 100644 include/hw/char/altera_juart.h

-- 
2.7.4

On 8 February 2017 at 21:43, Juro Bystricky <juro.bystricky@intel.com> wrote:
> Second version, had to remove a long web link (over 90 chars).

Can we have the version with the URL, please?
Checkpatch isn't infallible, and usually its errors
are more of a "look at this and see if it's fixable"
than an unwaivable requirement.

In this case the URL is clearly useful information
for future readers and it can't be folded, so
the over-long line is fine.

thanks
-- PMM

no problem, just sent in a patch v3.
I found a shorter link, so it should keep
checkaptch happy as well.



> -----Original Message-----
> From: Peter Maydell [mailto:peter.maydell@linaro.org]
> Sent: Wednesday, February 8, 2017 3:00 PM
> To: Bystricky, Juro <juro.bystricky@intel.com>
> Cc: QEMU Developers <qemu-devel@nongnu.org>; Marek Vasut <marex@denx.de>;
> jurobystricky@hotmail.com; Chris Wulff <crwulff@gmail.com>
> Subject: Re: [Qemu-devel] [PATCH v2 0/1] Nios2: Altera JATAG UART
> 
> On 8 February 2017 at 21:43, Juro Bystricky <juro.bystricky@intel.com>
> wrote:
> > Second version, had to remove a long web link (over 90 chars).
> 
> Can we have the version with the URL, please?
> Checkpatch isn't infallible, and usually its errors
> are more of a "look at this and see if it's fixable"
> than an unwaivable requirement.
> 
> In this case the URL is clearly useful information
> for future readers and it can't be folded, so
> the over-long line is fine.
> 
> thanks
> -- PMM