From nobody Fri May 3 05:32:15 2024 Delivered-To: importer@patchew.org Received-SPF: pass (zoho.com: domain of gnu.org designates 208.118.235.17 as permitted sender) client-ip=208.118.235.17; envelope-from=qemu-devel-bounces+importer=patchew.org@nongnu.org; helo=lists.gnu.org; Authentication-Results: mx.zoho.com; spf=pass (zoho.com: domain of gnu.org designates 208.118.235.17 as permitted sender) smtp.mailfrom=qemu-devel-bounces+importer=patchew.org@nongnu.org; Return-Path: Received: from lists.gnu.org (lists.gnu.org [208.118.235.17]) by mx.zohomail.com with SMTPS id 1486576744993791.6401069567992; Wed, 8 Feb 2017 09:59:04 -0800 (PST) Received: from localhost ([::1]:60768 helo=lists.gnu.org) by lists.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1cbWWE-0002NA-EE for importer@patchew.org; Wed, 08 Feb 2017 12:59:02 -0500 Received: from eggs.gnu.org ([2001:4830:134:3::10]:51659) by lists.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1cbWVH-0001rW-2Z for qemu-devel@nongnu.org; Wed, 08 Feb 2017 12:58:03 -0500 Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71) (envelope-from ) id 1cbWVE-00048t-12 for qemu-devel@nongnu.org; Wed, 08 Feb 2017 12:58:03 -0500 Received: from mx1.redhat.com ([209.132.183.28]:46358) by eggs.gnu.org with esmtps (TLS1.0:DHE_RSA_AES_256_CBC_SHA1:32) (Exim 4.71) (envelope-from ) id 1cbWUv-0003xj-Fm; Wed, 08 Feb 2017 12:57:59 -0500 Received: from int-mx14.intmail.prod.int.phx2.redhat.com (int-mx14.intmail.prod.int.phx2.redhat.com [10.5.11.27]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by mx1.redhat.com (Postfix) with ESMTPS id 62D23636FE; Wed, 8 Feb 2017 17:57:41 +0000 (UTC) Received: from thh440s.redhat.com (ovpn-116-87.ams2.redhat.com [10.36.116.87]) by int-mx14.intmail.prod.int.phx2.redhat.com (8.14.4/8.14.4) with ESMTP id v18HvdOi016898; Wed, 8 Feb 2017 12:57:39 -0500 From: Thomas Huth To: Alistair Francis , qemu-devel@nongnu.org Date: Wed, 8 Feb 2017 18:57:38 +0100 Message-Id: <1486576658-29719-1-git-send-email-thuth@redhat.com> X-Scanned-By: MIMEDefang 2.68 on 10.5.11.27 X-Greylist: Sender IP whitelisted, not delayed by milter-greylist-4.5.16 (mx1.redhat.com [10.5.110.39]); Wed, 08 Feb 2017 17:57:41 +0000 (UTC) X-detected-operating-system: by eggs.gnu.org: GNU/Linux 2.2.x-3.x [generic] [fuzzy] X-Received-From: 209.132.183.28 Subject: [Qemu-devel] [PATCH v3] hw/core/register: Mark the device with cannot_instantiate_with_device_add_yet X-BeenThere: qemu-devel@nongnu.org X-Mailman-Version: 2.1.21 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Cc: qemu-trivial@nongnu.org, Markus Armbruster Errors-To: qemu-devel-bounces+importer=patchew.org@nongnu.org Sender: "Qemu-devel" X-ZohoMail: RSF_0 Z_629925259 SPT_0 Content-Transfer-Encoding: quoted-printable MIME-Version: 1.0 Content-Type: text/plain; charset="utf-8" The "qemu,register" device needs to be wired up in source code, there is no way the user can make any real use of this device with the "-device" parameter or the "device_add" monitor command yet. Signed-off-by: Thomas Huth --- v3: Another update to the patch description and comment hw/core/register.c | 9 +++++++++ 1 file changed, 9 insertions(+) diff --git a/hw/core/register.c b/hw/core/register.c index 4bfbc50..be170dc 100644 --- a/hw/core/register.c +++ b/hw/core/register.c @@ -274,9 +274,18 @@ void register_finalize_block(RegisterInfoArray *r_arra= y) g_free(r_array); } =20 +static void register_class_init(ObjectClass *oc, void *data) +{ + DeviceClass *dc =3D DEVICE_CLASS(oc); + + /* Reason: needs to be wired up to work */ + dc->cannot_instantiate_with_device_add_yet =3D true; +} + static const TypeInfo register_info =3D { .name =3D TYPE_REGISTER, .parent =3D TYPE_DEVICE, + .class_init =3D register_class_init, }; =20 static void register_register_types(void) --=20 1.8.3.1