[PATCH] [PATCH v2 net-next] mptcp: fix typos in comments

Shi-Sheng Yang posted 1 patch 2 weeks, 3 days ago
Patches applied successfully (tree, apply log)
git fetch https://github.com/multipath-tcp/mptcp_net-next tags/patchew/20240502154740.249839-1-fourcolor4c@gmail.com
net/mptcp/subflow.c | 4 ++--
1 file changed, 2 insertions(+), 2 deletions(-)
[PATCH] [PATCH v2 net-next] mptcp: fix typos in comments
Posted by Shi-Sheng Yang 2 weeks, 3 days ago
This patch fixes the spelling mistakes in comments.
The changes were generated using codespell and reviewed manually.

eariler -> earlier
greceful -> graceful

Signed-off-by: Shi-Sheng Yang <fourcolor4c@gmail.com>
---
 net/mptcp/subflow.c | 4 ++--
 1 file changed, 2 insertions(+), 2 deletions(-)

diff --git a/net/mptcp/subflow.c b/net/mptcp/subflow.c
index 97ec44d1df30..0ac8d4850751 100644
--- a/net/mptcp/subflow.c
+++ b/net/mptcp/subflow.c
@@ -911,7 +911,7 @@ static struct sock *subflow_syn_recv_sock(const struct sock *sk,
 	}
 
 	/* check for expected invariant - should never trigger, just help
-	 * catching eariler subtle bugs
+	 * catching earlier subtle bugs
 	 */
 	WARN_ON_ONCE(child && *own_req && tcp_sk(child)->is_mptcp &&
 		     (!mptcp_subflow_ctx(child) ||
@@ -1259,7 +1259,7 @@ static void mptcp_subflow_fail(struct mptcp_sock *msk, struct sock *ssk)
 	struct mptcp_subflow_context *subflow = mptcp_subflow_ctx(ssk);
 	unsigned long fail_tout;
 
-	/* greceful failure can happen only on the MPC subflow */
+	/* graceful failure can happen only on the MPC subflow */
 	if (WARN_ON_ONCE(ssk != READ_ONCE(msk->first)))
 		return;
 
-- 
2.34.1
Re: [PATCH] [PATCH v2 net-next] mptcp: fix typos in comments
Posted by Matthieu Baerts 1 week, 6 days ago
Hi Shi-Sheng,

On 02/05/2024 17:47, Shi-Sheng Yang wrote:
> This patch fixes the spelling mistakes in comments.
> The changes were generated using codespell and reviewed manually.
> 
> eariler -> earlier
> greceful -> graceful

Thank you for the fix, it looks good to me:

Reviewed-by: Matthieu Baerts (NGI0) <matttbe@kernel.org>

@Simon: many thanks for the previous review!

@Netdev maintainers: I think it is best to apply this patch -- and
similar ones -- directly in the Netdev tree, no need to have it first in
the MPTCP tree.

Cheers,
Matt
-- 
Sponsored by the NGI0 Core fund.
Re: [PATCH] [PATCH v2 net-next] mptcp: fix typos in comments
Posted by Simon Horman 2 weeks, 1 day ago
On Thu, May 02, 2024 at 11:47:40PM +0800, Shi-Sheng Yang wrote:
> This patch fixes the spelling mistakes in comments.
> The changes were generated using codespell and reviewed manually.
> 
> eariler -> earlier
> greceful -> graceful
> 
> Signed-off-by: Shi-Sheng Yang <fourcolor4c@gmail.com>

Reviewed-by: Simon Horman <horms@kernel.org>
Re: [PATCH] [PATCH v2 net-next] mptcp: fix typos in comments
Posted by MPTCP CI 2 weeks, 3 days ago
Hi Shi-Sheng,

Thank you for your modifications, that's great!

Our CI did some validations and here is its report:

- KVM Validation: normal: Success! ✅
- KVM Validation: debug: Success! ✅
- KVM Validation: btf (only bpftest_all): Success! ✅
- Task: https://github.com/multipath-tcp/mptcp_net-next/actions/runs/8926914986

Initiator: Patchew Applier
Commits: https://github.com/multipath-tcp/mptcp_net-next/commits/a9a443be8da7
Patchwork: https://patchwork.kernel.org/project/mptcp/list/?series=849948


If there are some issues, you can reproduce them using the same environment as
the one used by the CI thanks to a docker image, e.g.:

    $ cd [kernel source code]
    $ docker run -v "${PWD}:${PWD}:rw" -w "${PWD}" --privileged --rm -it \
        --pull always mptcp/mptcp-upstream-virtme-docker:latest \
        auto-normal

For more details:

    https://github.com/multipath-tcp/mptcp-upstream-virtme-docker


Please note that despite all the efforts that have been already done to have a
stable tests suite when executed on a public CI like here, it is possible some
reported issues are not due to your modifications. Still, do not hesitate to
help us improve that ;-)

Cheers,
MPTCP GH Action bot
Bot operated by Matthieu Baerts (NGI0 Core)