mptcp: Spring cleaning

[PATCH mptcp-next 0/4] mptcp: Spring cleaning

Posted by Matthieu Baerts (NGI0) 2 weeks, 3 days ago

This series fixes some warnings reported by CheckPatch and CLang.

The behaviour is not supposed to be modified, just some simple fixes.

Signed-off-by: Matthieu Baerts (NGI0) <matttbe@kernel.org>
---
Matthieu Baerts (NGI0) (4):
      mptcp: prefer strscpy over strcpy
      mptcp: move mptcp_pm_gen.h's include
      mptcp: remove unnecessary else statements
      mptcp: include inet_common in mib.h

 net/mptcp/ctrl.c         |  2 +-
 net/mptcp/mib.h          |  2 ++
 net/mptcp/pm_netlink.c   |  1 +
 net/mptcp/pm_userspace.c |  1 +
 net/mptcp/protocol.c     |  5 +++--
 net/mptcp/protocol.h     |  2 --
 net/mptcp/sockopt.c      |  2 +-
 net/mptcp/subflow.c      | 32 +++++++++++++++++---------------
 8 files changed, 26 insertions(+), 21 deletions(-)
---
base-commit: c3c3514169a8e548fba51d0694b86a72f89acce0
change-id: 20240502-mptcp-cleanup-clang-checkpatch-8eb4a4843ff6

Best regards,
-- 
Matthieu Baerts (NGI0) <matttbe@kernel.org>

Re: [PATCH mptcp-next 0/4] mptcp: Spring cleaning

Posted by Geliang Tang 2 weeks ago

Hi Matt,

On Thu, May 02, 2024 at 07:23:03PM +0200, Matthieu Baerts (NGI0) wrote:
> This series fixes some warnings reported by CheckPatch and CLang.
> 
> The behaviour is not supposed to be modified, just some simple fixes.
> 
> Signed-off-by: Matthieu Baerts (NGI0) <matttbe@kernel.org>

This series looks good to me, thanks.

Reviewed-by: Geliang Tang <geliang@kernel.org>

-Geliang

> ---
> Matthieu Baerts (NGI0) (4):
>       mptcp: prefer strscpy over strcpy
>       mptcp: move mptcp_pm_gen.h's include
>       mptcp: remove unnecessary else statements
>       mptcp: include inet_common in mib.h
> 
>  net/mptcp/ctrl.c         |  2 +-
>  net/mptcp/mib.h          |  2 ++
>  net/mptcp/pm_netlink.c   |  1 +
>  net/mptcp/pm_userspace.c |  1 +
>  net/mptcp/protocol.c     |  5 +++--
>  net/mptcp/protocol.h     |  2 --
>  net/mptcp/sockopt.c      |  2 +-
>  net/mptcp/subflow.c      | 32 +++++++++++++++++---------------
>  8 files changed, 26 insertions(+), 21 deletions(-)
> ---
> base-commit: c3c3514169a8e548fba51d0694b86a72f89acce0
> change-id: 20240502-mptcp-cleanup-clang-checkpatch-8eb4a4843ff6
> 
> Best regards,
> -- 
> Matthieu Baerts (NGI0) <matttbe@kernel.org>
>

Re: [PATCH mptcp-next 0/4] mptcp: Spring cleaning

Posted by Matthieu Baerts 1 week, 6 days ago

Hi Geliang,

On 05/05/2024 02:09, Geliang Tang wrote:
> Hi Matt,
> 
> On Thu, May 02, 2024 at 07:23:03PM +0200, Matthieu Baerts (NGI0) wrote:
>> This series fixes some warnings reported by CheckPatch and CLang.
>>
>> The behaviour is not supposed to be modified, just some simple fixes.
>>
>> Signed-off-by: Matthieu Baerts (NGI0) <matttbe@kernel.org>
> 
> This series looks good to me, thanks.
> 
> Reviewed-by: Geliang Tang <geliang@kernel.org>

Thank you for the reviews!

Now in our tree:

New patches for t/upstream:
- 30bcdc95bba9: mptcp: prefer strscpy over strcpy
- a34ad3c16bea: mptcp: move mptcp_pm_gen.h's include
- ee96a2272093: mptcp: remove unnecessary else statements
- 1122ef798833: mptcp: include inet_common in mib.h
- Results: 553805a44319..77024827f43c (export)

Tests are now in progress:

- export:
https://github.com/multipath-tcp/mptcp_net-next/commit/0c710353718af7825e121b25983bc352ccc64024/checks

Cheers,
Matt
-- 
Sponsored by the NGI0 Core fund.