build: Don't install sysconfig files as scripts

[libvirt] [PATCH] build: Don't install sysconfig files as scripts

Jiri Denemark posted 1 patch 5 years, 10 months ago

Download mbox

Patches applied successfully (tree, apply log)
git fetch https://github.com/patchew-project/libvirt tags/patchew/ff26ebe068da171783a376a7af5a67601e45bca7.1528147457.git.jdenemar@redhat.com

Test syntax-check passed

src/Makefile.am | 2 +-
1 file changed, 1 insertion(+), 1 deletion(-)

Expand all Fold all

[libvirt] [PATCH] build: Don't install sysconfig files as scripts

Posted by Jiri Denemark 5 years, 10 months ago

The files are not scripts and should not be executable.

Broken by v4.0.0-294-g5f998681df.

Signed-off-by: Jiri Denemark <jdenemar@redhat.com>
---
 src/Makefile.am | 2 +-
 1 file changed, 1 insertion(+), 1 deletion(-)

diff --git a/src/Makefile.am b/src/Makefile.am
index 0c380780c3..b2db1e9db9 100644
--- a/src/Makefile.am
+++ b/src/Makefile.am
@@ -768,7 +768,7 @@ install-sysconfig:
 	for f in $(SYSCONF_FILES:%.sysconf=%) ; \
 	do \
 	  tgt=`basename $$f`; \
-	  $(INSTALL_SCRIPT) $(srcdir)/$$f.sysconf \
+	  $(INSTALL_DATA) $(srcdir)/$$f.sysconf \
 	      $(DESTDIR)$(sysconfdir)/sysconfig/$$tgt; \
 	done
 
-- 
2.17.1

--
libvir-list mailing list
libvir-list@redhat.com
https://www.redhat.com/mailman/listinfo/libvir-list

Re: [libvirt] [PATCH] build: Don't install sysconfig files as scripts

Posted by Peter Krempa 5 years, 10 months ago

On Mon, Jun 04, 2018 at 23:24:17 +0200, Jiri Denemark wrote:
> The files are not scripts and should not be executable.
> 
> Broken by v4.0.0-294-g5f998681df.
> 
> Signed-off-by: Jiri Denemark <jdenemar@redhat.com>
> ---
>  src/Makefile.am | 2 +-
>  1 file changed, 1 insertion(+), 1 deletion(-)

ACK
--
libvir-list mailing list
libvir-list@redhat.com
https://www.redhat.com/mailman/listinfo/libvir-list