From nobody Wed May 15 15:34:45 2024 Delivered-To: importer@patchew.org Received-SPF: pass (zohomail.com: domain of redhat.com designates 170.10.133.124 as permitted sender) client-ip=170.10.133.124; envelope-from=libvir-list-bounces@redhat.com; helo=us-smtp-delivery-124.mimecast.com; Authentication-Results: mx.zohomail.com; dkim=pass; spf=pass (zohomail.com: domain of redhat.com designates 170.10.133.124 as permitted sender) smtp.mailfrom=libvir-list-bounces@redhat.com; dmarc=pass(p=none dis=none) header.from=redhat.com ARC-Seal: i=1; a=rsa-sha256; t=1645099000; cv=none; d=zohomail.com; s=zohoarc; b=m8EHkmMWUMpXVkPkUZHQ/tozFMYyvVuXhpXzLOtarvd0cW5jiJgO9r3NHCHFQEhDxrIIQ86YpnABuzh+TbIzubCeqF9T4dihiwoD9KHkzGqe1Uw8u7Q7OtgXh3ZuHz0zVqd8kWRs+1RUW8zUuAuZO2l6BGG9Kpr53LjR8EhPjS8= ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=zohomail.com; s=zohoarc; t=1645099000; h=Content-Type:Content-Transfer-Encoding:Date:From:List-Subscribe:List-Post:List-Id:List-Archive:List-Help:List-Unsubscribe:MIME-Version:Message-ID:Sender:Subject:To; bh=yi3VdGb3fPp407XEtjh9rTHPyGjgpujdILIkABjb9no=; b=jNLH6KAFVyNjaU1cwrlrhiy2p6dhRI+mUNtIBP/PA6lXw4f8DU6RmXJUowYgi7ixASMjDjQUrQUh/7ojMcTPY6dFYCur0+SHXINCSf/KUt39CXwy2h/44d7rr4Kyi8NWc7BU24XEWnI9WhDzIB/MowNu5+4NAZU5+0l5o0nKyyY= ARC-Authentication-Results: i=1; mx.zohomail.com; dkim=pass; spf=pass (zohomail.com: domain of redhat.com designates 170.10.133.124 as permitted sender) smtp.mailfrom=libvir-list-bounces@redhat.com; dmarc=pass header.from= (p=none dis=none) Return-Path: Received: from us-smtp-delivery-124.mimecast.com (us-smtp-delivery-124.mimecast.com [170.10.133.124]) by mx.zohomail.com with SMTPS id 1645099000485672.5436279696163; Thu, 17 Feb 2022 03:56:40 -0800 (PST) Received: from mimecast-mx01.redhat.com (mimecast-mx01.redhat.com [209.132.183.4]) by relay.mimecast.com with ESMTP with STARTTLS (version=TLSv1.2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id us-mta-250-tX6xIfPKNLuzwJwylpa6EQ-1; Thu, 17 Feb 2022 06:56:37 -0500 Received: from smtp.corp.redhat.com (int-mx05.intmail.prod.int.phx2.redhat.com [10.5.11.15]) (using TLSv1.2 with cipher AECDH-AES256-SHA (256/256 bits)) (No client certificate requested) by mimecast-mx01.redhat.com (Postfix) with ESMTPS id 1787F1091DA1; Thu, 17 Feb 2022 11:56:33 +0000 (UTC) Received: from colo-mx.corp.redhat.com (colo-mx01.intmail.prod.int.phx2.redhat.com [10.5.11.20]) by smtp.corp.redhat.com (Postfix) with ESMTPS id EDA3A6F125; Thu, 17 Feb 2022 11:56:32 +0000 (UTC) Received: from lists01.pubmisc.prod.ext.phx2.redhat.com (lists01.pubmisc.prod.ext.phx2.redhat.com [10.5.19.33]) by colo-mx.corp.redhat.com (Postfix) with ESMTP id BFA081809CAB; Thu, 17 Feb 2022 11:56:32 +0000 (UTC) Received: from smtp.corp.redhat.com (int-mx04.intmail.prod.int.phx2.redhat.com [10.5.11.14]) by lists01.pubmisc.prod.ext.phx2.redhat.com (8.13.8/8.13.8) with ESMTP id 21HBuWI8026276 for ; Thu, 17 Feb 2022 06:56:32 -0500 Received: by smtp.corp.redhat.com (Postfix) id 133756FAE8; Thu, 17 Feb 2022 11:56:32 +0000 (UTC) Received: from maggie.redhat.com (unknown [10.43.2.56]) by smtp.corp.redhat.com (Postfix) with ESMTP id 925536FAE6 for ; Thu, 17 Feb 2022 11:56:31 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=redhat.com; s=mimecast20190719; t=1645098999; h=from:from:sender:sender:reply-to:subject:subject:date:date: message-id:message-id:to:to:cc:mime-version:mime-version: content-type:content-type: content-transfer-encoding:content-transfer-encoding:list-id:list-help: list-unsubscribe:list-subscribe:list-post; bh=yi3VdGb3fPp407XEtjh9rTHPyGjgpujdILIkABjb9no=; b=X0BOz1A0qIlmkMHU7a1gyyoSzZ+b2zvd/4hFt+MyA7TRRMPV7ilaOL9+qEOGseXqixD8K0 9Ac/cFMtSva6HmxXzSg35a+SFNgI4PjGqrkb4YXHlahzFp7u5EpwL/1KSuv7gxJQYr1hB4 RBigz5FA+y6EabsHLctF2efSnekhbBE= X-MC-Unique: tX6xIfPKNLuzwJwylpa6EQ-1 From: Michal Privoznik To: libvir-list@redhat.com Subject: [PATCH] libxl: Turn on user aliases Date: Thu, 17 Feb 2022 12:56:29 +0100 Message-Id: MIME-Version: 1.0 X-Scanned-By: MIMEDefang 2.79 on 10.5.11.14 X-loop: libvir-list@redhat.com X-BeenThere: libvir-list@redhat.com X-Mailman-Version: 2.1.12 Precedence: junk List-Id: Development discussions about the libvirt library & tools List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Sender: libvir-list-bounces@redhat.com Errors-To: libvir-list-bounces@redhat.com X-Scanned-By: MIMEDefang 2.79 on 10.5.11.15 Authentication-Results: relay.mimecast.com; auth=pass smtp.auth=CUSA124A263 smtp.mailfrom=libvir-list-bounces@redhat.com X-Mimecast-Spam-Score: 0 X-Mimecast-Originator: redhat.com Content-Transfer-Encoding: quoted-printable X-ZohoMail-DKIM: pass (identity @redhat.com) X-ZM-MESSAGEID: 1645099001704100001 Content-Type: text/plain; charset="utf-8" When I implemented user aliases I've invented this virDomainDefFeatures flag so that individual drivers can signal support for user provided aliases. The reasoning was that a device alias might be part of guest ABI, or used in a different way then in QEMU. Well, neither applies to the libxl driver, so it's safe to allow user aliases there. Resolves: https://gitlab.com/libvirt/libvirt/-/issues/231 Signed-off-by: Michal Privoznik Reviewed-by: Jim Fehlig --- src/libxl/libxl_domain.c | 3 ++- 1 file changed, 2 insertions(+), 1 deletion(-) diff --git a/src/libxl/libxl_domain.c b/src/libxl/libxl_domain.c index c91e531a9a..0816c5baa4 100644 --- a/src/libxl/libxl_domain.c +++ b/src/libxl/libxl_domain.c @@ -452,7 +452,8 @@ virDomainDefParserConfig libxlDomainDefParserConfig =3D= { .domainPostParseCallback =3D libxlDomainDefPostParse, .domainValidateCallback =3D libxlDomainDefValidate, =20 - .features =3D VIR_DOMAIN_DEF_FEATURE_FW_AUTOSELECT | + .features =3D VIR_DOMAIN_DEF_FEATURE_USER_ALIAS | + VIR_DOMAIN_DEF_FEATURE_FW_AUTOSELECT | VIR_DOMAIN_DEF_FEATURE_NET_MODEL_STRING, }; =20 --=20 2.34.1