qemuProcessStop: Don't try to remove QoS on already removed TAP

[PATCH] qemuProcessStop: Don't try to remove QoS on already removed TAP

Michal Privoznik posted 1 patch 2 years, 3 months ago

Download mbox

Patches applied successfully (tree, apply log)
git fetch https://github.com/patchew-project/libvirt tags/patchew/fc43ed9e3fed011a9ecc3442b661d09b163b6e48.1653663944.git.mprivozn@redhat.com

src/qemu/qemu_process.c | 6 ------
1 file changed, 6 deletions(-)

Expand all Fold all

[PATCH] qemuProcessStop: Don't try to remove QoS on already removed TAP

Posted by Michal Privoznik 2 years, 3 months ago

When cleaning up after stopped domain, one of the things we do is
attempt to clear QoS settings on OVS type interfaces. Well, this
is needless because they were removed just a couple of lines
above. As a result, the attempt fails and a warning is printed
into logs, polluting them needlessly.

Closes: https://gitlab.com/libvirt/libvirt/-/issues/313
Signed-off-by: Michal Privoznik <mprivozn@redhat.com>
---
 src/qemu/qemu_process.c | 6 ------
 1 file changed, 6 deletions(-)

diff --git a/src/qemu/qemu_process.c b/src/qemu/qemu_process.c
index 07acb1c427..c6d965d720 100644
--- a/src/qemu/qemu_process.c
+++ b/src/qemu/qemu_process.c
@@ -8166,12 +8166,6 @@ void qemuProcessStop(virQEMUDriver *driver,
             else
                 VIR_WARN("Unable to release network device '%s'", NULLSTR(net->ifname));
         }
-
-        if (virDomainNetDefIsOvsport(net) &&
-            virNetDevOpenvswitchInterfaceClearQos(net->ifname, vm->def->uuid) < 0) {
-            VIR_WARN("cannot clear bandwidth setting for ovs device : %s",
-                     net->ifname);
-        }
     }
 
  retry:
-- 
2.35.1

Re: [PATCH] qemuProcessStop: Don't try to remove QoS on already removed TAP

Posted by Ján Tomko 2 years, 3 months ago

On a Friday in 2022, Michal Privoznik wrote:
>When cleaning up after stopped domain, one of the things we do is
>attempt to clear QoS settings on OVS type interfaces. Well, this
>is needless because they were removed just a couple of lines
>above. As a result, the attempt fails and a warning is printed
>into logs, polluting them needlessly.
>
>Closes: https://gitlab.com/libvirt/libvirt/-/issues/313
>Signed-off-by: Michal Privoznik <mprivozn@redhat.com>
>---
> src/qemu/qemu_process.c | 6 ------
> 1 file changed, 6 deletions(-)
>

Reviewed-by: Ján Tomko <jtomko@redhat.com>

Jano