Enable forgotten VIR_CONNECT_LIST_STORAGE_POOLS_* flags

[libvirt] [PATCH] Enable forgotten VIR_CONNECT_LIST_STORAGE_POOLS_* flags

Posted by Jiri Denemark 7 years, 1 month ago

VIR_CONNECT_LIST_STORAGE_POOLS_VSTORAGE and
VIR_CONNECT_LIST_STORAGE_POOLS_ZFS were added to libvirt but the listing
API was not properly updated to use them.

https://bugzilla.redhat.com/show_bug.cgi?id=1431543

Signed-off-by: Jiri Denemark <jdenemar@redhat.com>
---
 src/conf/storage_conf.c | 6 +++++-
 src/conf/storage_conf.h | 3 ++-
 2 files changed, 7 insertions(+), 2 deletions(-)

diff --git a/src/conf/storage_conf.c b/src/conf/storage_conf.c
index a52eeba07..3cfaf2b9b 100644
--- a/src/conf/storage_conf.c
+++ b/src/conf/storage_conf.c
@@ -2671,7 +2671,11 @@ virStoragePoolMatch(virStoragePoolObjPtr poolobj,
               (MATCH(VIR_CONNECT_LIST_STORAGE_POOLS_SHEEPDOG) &&
                (poolobj->def->type == VIR_STORAGE_POOL_SHEEPDOG)) ||
               (MATCH(VIR_CONNECT_LIST_STORAGE_POOLS_GLUSTER) &&
-               (poolobj->def->type == VIR_STORAGE_POOL_GLUSTER))))
+               (poolobj->def->type == VIR_STORAGE_POOL_GLUSTER)) ||
+              (MATCH(VIR_CONNECT_LIST_STORAGE_POOLS_ZFS) &&
+               poolobj->def->type == VIR_STORAGE_POOL_ZFS)       ||
+              (MATCH(VIR_CONNECT_LIST_STORAGE_POOLS_VSTORAGE) &&
+               poolobj->def->type == VIR_STORAGE_POOL_VSTORAGE)))
             return false;
     }
 
diff --git a/src/conf/storage_conf.h b/src/conf/storage_conf.h
index 1723afc0a..c3a88d284 100644
--- a/src/conf/storage_conf.h
+++ b/src/conf/storage_conf.h
@@ -544,7 +544,8 @@ VIR_ENUM_DECL(virStoragePartedFs)
                  VIR_CONNECT_LIST_STORAGE_POOLS_RBD      | \
                  VIR_CONNECT_LIST_STORAGE_POOLS_SHEEPDOG | \
                  VIR_CONNECT_LIST_STORAGE_POOLS_GLUSTER  | \
-                 VIR_CONNECT_LIST_STORAGE_POOLS_ZFS)
+                 VIR_CONNECT_LIST_STORAGE_POOLS_ZFS      | \
+                 VIR_CONNECT_LIST_STORAGE_POOLS_VSTORAGE)
 
 # define VIR_CONNECT_LIST_STORAGE_POOLS_FILTERS_ALL                  \
                 (VIR_CONNECT_LIST_STORAGE_POOLS_FILTERS_ACTIVE     | \
-- 
2.12.0

--
libvir-list mailing list
libvir-list@redhat.com
https://www.redhat.com/mailman/listinfo/libvir-list

Re: [libvirt] [PATCH] Enable forgotten VIR_CONNECT_LIST_STORAGE_POOLS_* flags

Posted by Peter Krempa 7 years, 1 month ago

On Mon, Mar 13, 2017 at 09:31:41 +0100, Jiri Denemark wrote:
> VIR_CONNECT_LIST_STORAGE_POOLS_VSTORAGE and
> VIR_CONNECT_LIST_STORAGE_POOLS_ZFS were added to libvirt but the listing
> API was not properly updated to use them.
> 
> https://bugzilla.redhat.com/show_bug.cgi?id=1431543
> 
> Signed-off-by: Jiri Denemark <jdenemar@redhat.com>
> ---
>  src/conf/storage_conf.c | 6 +++++-
>  src/conf/storage_conf.h | 3 ++-
>  2 files changed, 7 insertions(+), 2 deletions(-)

ACK
--
libvir-list mailing list
libvir-list@redhat.com
https://www.redhat.com/mailman/listinfo/libvir-list