From nobody Thu May 16 03:03:47 2024 Delivered-To: importer@patchew.org Received-SPF: pass (zohomail.com: domain of redhat.com designates 216.205.24.124 as permitted sender) client-ip=216.205.24.124; envelope-from=libvir-list-bounces@redhat.com; helo=us-smtp-delivery-124.mimecast.com; Authentication-Results: mx.zohomail.com; dkim=pass; spf=pass (zohomail.com: domain of redhat.com designates 216.205.24.124 as permitted sender) smtp.mailfrom=libvir-list-bounces@redhat.com; dmarc=pass(p=none dis=none) header.from=redhat.com ARC-Seal: i=1; a=rsa-sha256; t=1621336083; cv=none; d=zohomail.com; s=zohoarc; b=J69EgHmGr5B5pSq9R9ZprPDBFWOO4NIPV8A66ZHooTR/MTL8gvuWGdHiLRnMjXUvhkDY3gtL/KIyIAknizEQawB7R8ri1s6ko5yOg/t1FAIF+aVgrACJmM1eMHEajllIefyidzRe/h7E2ZHTkMEa0Mfo/GAe7GUyz9msv96zSGg= ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=zohomail.com; s=zohoarc; t=1621336083; h=Content-Type:Content-Transfer-Encoding:Date:From:List-Subscribe:List-Post:List-Id:List-Archive:List-Help:List-Unsubscribe:MIME-Version:Message-ID:Sender:Subject:To; bh=q+iru5t3JWfCi2SqQhaCrb1MMAejFqX6n+Q75fwK440=; b=hmpB3jm3qOWxHg7sYDgpIildx25i0Q1k/yKGTN2uEBv4bY4uC/cSuz7+rEd+Y5A4Bv+VaX4jskIeBSXQvWCuSARi1TpJC5LapOrAKuaohzYmPnj0fCSCRv1lRksgphinPjWq469g5rOrLuHr2ZB5zgaCCV88mlFbMqLfAqNQLys= ARC-Authentication-Results: i=1; mx.zohomail.com; dkim=pass; spf=pass (zohomail.com: domain of redhat.com designates 216.205.24.124 as permitted sender) smtp.mailfrom=libvir-list-bounces@redhat.com; dmarc=pass header.from= (p=none dis=none) header.from= Return-Path: Received: from us-smtp-delivery-124.mimecast.com (us-smtp-delivery-124.mimecast.com [216.205.24.124]) by mx.zohomail.com with SMTPS id 1621336083455973.4585915248829; Tue, 18 May 2021 04:08:03 -0700 (PDT) Received: from mimecast-mx01.redhat.com (mimecast-mx01.redhat.com [209.132.183.4]) (Using TLS) by relay.mimecast.com with ESMTP id us-mta-263-IiBP2EG3N2GCL4DloF19QA-1; Tue, 18 May 2021 07:07:59 -0400 Received: from smtp.corp.redhat.com (int-mx04.intmail.prod.int.phx2.redhat.com [10.5.11.14]) (using TLSv1.2 with cipher AECDH-AES256-SHA (256/256 bits)) (No client certificate requested) by mimecast-mx01.redhat.com (Postfix) with ESMTPS id 78BD01019632; Tue, 18 May 2021 11:07:53 +0000 (UTC) Received: from colo-mx.corp.redhat.com (colo-mx02.intmail.prod.int.phx2.redhat.com [10.5.11.21]) by smtp.corp.redhat.com (Postfix) with ESMTPS id CE13F5DEAD; Tue, 18 May 2021 11:07:51 +0000 (UTC) Received: from lists01.pubmisc.prod.ext.phx2.redhat.com (lists01.pubmisc.prod.ext.phx2.redhat.com [10.5.19.33]) by colo-mx.corp.redhat.com (Postfix) with ESMTP id 70FF755344; Tue, 18 May 2021 11:07:47 +0000 (UTC) Received: from smtp.corp.redhat.com (int-mx01.intmail.prod.int.phx2.redhat.com [10.5.11.11]) by lists01.pubmisc.prod.ext.phx2.redhat.com (8.13.8/8.13.8) with ESMTP id 14IB7jKI030154 for ; Tue, 18 May 2021 07:07:45 -0400 Received: by smtp.corp.redhat.com (Postfix) id E026E18B5E; Tue, 18 May 2021 11:07:45 +0000 (UTC) Received: from localhost.localdomain (unknown [10.40.194.175]) by smtp.corp.redhat.com (Postfix) with ESMTP id 6546960657 for ; Tue, 18 May 2021 11:07:45 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=redhat.com; s=mimecast20190719; t=1621336082; h=from:from:sender:sender:reply-to:subject:subject:date:date: message-id:message-id:to:to:cc:mime-version:mime-version: content-type:content-type: content-transfer-encoding:content-transfer-encoding:list-id:list-help: list-unsubscribe:list-subscribe:list-post; bh=q+iru5t3JWfCi2SqQhaCrb1MMAejFqX6n+Q75fwK440=; b=GJDPq0jDIcCZ+Ah8fLMm0xBRD5edW4IsCMTFXPeEZwwagUxU6wuBQzXXHJwJUAxDr02F0g 22CJGanFj1GOceb7oFALSaQFt7b0dxdtlWx8yk9zHSbt74r2qWlL2pj4n1oR1zG3wsrfQN dAit7TgzQjPmNtJwi3gZL4+EyBq9qis= X-MC-Unique: IiBP2EG3N2GCL4DloF19QA-1 From: Michal Privoznik To: libvir-list@redhat.com Subject: [PATCH] qemusecuritytest: Honour EXIT_AM_SKIP Date: Tue, 18 May 2021 13:07:40 +0200 Message-Id: MIME-Version: 1.0 X-Scanned-By: MIMEDefang 2.79 on 10.5.11.11 X-loop: libvir-list@redhat.com X-BeenThere: libvir-list@redhat.com X-Mailman-Version: 2.1.12 Precedence: junk List-Id: Development discussions about the libvirt library & tools List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Sender: libvir-list-bounces@redhat.com Errors-To: libvir-list-bounces@redhat.com X-Scanned-By: MIMEDefang 2.79 on 10.5.11.14 Authentication-Results: relay.mimecast.com; auth=pass smtp.auth=CUSA124A263 smtp.mailfrom=libvir-list-bounces@redhat.com X-Mimecast-Spam-Score: 0 X-Mimecast-Originator: redhat.com Content-Transfer-Encoding: quoted-printable X-ZohoMail-DKIM: pass (identity @redhat.com) Content-Type: text/plain; charset="utf-8" There is a case where qemusecuritytest is skipped - on MacOS and MinGW. In such case, EXIT_AM_SKIP should be returned. However, my recent patch of 5d99b157bc completely missed that and made the test return EXIT_FAILURE even though the test exited early without performing any test case. Signed-off-by: Michal Privoznik Reviewed-by: J=C3=A1n Tomko --- tests/qemusecuritytest.c | 8 +++----- 1 file changed, 3 insertions(+), 5 deletions(-) diff --git a/tests/qemusecuritytest.c b/tests/qemusecuritytest.c index f7186700c4..a7e87fdf8f 100644 --- a/tests/qemusecuritytest.c +++ b/tests/qemusecuritytest.c @@ -143,15 +143,13 @@ mymain(void) #endif int ret =3D 0; =20 + if (!virSecurityXATTRNamespaceDefined()) + return EXIT_AM_SKIP; + if (virInitialize() < 0 || qemuTestDriverInit(&driver) < 0) return -1; =20 - if (!virSecurityXATTRNamespaceDefined()) { - ret =3D EXIT_AM_SKIP; - goto cleanup; - } - /* Now fix the secdriver */ virObjectUnref(driver.securityManager); =20 --=20 2.26.3