From nobody Sun May 19 00:42:37 2024 Delivered-To: importer@patchew.org Received-SPF: pass (zohomail.com: domain of redhat.com designates 170.10.129.124 as permitted sender) client-ip=170.10.129.124; envelope-from=libvir-list-bounces@redhat.com; helo=us-smtp-delivery-124.mimecast.com; Authentication-Results: mx.zohomail.com; dkim=pass; spf=pass (zohomail.com: domain of redhat.com designates 170.10.129.124 as permitted sender) smtp.mailfrom=libvir-list-bounces@redhat.com; dmarc=pass(p=none dis=none) header.from=redhat.com ARC-Seal: i=1; a=rsa-sha256; t=1645087860; cv=none; d=zohomail.com; s=zohoarc; b=MaZYpU0/OrTTgNaLG/qUHQxVCNQYzzOsTD3sgNB1HuwSO2zqWZWIq2VH2zTXxByCgbVe/S7FOoIyqvSG1xNvEHVwjSw3wwyF/pPDcPiqeNC8uze6CTaNS7B95WRcH41eK0tCmfqR8xAmd2t1x/pjkxF1trrD/See250civYQNb4= ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=zohomail.com; s=zohoarc; t=1645087860; h=Content-Type:Content-Transfer-Encoding:Date:From:List-Subscribe:List-Post:List-Id:List-Archive:List-Help:List-Unsubscribe:MIME-Version:Message-ID:Sender:Subject:To; bh=GIVzB9u2g6lKDU1WB76UC06HZ65B0d1LLda2RzuhWyk=; b=nBSF3wCjRwFVoYFayfi+9nQaWLaJwPXOr+dQheniwrsZvYLrqiDy8QPks2QJD+tE94jElzcu9x7vl9ZFl/YgiCtv8AIIu4q2qHxQGtgG5X5PIJ/AlGK5XwJR/ACvdRTXR9gySDSRkFogy8AHwS0HcYWLqzPxvqS0VK8noqy17wg= ARC-Authentication-Results: i=1; mx.zohomail.com; dkim=pass; spf=pass (zohomail.com: domain of redhat.com designates 170.10.129.124 as permitted sender) smtp.mailfrom=libvir-list-bounces@redhat.com; dmarc=pass header.from= (p=none dis=none) Return-Path: Received: from us-smtp-delivery-124.mimecast.com (us-smtp-delivery-124.mimecast.com [170.10.129.124]) by mx.zohomail.com with SMTPS id 1645087860971303.0801305801457; Thu, 17 Feb 2022 00:51:00 -0800 (PST) Received: from mimecast-mx01.redhat.com (mimecast-mx01.redhat.com [209.132.183.4]) by relay.mimecast.com with ESMTP with STARTTLS (version=TLSv1.2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id us-mta-607-lPuvJJ2yMDmFXbaLCfPdlA-1; Thu, 17 Feb 2022 03:50:58 -0500 Received: from smtp.corp.redhat.com (int-mx03.intmail.prod.int.phx2.redhat.com [10.5.11.13]) (using TLSv1.2 with cipher AECDH-AES256-SHA (256/256 bits)) (No client certificate requested) by mimecast-mx01.redhat.com (Postfix) with ESMTPS id 1AC2918460E6; Thu, 17 Feb 2022 08:50:53 +0000 (UTC) Received: from colo-mx.corp.redhat.com (colo-mx02.intmail.prod.int.phx2.redhat.com [10.5.11.21]) by smtp.corp.redhat.com (Postfix) with ESMTPS id 01F6F5E49D; Thu, 17 Feb 2022 08:50:51 +0000 (UTC) Received: from lists01.pubmisc.prod.ext.phx2.redhat.com (lists01.pubmisc.prod.ext.phx2.redhat.com [10.5.19.33]) by colo-mx.corp.redhat.com (Postfix) with ESMTP id 0E1B44BB7C; Thu, 17 Feb 2022 08:50:47 +0000 (UTC) Received: from smtp.corp.redhat.com (int-mx06.intmail.prod.int.phx2.redhat.com [10.5.11.16]) by lists01.pubmisc.prod.ext.phx2.redhat.com (8.13.8/8.13.8) with ESMTP id 21H8ojtS012169 for ; Thu, 17 Feb 2022 03:50:45 -0500 Received: by smtp.corp.redhat.com (Postfix) id E816F7B14E; Thu, 17 Feb 2022 08:50:45 +0000 (UTC) Received: from virval.usersys.redhat.com (unknown [10.43.2.187]) by smtp.corp.redhat.com (Postfix) with ESMTPS id BB52E7B6C1 for ; Thu, 17 Feb 2022 08:50:17 +0000 (UTC) Received: by virval.usersys.redhat.com (Postfix, from userid 500) id 568B224040C; Thu, 17 Feb 2022 09:50:16 +0100 (CET) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=redhat.com; s=mimecast20190719; t=1645087859; h=from:from:sender:sender:reply-to:subject:subject:date:date: message-id:message-id:to:to:cc:mime-version:mime-version: content-type:content-type: content-transfer-encoding:content-transfer-encoding:list-id:list-help: list-unsubscribe:list-subscribe:list-post; bh=GIVzB9u2g6lKDU1WB76UC06HZ65B0d1LLda2RzuhWyk=; b=Xli3qGoPmVycXHzzv25Me2eZiv9RSz0/BfX+f+wPuF1evcIINToRbw6+LzbCweUHnwLVYU aS42+qvDggthNCimQ4GYJlSLDMOmED9ux7LXmmjbEqPkMLPZ0iwnaybjpGd6AEt+SJKirI 2yGiSYoyQTAvAjmuaUhb2Es7fXNLiNA= X-MC-Unique: lPuvJJ2yMDmFXbaLCfPdlA-1 From: Jiri Denemark To: libvir-list@redhat.com Subject: [libvirt PATCH] qemu: Fix crash at the end of migration Date: Thu, 17 Feb 2022 09:50:15 +0100 Message-Id: MIME-Version: 1.0 X-Scanned-By: MIMEDefang 2.79 on 10.5.11.16 X-loop: libvir-list@redhat.com X-BeenThere: libvir-list@redhat.com X-Mailman-Version: 2.1.12 Precedence: junk List-Id: Development discussions about the libvirt library & tools List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Sender: libvir-list-bounces@redhat.com Errors-To: libvir-list-bounces@redhat.com X-Scanned-By: MIMEDefang 2.79 on 10.5.11.13 Authentication-Results: relay.mimecast.com; auth=pass smtp.auth=CUSA124A263 smtp.mailfrom=libvir-list-bounces@redhat.com X-Mimecast-Spam-Score: 0 X-Mimecast-Originator: redhat.com Content-Transfer-Encoding: quoted-printable X-ZohoMail-DKIM: pass (identity @redhat.com) X-ZM-MESSAGEID: 1645087861933100001 Content-Type: text/plain; charset="utf-8" The destination daemon would crash in Finish phase due to NULL dereference which I missed in my review of commit v8.0.0-428-g0301db44e2. Signed-off-by: Jiri Denemark Reviewed-by: J=C3=A1n Tomko --- src/qemu/qemu_migration.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/src/qemu/qemu_migration.c b/src/qemu/qemu_migration.c index fea5e71f4d..5aecdddff0 100644 --- a/src/qemu/qemu_migration.c +++ b/src/qemu/qemu_migration.c @@ -5855,7 +5855,7 @@ qemuMigrationDstFinish(virQEMUDriver *driver, if (jobData) { priv->job.completed =3D g_steal_pointer(&jobData); priv->job.completed->status =3D VIR_DOMAIN_JOB_STATUS_COMPLETE= D; - qemuDomainJobSetStatsType(jobData, + qemuDomainJobSetStatsType(priv->job.completed, QEMU_DOMAIN_JOB_STATS_TYPE_MIGRATION= ); } =20 --=20 2.35.1