From nobody Sun May 19 14:40:07 2024 Delivered-To: importer@patchew.org Received-SPF: pass (zohomail.com: domain of redhat.com designates 216.205.24.124 as permitted sender) client-ip=216.205.24.124; envelope-from=libvir-list-bounces@redhat.com; helo=us-smtp-delivery-124.mimecast.com; Authentication-Results: mx.zohomail.com; dkim=pass; spf=pass (zohomail.com: domain of redhat.com designates 216.205.24.124 as permitted sender) smtp.mailfrom=libvir-list-bounces@redhat.com; dmarc=pass(p=none dis=none) header.from=redhat.com ARC-Seal: i=1; a=rsa-sha256; t=1617022558; cv=none; d=zohomail.com; s=zohoarc; b=ZUpv50EMNORshaoEp48oyhWYWNQqlehRh5lPLyXFASYx/wCg6/xQsFHlyYSXkAL8LGDXIAUvu3Iw4Dy1iacBZmJnjOWOcQHteIn22CmOVcYqikBe6R4hDlGZ10ZKNpEKzdLyHoGAJyVowPNpKClrv9QM5o9tZ4jSLEyCQPmHUo8= ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=zohomail.com; s=zohoarc; t=1617022558; h=Content-Type:Content-Transfer-Encoding:Date:From:List-Subscribe:List-Post:List-Id:List-Archive:List-Help:List-Unsubscribe:MIME-Version:Message-ID:Sender:Subject:To; bh=3+LlMwYoSXbvXyhmDwvTje+HCFPJ3ry+7BBQ9mfnPOE=; b=XXN8hk75hmKGCr9uvkaw4bU6jrZNblzvmfFOlqzEvDA2b7XugVZtJhWd+G5Puu18GnPDAH95k1cMfC8hv7Q+6xgzEFkzP//dAPsiRdr4Hord9UCwBQXCJCKP/Xwhhndocl9G9Ap75hk8FOZhp5ho4fMByKEwPFXBMfSc0RaLTEs= ARC-Authentication-Results: i=1; mx.zohomail.com; dkim=pass; spf=pass (zohomail.com: domain of redhat.com designates 216.205.24.124 as permitted sender) smtp.mailfrom=libvir-list-bounces@redhat.com; dmarc=pass header.from= (p=none dis=none) header.from= Return-Path: Received: from us-smtp-delivery-124.mimecast.com (us-smtp-delivery-124.mimecast.com [216.205.24.124]) by mx.zohomail.com with SMTPS id 1617022558472897.4567422717528; Mon, 29 Mar 2021 05:55:58 -0700 (PDT) Received: from mimecast-mx01.redhat.com (mimecast-mx01.redhat.com [209.132.183.4]) (Using TLS) by relay.mimecast.com with ESMTP id us-mta-365-mMAYdgvtOgOgH4d9lHBKew-1; Mon, 29 Mar 2021 08:55:54 -0400 Received: from smtp.corp.redhat.com (int-mx07.intmail.prod.int.phx2.redhat.com [10.5.11.22]) (using TLSv1.2 with cipher AECDH-AES256-SHA (256/256 bits)) (No client certificate requested) by mimecast-mx01.redhat.com (Postfix) with ESMTPS id ACBE1A40C0; Mon, 29 Mar 2021 12:55:12 +0000 (UTC) Received: from colo-mx.corp.redhat.com (colo-mx02.intmail.prod.int.phx2.redhat.com [10.5.11.21]) by smtp.corp.redhat.com (Postfix) with ESMTPS id AFB291001281; Mon, 29 Mar 2021 12:55:10 +0000 (UTC) Received: from lists01.pubmisc.prod.ext.phx2.redhat.com (lists01.pubmisc.prod.ext.phx2.redhat.com [10.5.19.33]) by colo-mx.corp.redhat.com (Postfix) with ESMTP id 32BFE4BB7C; Mon, 29 Mar 2021 12:55:07 +0000 (UTC) Received: from smtp.corp.redhat.com (int-mx03.intmail.prod.int.phx2.redhat.com [10.5.11.13]) by lists01.pubmisc.prod.ext.phx2.redhat.com (8.13.8/8.13.8) with ESMTP id 12TCniHj003011 for ; Mon, 29 Mar 2021 08:49:44 -0400 Received: by smtp.corp.redhat.com (Postfix) id 4CFFA60622; Mon, 29 Mar 2021 12:49:44 +0000 (UTC) Received: from localhost.localdomain (unknown [10.40.194.43]) by smtp.corp.redhat.com (Postfix) with ESMTP id C151D60843 for ; Mon, 29 Mar 2021 12:49:40 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=redhat.com; s=mimecast20190719; t=1617022557; h=from:from:sender:sender:reply-to:subject:subject:date:date: message-id:message-id:to:to:cc:mime-version:mime-version: content-type:content-type: content-transfer-encoding:content-transfer-encoding:list-id:list-help: list-unsubscribe:list-subscribe:list-post; bh=3+LlMwYoSXbvXyhmDwvTje+HCFPJ3ry+7BBQ9mfnPOE=; b=eTtZ5ystH/7oC/VoAqZoOMTUMcO/B8mNEs71Dlx2WcVS9YhDcSbWwswM4AkWI82TRzq0Al SjBaQ9nsDZRfJ8XmDn2y/iefXgJc9uiZaCROtT5xjdtw8NnBMrA/FEESqIIQiS06zJMtSh pcQ+kFtlAxCAotnVZSc1fv59Wg1rGuE= X-MC-Unique: mMAYdgvtOgOgH4d9lHBKew-1 From: Michal Privoznik To: libvir-list@redhat.com Subject: [PATCH] qemu_driver: Acquire MODIFY job in qemuDomainStartDirtyRateCalc() Date: Mon, 29 Mar 2021 14:49:36 +0200 Message-Id: MIME-Version: 1.0 X-Scanned-By: MIMEDefang 2.79 on 10.5.11.13 X-loop: libvir-list@redhat.com X-BeenThere: libvir-list@redhat.com X-Mailman-Version: 2.1.12 Precedence: junk List-Id: Development discussions about the libvirt library & tools List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Sender: libvir-list-bounces@redhat.com Errors-To: libvir-list-bounces@redhat.com X-Scanned-By: MIMEDefang 2.84 on 10.5.11.22 Authentication-Results: relay.mimecast.com; auth=pass smtp.auth=CUSA124A263 smtp.mailfrom=libvir-list-bounces@redhat.com X-Mimecast-Spam-Score: 0 X-Mimecast-Originator: redhat.com Content-Transfer-Encoding: quoted-printable X-ZohoMail-DKIM: pass (identity @redhat.com) Content-Type: text/plain; charset="utf-8" This API talks to QEMU and changes its internal state. Therefore, it should acquire QEMU_JOB_MODIFY instead of QEMU_JOB_QUERY. Signed-off-by: Michal Privoznik Reviewed-by: Jiri Denemark --- src/qemu/qemu_driver.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/src/qemu/qemu_driver.c b/src/qemu/qemu_driver.c index 69dc704a44..af015f0625 100644 --- a/src/qemu/qemu_driver.c +++ b/src/qemu/qemu_driver.c @@ -20425,7 +20425,7 @@ qemuDomainStartDirtyRateCalc(virDomainPtr dom, if (virDomainStartDirtyRateCalcEnsureACL(dom->conn, vm->def) < 0) goto cleanup; =20 - if (qemuDomainObjBeginJob(driver, vm, QEMU_JOB_QUERY) < 0) + if (qemuDomainObjBeginJob(driver, vm, QEMU_JOB_MODIFY) < 0) goto cleanup; =20 if (!virDomainObjIsActive(vm)) { --=20 2.26.3