conf: Fix message when maximum vCPU count is less than current

[libvirt] [PATCH] conf: Fix message when maximum vCPU count is less than current

Peter Krempa posted 1 patch 6 years, 5 months ago

Download mbox

Patches applied successfully (tree, apply log)
git fetch https://github.com/patchew-project/libvirt tags/patchew/ecd5e11096139c39bfdd29a067b11480e462dd6e.1509698666.git.pkrempa@redhat.com

src/conf/domain_conf.c | 6 +++---
1 file changed, 3 insertions(+), 3 deletions(-)

Expand all Fold all

[libvirt] [PATCH] conf: Fix message when maximum vCPU count is less than current

Posted by Peter Krempa 6 years, 5 months ago

Reword the message and drop the numbers (which were reversed) from it
so that it actually makes sense.

Resolves: https://bugzilla.redhat.com/show_bug.cgi?id=1509151
---
 src/conf/domain_conf.c | 6 +++---
 1 file changed, 3 insertions(+), 3 deletions(-)

diff --git a/src/conf/domain_conf.c b/src/conf/domain_conf.c
index 77c20c697..64f8df1be 100644
--- a/src/conf/domain_conf.c
+++ b/src/conf/domain_conf.c
@@ -1505,9 +1505,9 @@ virDomainDefSetVcpus(virDomainDefPtr def,
     size_t i;

     if (vcpus > def->maxvcpus) {
-        virReportError(VIR_ERR_CONFIG_UNSUPPORTED,
-                       _("maxvcpus must not be less than current vcpus (%u < %zu)"),
-                       vcpus, def->maxvcpus);
+        virReportError(VIR_ERR_CONFIG_UNSUPPORTED, "%s",
+                       _("maximum vCPU count must not be less than current "
+                         "vCPU count"));
         return -1;
     }

-- 
2.14.3

--
libvir-list mailing list
libvir-list@redhat.com
https://www.redhat.com/mailman/listinfo/libvir-list

Re: [libvirt] [PATCH] conf: Fix message when maximum vCPU count is less than current

Posted by Ján Tomko 6 years, 5 months ago

On Fri, Nov 03, 2017 at 09:44:26AM +0100, Peter Krempa wrote:
>Reword the message and drop the numbers (which were reversed) from it
>so that it actually makes sense.
>
>Resolves: https://bugzilla.redhat.com/show_bug.cgi?id=1509151
>---
> src/conf/domain_conf.c | 6 +++---
> 1 file changed, 3 insertions(+), 3 deletions(-)
>

ACK

Jan
--
libvir-list mailing list
libvir-list@redhat.com
https://www.redhat.com/mailman/listinfo/libvir-list

Re: [libvirt] [PATCH] conf: Fix message when maximum vCPU count is less than current

Posted by Peter Krempa 6 years, 5 months ago

On Fri, Nov 03, 2017 at 09:44:26 +0100, Peter Krempa wrote:
> Reword the message and drop the numbers (which were reversed) from it
> so that it actually makes sense.
> 
> Resolves: https://bugzilla.redhat.com/show_bug.cgi?id=1509151
> ---
>  src/conf/domain_conf.c | 6 +++---
>  1 file changed, 3 insertions(+), 3 deletions(-)

Ping?
--
libvir-list mailing list
libvir-list@redhat.com
https://www.redhat.com/mailman/listinfo/libvir-list