From nobody Tue May 14 20:41:17 2024 Delivered-To: importer@patchew.org Received-SPF: pass (zohomail.com: domain of redhat.com designates 170.10.133.124 as permitted sender) client-ip=170.10.133.124; envelope-from=libvir-list-bounces@redhat.com; helo=us-smtp-delivery-124.mimecast.com; Authentication-Results: mx.zohomail.com; dkim=pass; spf=pass (zohomail.com: domain of redhat.com designates 170.10.133.124 as permitted sender) smtp.mailfrom=libvir-list-bounces@redhat.com; dmarc=pass(p=none dis=none) header.from=redhat.com ARC-Seal: i=1; a=rsa-sha256; t=1643110878; cv=none; d=zohomail.com; s=zohoarc; b=B7ljAYYEo9G/13Kx08xsDCCJjX0Mk1VxwhdNiomxLjIYM7iwH6sh6hVuyKtNMtKKxPMkfC63l4iFH3fE1wd8828EGJ0OJudSFyEF8w8lpF+iQ4aF7Uu2BRQTorH1KoeD8hgrMVsAMHxGeybGTEetTaRc7K4VjCK3/jxZplpBUzQ= ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=zohomail.com; s=zohoarc; t=1643110878; h=Content-Type:Content-Transfer-Encoding:Date:From:List-Subscribe:List-Post:List-Id:List-Archive:List-Help:List-Unsubscribe:MIME-Version:Message-ID:Sender:Subject:To; bh=HvelVTFNqxgTQYS/s/X9IUh04rge36C8w6XQLLzbwW0=; b=de4FfoOLwSy9pmYM83frSuSXUhYglY3xIB7cj5YNqqL1GhFzjolhFH/O9T73wXwoaYYkbjKqsVD4+Ev7VYzA8/HeO8uKFswB8l1bGaIT8Iw/2Dwe6I6Dz/C2znPNKqpHjUM/8JoswQU6YE/EnWF/p85HzmnMPGLYWQ+3QMJHWwQ= ARC-Authentication-Results: i=1; mx.zohomail.com; dkim=pass; spf=pass (zohomail.com: domain of redhat.com designates 170.10.133.124 as permitted sender) smtp.mailfrom=libvir-list-bounces@redhat.com; dmarc=pass header.from= (p=none dis=none) Return-Path: Received: from us-smtp-delivery-124.mimecast.com (us-smtp-delivery-124.mimecast.com [170.10.133.124]) by mx.zohomail.com with SMTPS id 164311087881817.999541800357292; Tue, 25 Jan 2022 03:41:18 -0800 (PST) Received: from mimecast-mx01.redhat.com (mimecast-mx01.redhat.com [209.132.183.4]) by relay.mimecast.com with ESMTP with STARTTLS (version=TLSv1.2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id us-mta-536-GEFOBqMBMRqnKCUFAVvAfg-1; Tue, 25 Jan 2022 06:41:09 -0500 Received: from smtp.corp.redhat.com (int-mx05.intmail.prod.int.phx2.redhat.com [10.5.11.15]) (using TLSv1.2 with cipher AECDH-AES256-SHA (256/256 bits)) (No client certificate requested) by mimecast-mx01.redhat.com (Postfix) with ESMTPS id E7B6783DD26; Tue, 25 Jan 2022 11:41:03 +0000 (UTC) Received: from colo-mx.corp.redhat.com (colo-mx02.intmail.prod.int.phx2.redhat.com [10.5.11.21]) by smtp.corp.redhat.com (Postfix) with ESMTPS id 167F36F95A; Tue, 25 Jan 2022 11:41:03 +0000 (UTC) Received: from lists01.pubmisc.prod.ext.phx2.redhat.com (lists01.pubmisc.prod.ext.phx2.redhat.com [10.5.19.33]) by colo-mx.corp.redhat.com (Postfix) with ESMTP id E237F4BB7B; Tue, 25 Jan 2022 11:41:01 +0000 (UTC) Received: from smtp.corp.redhat.com (int-mx03.intmail.prod.int.phx2.redhat.com [10.5.11.13]) by lists01.pubmisc.prod.ext.phx2.redhat.com (8.13.8/8.13.8) with ESMTP id 20PBe9Oe012370 for ; Tue, 25 Jan 2022 06:40:09 -0500 Received: by smtp.corp.redhat.com (Postfix) id E20A87D71C; Tue, 25 Jan 2022 11:40:09 +0000 (UTC) Received: from maggie.redhat.com (unknown [10.43.2.56]) by smtp.corp.redhat.com (Postfix) with ESMTP id 696747D71B for ; Tue, 25 Jan 2022 11:39:58 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=redhat.com; s=mimecast20190719; t=1643110878; h=from:from:sender:sender:reply-to:subject:subject:date:date: message-id:message-id:to:to:cc:mime-version:mime-version: content-type:content-type: content-transfer-encoding:content-transfer-encoding:list-id:list-help: list-unsubscribe:list-subscribe:list-post; bh=HvelVTFNqxgTQYS/s/X9IUh04rge36C8w6XQLLzbwW0=; b=ilZlqtgF+35urROkJriKWc9NMdSZ0ZcIPgrEYb/D/ArwAxk9Ln8YQJ9EpVy2hzUI+/lB7M 2O+ErM+2hAcp9xpiXeIMqsqA6Hz83mv6wK7Jp9OYyB3HjzLAEwv6cbT5ThXnkZFmsrBt40 544cXwGKztq/0ipPATg+ne8nUfh8xRI= X-MC-Unique: GEFOBqMBMRqnKCUFAVvAfg-1 From: Michal Privoznik To: libvir-list@redhat.com Subject: [PATCH] qemuDomainAttachHostPCIDevice: Fix coding style Date: Tue, 25 Jan 2022 12:39:56 +0100 Message-Id: MIME-Version: 1.0 X-Scanned-By: MIMEDefang 2.79 on 10.5.11.13 X-loop: libvir-list@redhat.com X-BeenThere: libvir-list@redhat.com X-Mailman-Version: 2.1.12 Precedence: junk List-Id: Development discussions about the libvirt library & tools List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Sender: libvir-list-bounces@redhat.com Errors-To: libvir-list-bounces@redhat.com X-Scanned-By: MIMEDefang 2.79 on 10.5.11.15 Authentication-Results: relay.mimecast.com; auth=pass smtp.auth=CUSA124A263 smtp.mailfrom=libvir-list-bounces@redhat.com X-Mimecast-Spam-Score: 0 X-Mimecast-Originator: redhat.com Content-Transfer-Encoding: quoted-printable X-ZohoMail-DKIM: pass (identity @redhat.com) X-ZM-MESSAGEID: 1643110880578100001 Content-Type: text/plain; charset="utf-8" Our coding style requires that a body of an if() longer than two lines is wrapped in a curly braces. There's one offender in qemuDomainAttachHostPCIDevice(). Fortunately, there was no functional problem because one of the lines is a comment. Signed-off-by: Michal Privoznik --- Pushed under trivial rule. src/qemu/qemu_hotplug.c | 3 ++- 1 file changed, 2 insertions(+), 1 deletion(-) diff --git a/src/qemu/qemu_hotplug.c b/src/qemu/qemu_hotplug.c index 22acbd0852..f36de2385a 100644 --- a/src/qemu/qemu_hotplug.c +++ b/src/qemu/qemu_hotplug.c @@ -1663,9 +1663,10 @@ qemuDomainAttachHostPCIDevice(virQEMUDriver *driver, =20 qemuAssignDeviceHostdevAlias(vm->def, &info->alias, -1); =20 - if (qemuDomainIsPSeries(vm->def)) + if (qemuDomainIsPSeries(vm->def)) { /* Isolation groups are only relevant for pSeries guests */ qemuDomainFillDeviceIsolationGroup(vm->def, &dev); + } =20 if (qemuDomainEnsurePCIAddress(vm, &dev) < 0) goto error; --=20 2.34.1