From nobody Wed May 15 08:23:23 2024 Delivered-To: importer@patchew.org Received-SPF: pass (zohomail.com: domain of redhat.com designates 170.10.129.124 as permitted sender) client-ip=170.10.129.124; envelope-from=libvir-list-bounces@redhat.com; helo=us-smtp-delivery-124.mimecast.com; Authentication-Results: mx.zohomail.com; dkim=pass; spf=pass (zohomail.com: domain of redhat.com designates 170.10.129.124 as permitted sender) smtp.mailfrom=libvir-list-bounces@redhat.com; dmarc=pass(p=none dis=none) header.from=redhat.com ARC-Seal: i=1; a=rsa-sha256; t=1656571231; cv=none; d=zohomail.com; s=zohoarc; b=UuWQRyM/24I5Jb03BaSntKwpOAPd9QLe3z/yirSp75Lwr6s2kGB66iQA+AQIdsRXIcA9B13sLdxPEugCWnKSoT+XMo4zBS2yZscHjqtrTa4oxVBV4zVp42hK1NHhYKVvq8BFQiW3h7yITUyzlGRU0kMmaj0APNTfmXHorHKyc0A= ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=zohomail.com; s=zohoarc; t=1656571231; h=Content-Type:Content-Transfer-Encoding:Date:From:List-Subscribe:List-Post:List-Id:List-Archive:List-Help:List-Unsubscribe:MIME-Version:Message-ID:Sender:Subject:To; bh=HiwTebb577Tuv1qFhpoZwR5R5hemcKDsdo1FsRBm1wc=; b=gvrMk4ZlK2bFPYul84sUQnU6p4utbsFh+x49pfh5jOrLeGN4Xxn2DxKIGef6IRpeyjLmFPNXlSMqXTA3woR+Ll036tRr3fhpGOf8xFmhG6U1QgwwFCPHUuvYHrEEPwZvj987SCH2ipQykRvBj7oLlCVzU2rdlOGsSeRL4bCVpAs= ARC-Authentication-Results: i=1; mx.zohomail.com; dkim=pass; spf=pass (zohomail.com: domain of redhat.com designates 170.10.129.124 as permitted sender) smtp.mailfrom=libvir-list-bounces@redhat.com; dmarc=pass header.from= (p=none dis=none) Return-Path: Received: from us-smtp-delivery-124.mimecast.com (us-smtp-delivery-124.mimecast.com [170.10.129.124]) by mx.zohomail.com with SMTPS id 1656571231035754.5820084546506; Wed, 29 Jun 2022 23:40:31 -0700 (PDT) Received: from mimecast-mx02.redhat.com (mimecast-mx02.redhat.com [66.187.233.88]) by relay.mimecast.com with ESMTP with STARTTLS (version=TLSv1.2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id us-mta-383-ei4XvbJ8M0Wlag0CF9zroA-1; Thu, 30 Jun 2022 02:40:28 -0400 Received: from smtp.corp.redhat.com (int-mx04.intmail.prod.int.rdu2.redhat.com [10.11.54.4]) (using TLSv1.2 with cipher AECDH-AES256-SHA (256/256 bits)) (No client certificate requested) by mimecast-mx02.redhat.com (Postfix) with ESMTPS id 782621019C88; Thu, 30 Jun 2022 06:40:26 +0000 (UTC) Received: from mm-prod-listman-01.mail-001.prod.us-east-1.aws.redhat.com (unknown [10.30.29.100]) by smtp.corp.redhat.com (Postfix) with ESMTP id E9E9B2026D07; Thu, 30 Jun 2022 06:40:24 +0000 (UTC) Received: from mm-prod-listman-01.mail-001.prod.us-east-1.aws.redhat.com (localhost [IPv6:::1]) by mm-prod-listman-01.mail-001.prod.us-east-1.aws.redhat.com (Postfix) with ESMTP id AE38F1947060; Thu, 30 Jun 2022 06:40:24 +0000 (UTC) Received: from smtp.corp.redhat.com (int-mx05.intmail.prod.int.rdu2.redhat.com [10.11.54.5]) by mm-prod-listman-01.mail-001.prod.us-east-1.aws.redhat.com (Postfix) with ESMTP id 3F2141947058 for ; Thu, 30 Jun 2022 06:40:23 +0000 (UTC) Received: by smtp.corp.redhat.com (Postfix) id 2E5C09D63; Thu, 30 Jun 2022 06:40:23 +0000 (UTC) Received: from maggie.redhat.com (unknown [10.43.2.39]) by smtp.corp.redhat.com (Postfix) with ESMTP id CDB2A815B for ; Thu, 30 Jun 2022 06:40:22 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=redhat.com; s=mimecast20190719; t=1656571230; h=from:from:sender:sender:reply-to:subject:subject:date:date: message-id:message-id:to:to:cc:mime-version:mime-version: content-type:content-type: content-transfer-encoding:content-transfer-encoding:list-id:list-help: list-unsubscribe:list-subscribe:list-post; bh=HiwTebb577Tuv1qFhpoZwR5R5hemcKDsdo1FsRBm1wc=; b=g60GPmVaLgp9MbK7eNSOKv/yxQzAdrOGP8F4hNEhTTpitpmDNI/Ietmh3qffO39EKsIj3O cjVeH2M7oDDf0rZ6GQ0UwE5HNlChRR0ZRbOK3tA0WaLBvntbdFt7HQh4c29IFy+bHarWLD lS0cs2oxyMvpC6JbiHef93Y1oKpburY= X-MC-Unique: ei4XvbJ8M0Wlag0CF9zroA-1 X-Original-To: libvir-list@listman.corp.redhat.com From: Michal Privoznik To: libvir-list@redhat.com Subject: [PATCH for 8.5.0] API: Remove internal impl detail from VIR_DOMAIN_IOTHREAD_THREAD_POOL_{MIN, MAX} description Date: Thu, 30 Jun 2022 08:40:21 +0200 Message-Id: MIME-Version: 1.0 X-Scanned-By: MIMEDefang 2.79 on 10.11.54.5 X-BeenThere: libvir-list@redhat.com X-Mailman-Version: 2.1.29 Precedence: list List-Id: Development discussions about the libvirt library & tools List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: libvir-list-bounces@redhat.com Sender: "libvir-list" X-Scanned-By: MIMEDefang 2.78 on 10.11.54.4 Authentication-Results: relay.mimecast.com; auth=pass smtp.auth=CUSA124A263 smtp.mailfrom=libvir-list-bounces@redhat.com X-Mimecast-Spam-Score: 0 X-Mimecast-Originator: redhat.com Content-Transfer-Encoding: quoted-printable X-ZohoMail-DKIM: pass (identity @redhat.com) X-ZM-MESSAGEID: 1656571232557100001 Content-Type: text/plain; charset="utf-8"; x-default="true" When introducing VIR_DOMAIN_IOTHREAD_THREAD_POOL_MIN and VIR_DOMAIN_IOTHREAD_THREAD_POOL_MAX typed parameters, I've made a shortcut. Since at the monitor level these two are set in two separate calls and minimum has to be always smaller than maximum (or equal to it), it may happen that one of the values we want to set violates this restriction. So I've put a little note in the public API description warning users about this. However, the proper solution is to have a logic that checks the current values and based on that set either minimum or maximum value first. But until we get there, remove that note from the public API before it gets released. Related: https://gitlab.com/libvirt/libvirt/-/issues/339 Signed-off-by: Michal Privoznik Reviewed-by: Daniel P. Berrang=C3=A9 --- include/libvirt/libvirt-domain.h | 8 ++------ 1 file changed, 2 insertions(+), 6 deletions(-) diff --git a/include/libvirt/libvirt-domain.h b/include/libvirt/libvirt-dom= ain.h index 05344aaa95..7430a08619 100644 --- a/include/libvirt/libvirt-domain.h +++ b/include/libvirt/libvirt-domain.h @@ -2513,9 +2513,7 @@ int virDomainDelIOThread(virDomainPt= r domain, * * Sets the lower bound for thread pool size. A value of -1 disables this = bound * leaving hypervisor use its default value, though this value is not acce= pted - * for running domains. Due to internal implementation it's recommended to= set - * VIR_DOMAIN_IOTHREAD_THREAD_POOL_MIN and VIR_DOMAIN_IOTHREAD_THREAD_POOL= _MAX - * separately. Accepted type is VIR_TYPED_PARAM_INT. + * for running domains. Accepted type is VIR_TYPED_PARAM_INT. * * Since: 8.5.0 */ @@ -2527,9 +2525,7 @@ int virDomainDelIOThread(virDomainPt= r domain, * Sets the upper bound for thread pool size. A value of -1 disables this = bound * leaving hypervisor use its default value, though this value is not acce= pted * for running domains. Since the upper band has to be equal to or greater= than - * lower bound value of 0 is not accepted. Due to internal implementation = it's - * recommended to set VIR_DOMAIN_IOTHREAD_THREAD_POOL_MIN and - * VIR_DOMAIN_IOTHREAD_THREAD_POOL_MAX separately. Accepted type is + * lower bound value of 0 is not accepted. Accepted type is * VIR_TYPED_PARAM_INT. * * Since: 8.5.0 --=20 2.35.1