Signed-off-by: Cole Robinson <crobinso@redhat.com>
---
 docs/kbase/launch_security_sev.rst | 2 ++
 1 file changed, 2 insertions(+)

diff --git a/docs/kbase/launch_security_sev.rst b/docs/kbase/launch_security_sev.rst
index 3ebb01ad80..9f6330a1ca 100644
--- a/docs/kbase/launch_security_sev.rst
+++ b/docs/kbase/launch_security_sev.rst
@@ -295,6 +295,8 @@ In order to make virtio devices work, we need to use
 ``<driver iommu='on'/>`` inside the given device XML element in order
 to enable DMA API in the virtio driver.
 
+QEMU 6.0 and later will `set this by default <https://gitlab.com/qemu-project/qemu/-/commit/9f88a7a3df>`__. For earlier QEMU versions, you will need to explicitly enable this in the device XML:
+
 ::
 
    # virsh edit <domain>
-- 
2.36.1

On Sat, Jun 11, 2022 at 12:44:54PM -0400, Cole Robinson wrote:
> Signed-off-by: Cole Robinson <crobinso@redhat.com>
> ---
>  docs/kbase/launch_security_sev.rst | 2 ++
>  1 file changed, 2 insertions(+)
> 
> diff --git a/docs/kbase/launch_security_sev.rst b/docs/kbase/launch_security_sev.rst
> index 3ebb01ad80..9f6330a1ca 100644
> --- a/docs/kbase/launch_security_sev.rst
> +++ b/docs/kbase/launch_security_sev.rst
> @@ -295,6 +295,8 @@ In order to make virtio devices work, we need to use
>  ``<driver iommu='on'/>`` inside the given device XML element in order
>  to enable DMA API in the virtio driver.
>  
> +QEMU 6.0 and later will `set this by default <https://gitlab.com/qemu-project/qemu/-/commit/9f88a7a3df>`__. For earlier QEMU versions, you will need to explicitly enable this in the device XML:

Do we need to link the specific commit in the kbase article? I think simply
saying (in the same paragrap)

"... enable DMA API in the virtio driver. Starting with QEMU 6.0.0 QEMU will
set this for us by default. For earlier versions though, you will need to
explicitly enable this in the device XML as follows:"

Reviewed-by: Erik Skultety <eskultet@redhat.com>

Regards,
Erik

On 6/13/22 2:56 AM, Erik Skultety wrote:
> On Sat, Jun 11, 2022 at 12:44:54PM -0400, Cole Robinson wrote:
>> Signed-off-by: Cole Robinson <crobinso@redhat.com>
>> ---
>>  docs/kbase/launch_security_sev.rst | 2 ++
>>  1 file changed, 2 insertions(+)
>>
>> diff --git a/docs/kbase/launch_security_sev.rst b/docs/kbase/launch_security_sev.rst
>> index 3ebb01ad80..9f6330a1ca 100644
>> --- a/docs/kbase/launch_security_sev.rst
>> +++ b/docs/kbase/launch_security_sev.rst
>> @@ -295,6 +295,8 @@ In order to make virtio devices work, we need to use
>>  ``<driver iommu='on'/>`` inside the given device XML element in order
>>  to enable DMA API in the virtio driver.
>>  
>> +QEMU 6.0 and later will `set this by default <https://gitlab.com/qemu-project/qemu/-/commit/9f88a7a3df>`__. For earlier QEMU versions, you will need to explicitly enable this in the device XML:
> 
> Do we need to link the specific commit in the kbase article? I think simply
> saying (in the same paragrap)
> 
> "... enable DMA API in the virtio driver. Starting with QEMU 6.0.0 QEMU will
> set this for us by default. For earlier versions though, you will need to
> explicitly enable this in the device XML as follows:"
> 
> Reviewed-by: Erik Skultety <eskultet@redhat.com>

Thanks, I pushed with your suggested wording

- Cole