From nobody Fri May 17 10:13:46 2024 Delivered-To: importer@patchew.org Received-SPF: pass (zohomail.com: domain of redhat.com designates 170.10.133.124 as permitted sender) client-ip=170.10.133.124; envelope-from=libvir-list-bounces@redhat.com; helo=us-smtp-delivery-124.mimecast.com; Authentication-Results: mx.zohomail.com; dkim=pass; spf=pass (zohomail.com: domain of redhat.com designates 170.10.133.124 as permitted sender) smtp.mailfrom=libvir-list-bounces@redhat.com; dmarc=pass(p=none dis=none) header.from=redhat.com ARC-Seal: i=1; a=rsa-sha256; t=1670939292; cv=none; d=zohomail.com; s=zohoarc; b=PqoEqzyghqaXatCjoCwb5RhcQCwSrKEsfm2Hc+7GAsEt3czWzG2N6G1+ZAaNrcWeZjpDdn+9rVDlJI2AeeBa+nZEJlr4Ho0XPVezG3pV5AxjIaseMKcXH8IF8v2/Hsnyh7keQZmqnwmK2mjhrVjTLEcAni2asFRhv+baGaay5C8= ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=zohomail.com; s=zohoarc; t=1670939292; h=Content-Type:Content-Transfer-Encoding:Date:From:List-Subscribe:List-Post:List-Id:List-Archive:List-Help:List-Unsubscribe:MIME-Version:Message-ID:Sender:Subject:To; bh=hKWrH3uCuMSbNAwEOuPpfaGbPqwvgNSnB8u55Hq7rQk=; b=e6IZWIhRifGvTJzWOAjGxtOqL4IXO8hBUmGi7ClmNUdUaTzBQ+dzSVcVBaNK6aAuATbQ0yhFqgGVTbxg3HAS4VA+gbxf7VQWswyNad+Rlv9s2++ETQmc7f+aHL9M1NtZSfoiIOu+S77VT0X26tv0dDEfyPkeWbGSv+2MBk2VRgE= ARC-Authentication-Results: i=1; mx.zohomail.com; dkim=pass; spf=pass (zohomail.com: domain of redhat.com designates 170.10.133.124 as permitted sender) smtp.mailfrom=libvir-list-bounces@redhat.com; dmarc=pass header.from= (p=none dis=none) Return-Path: Received: from us-smtp-delivery-124.mimecast.com (us-smtp-delivery-124.mimecast.com [170.10.133.124]) by mx.zohomail.com with SMTPS id 1670939292303780.2917229530865; Tue, 13 Dec 2022 05:48:12 -0800 (PST) Received: from mimecast-mx02.redhat.com (mimecast-mx02.redhat.com [66.187.233.88]) by relay.mimecast.com with ESMTP with STARTTLS (version=TLSv1.2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id us-mta-196-rqw8D3uhN9uZCBN_lP_k3A-1; Tue, 13 Dec 2022 08:48:05 -0500 Received: from smtp.corp.redhat.com (int-mx06.intmail.prod.int.rdu2.redhat.com [10.11.54.6]) (using TLSv1.2 with cipher AECDH-AES256-SHA (256/256 bits)) (No client certificate requested) by mimecast-mx02.redhat.com (Postfix) with ESMTPS id 00EBF82A685; Tue, 13 Dec 2022 13:48:04 +0000 (UTC) Received: from mm-prod-listman-01.mail-001.prod.us-east-1.aws.redhat.com (mm-prod-listman-01.mail-001.prod.us-east-1.aws.redhat.com [10.30.29.100]) by smtp.corp.redhat.com (Postfix) with ESMTP id 7728D2166B2B; Tue, 13 Dec 2022 13:48:03 +0000 (UTC) Received: from mm-prod-listman-01.mail-001.prod.us-east-1.aws.redhat.com (localhost [IPv6:::1]) by mm-prod-listman-01.mail-001.prod.us-east-1.aws.redhat.com (Postfix) with ESMTP id 45C191946588; Tue, 13 Dec 2022 13:47:58 +0000 (UTC) Received: from smtp.corp.redhat.com (int-mx04.intmail.prod.int.rdu2.redhat.com [10.11.54.4]) by mm-prod-listman-01.mail-001.prod.us-east-1.aws.redhat.com (Postfix) with ESMTP id DD6921946586 for ; Tue, 13 Dec 2022 13:47:48 +0000 (UTC) Received: by smtp.corp.redhat.com (Postfix) id 9CEF12026D76; Tue, 13 Dec 2022 13:47:43 +0000 (UTC) Received: from virval.usersys.redhat.com (unknown [10.43.2.227]) by smtp.corp.redhat.com (Postfix) with ESMTP id 5D65F2026D68 for ; Tue, 13 Dec 2022 13:47:43 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=redhat.com; s=mimecast20190719; t=1670939291; h=from:from:sender:sender:reply-to:subject:subject:date:date: message-id:message-id:to:to:cc:mime-version:mime-version: content-type:content-type: content-transfer-encoding:content-transfer-encoding:list-id:list-help: list-unsubscribe:list-subscribe:list-post; bh=hKWrH3uCuMSbNAwEOuPpfaGbPqwvgNSnB8u55Hq7rQk=; b=coMA0QnOGk2zBfq5q4Jt6vEpwTw/N+Gt/VONQKfbabDuFk0wFPMIwbMfnnCFs3GaAWHmol C/L839W+VpZdbsXoPDV6GOZasiuZoSv78jVkmTVt2lPqUxeGQvOV7KilrILPsBMod5owzA qzr0rPZBbngnAshzS1+Ks2fPtjyREk8= X-MC-Unique: rqw8D3uhN9uZCBN_lP_k3A-1 X-Original-To: libvir-list@listman.corp.redhat.com From: Jiri Denemark To: libvir-list@redhat.com Subject: [libvirt PATCH] qemu: Don't warn when releasing a released job Date: Tue, 13 Dec 2022 14:47:41 +0100 Message-Id: MIME-Version: 1.0 X-Scanned-By: MIMEDefang 3.1 on 10.11.54.4 X-BeenThere: libvir-list@redhat.com X-Mailman-Version: 2.1.29 Precedence: list List-Id: Development discussions about the libvirt library & tools List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: libvir-list-bounces@redhat.com Sender: "libvir-list" X-Scanned-By: MIMEDefang 3.1 on 10.11.54.6 X-Mimecast-Spam-Score: 0 X-Mimecast-Originator: redhat.com Content-Transfer-Encoding: quoted-printable X-ZohoMail-DKIM: pass (identity @redhat.com) X-ZM-MESSAGEID: 1670939294714100001 Content-Type: text/plain; charset="utf-8" When qemuDomainObjReleaseAsyncJob is called when the current async job is already released we emit quite useless warning which was implemented to warn about releasing a job owned by another thread. Signed-off-by: Jiri Denemark Reviewed-by: Peter Krempa --- src/qemu/qemu_domainjob.c | 3 ++- 1 file changed, 2 insertions(+), 1 deletion(-) diff --git a/src/qemu/qemu_domainjob.c b/src/qemu/qemu_domainjob.c index 4d320f075e..8d958b9d21 100644 --- a/src/qemu/qemu_domainjob.c +++ b/src/qemu/qemu_domainjob.c @@ -647,7 +647,8 @@ qemuDomainObjReleaseAsyncJob(virDomainObj *obj) VIR_DEBUG("Releasing ownership of '%s' async job", virDomainAsyncJobTypeToString(obj->job->asyncJob)); =20 - if (obj->job->asyncOwner !=3D virThreadSelfID()) { + if (obj->job->asyncOwner !=3D 0 && + obj->job->asyncOwner !=3D virThreadSelfID()) { VIR_WARN("'%s' async job is owned by thread %llu", virDomainAsyncJobTypeToString(obj->job->asyncJob), obj->job->asyncOwner); --=20 2.39.0