On 4/9/24 17:09, Michal Prívozník wrote:
> On 4/9/24 16:56, Cole Robinson wrote:
>> The virt-manager test suite is busted with libvirt 10.1.0+ after
>> this commit:
>>
>> commit e67bca23e4fe38a3491749f724b9edf743d0e916
>> Author: Boris Fiuczynski <fiuczy@linux.ibm.com>
>> Date: Thu Feb 22 14:02:01 2024 +0100
>>
>> nodedev: add an active config to mdev
>>
>> See patch #5 for the full explanation. First 4 patches are nodedev
>> test driver improvements I hit when debugging this
>>
>> v3:
>> really truly send to the correct list
>> v2:
>> Send to the correct mailing list
>> Fix version strings in test driver table
>>
>> Cole Robinson (5):
>> test: Fix `virsh nodedev-list`
>> test: Implement virNodeDeviceIsActive
>> test: Implement virNodeDeviceIsPersistent
>> test: make nodedevs active by default
>> conf: nodedev: Fill active_config at XML parse time
>>
>> src/conf/node_device_conf.c | 5 ++++-
>> src/test/test_driver.c | 35 ++++++++++++++++++++++++++++++++++-
>> tests/nodedevxml2xmltest.c | 15 ---------------
>> 3 files changed, 38 insertions(+), 17 deletions(-)
>>
>
> Reviewed-by: Michal Privoznik <mprivozn@redhat.com>
>
> But before pushing, also please add Boris' R-B as he also reviewed these
> patches.
>
> Michal
I agree and also gave my R-B to patches 1 to 3 with the same remarks as
Michael on patch 2 and 3.
I disagree with patches 4 and 5!
--
Mit freundlichen Grüßen/Kind regards
Boris Fiuczynski
IBM Deutschland Research & Development GmbH
Vorsitzender des Aufsichtsrats: Wolfgang Wendt
Geschäftsführung: David Faller
Sitz der Gesellschaft: Böblingen
Registergericht: Amtsgericht Stuttgart, HRB 243294
_______________________________________________
Devel mailing list -- devel@lists.libvirt.org
To unsubscribe send an email to devel-leave@lists.libvirt.org