virsh/virt-admin: Don't use virErrorRestore

[PATCH 0/4] virsh/virt-admin: Don't use virErrorRestore

Posted by Peter Krempa 4 months, 2 weeks ago

Client application shouldn't need to reset the error.

Peter Krempa (4):
  virshReconnect: Preserve current URI if not explicitly set in
    ctl->connname
  virshCatchDisconnect: Don't probe connection URI
  vshAdmConnect: Preserve connection URI in ctl->connname if
    auto-detected
  vshAdmCatchDisconnect: Don't probe connection URI

 tools/virsh.c      | 13 +++++--------
 tools/virt-admin.c | 11 ++++-------
 2 files changed, 9 insertions(+), 15 deletions(-)

-- 
2.43.0
_______________________________________________
Devel mailing list -- devel@lists.libvirt.org
To unsubscribe send an email to devel-leave@lists.libvirt.org

Re: [PATCH 0/4] virsh/virt-admin: Don't use virErrorRestore

Posted by Michal Prívozník 4 months, 2 weeks ago

On 12/14/23 17:56, Peter Krempa wrote:
> Client application shouldn't need to reset the error.
> 
> Peter Krempa (4):
>   virshReconnect: Preserve current URI if not explicitly set in
>     ctl->connname
>   virshCatchDisconnect: Don't probe connection URI
>   vshAdmConnect: Preserve connection URI in ctl->connname if
>     auto-detected
>   vshAdmCatchDisconnect: Don't probe connection URI
> 
>  tools/virsh.c      | 13 +++++--------
>  tools/virt-admin.c | 11 ++++-------
>  2 files changed, 9 insertions(+), 15 deletions(-)
> 

Reviewed-by: Michal Privoznik <mprivozn@redhat.com>

which also applies to 4/4 that was send just a minute ago (something
probably ate the original 4/4?).

Michal
_______________________________________________
Devel mailing list -- devel@lists.libvirt.org
To unsubscribe send an email to devel-leave@lists.libvirt.org