1. Patchew
  2. Libvirt
  3. View series

[PATCH 0/2] ci: Update to Fedora 39

Michal Privoznik posted 2 patches 4 months, 2 weeks ago
Patches applied successfully (tree, apply log)
git fetch https://github.com/patchew-project/libvirt tags/patchew/cover.1702542465.git.mprivozn@redhat.com
ci/buildenv/{alpine-317.sh => alpine-319.sh}  |  0
ci/buildenv/{fedora-37.sh => fedora-39.sh}    |  0
...e-317.Dockerfile => alpine-319.Dockerfile} |  2 +-
...ora-37.Dockerfile => fedora-39.Dockerfile} |  2 +-
ci/gitlab/builds.yml                          | 64 +++++++--------
ci/gitlab/containers.yml                      | 18 ++---
ci/integration.yml                            | 80 +++++++++----------
ci/manifest.yml                               | 18 ++---
8 files changed, 92 insertions(+), 92 deletions(-)
rename ci/buildenv/{alpine-317.sh => alpine-319.sh} (100%)
rename ci/buildenv/{fedora-37.sh => fedora-39.sh} (100%)
rename ci/containers/{alpine-317.Dockerfile => alpine-319.Dockerfile} (98%)
rename ci/containers/{fedora-37.Dockerfile => fedora-39.Dockerfile} (98%)
[PATCH 0/2] ci: Update to Fedora 39
Posted by Michal Privoznik 4 months, 2 weeks ago 
Green pipeline:

https://gitlab.com/MichalPrivoznik/libvirt/-/pipelines/1106643445

Michal Prívozník (2):
  ci: integration: Switch upstream integration tests to Fedora 39
  ci: Update Alpine and Fedora and regenerate

 ci/buildenv/{alpine-317.sh => alpine-319.sh}  |  0
 ci/buildenv/{fedora-37.sh => fedora-39.sh}    |  0
 ...e-317.Dockerfile => alpine-319.Dockerfile} |  2 +-
 ...ora-37.Dockerfile => fedora-39.Dockerfile} |  2 +-
 ci/gitlab/builds.yml                          | 64 +++++++--------
 ci/gitlab/containers.yml                      | 18 ++---
 ci/integration.yml                            | 80 +++++++++----------
 ci/manifest.yml                               | 18 ++---
 8 files changed, 92 insertions(+), 92 deletions(-)
 rename ci/buildenv/{alpine-317.sh => alpine-319.sh} (100%)
 rename ci/buildenv/{fedora-37.sh => fedora-39.sh} (100%)
 rename ci/containers/{alpine-317.Dockerfile => alpine-319.Dockerfile} (98%)
 rename ci/containers/{fedora-37.Dockerfile => fedora-39.Dockerfile} (98%)

-- 
2.41.0
_______________________________________________
Devel mailing list -- devel@lists.libvirt.org
To unsubscribe send an email to devel-leave@lists.libvirt.org
Re: [PATCH 0/2] ci: Update to Fedora 39
Posted by Peter Krempa 3 months, 3 weeks ago 
On Thu, Dec 14, 2023 at 09:28:15 +0100, Michal Privoznik wrote:
> Green pipeline:
> 
> https://gitlab.com/MichalPrivoznik/libvirt/-/pipelines/1106643445
> 
> Michal Prívozník (2):
>   ci: integration: Switch upstream integration tests to Fedora 39

For future reference, please note that the integration test suite makes
use of artifacts from libvirt/libvirt-perl and libvirt/libvirt-python
projects, which thus must be bumped to new Fedora prior to bumping the
main project.

I've approved and merged

https://gitlab.com/libvirt/libvirt-perl/-/merge_requests/109

and posted

https://gitlab.com/libvirt/libvirt-python/-/merge_requests/130

which will need to be approved.

This should fix the following integration test failure:

https://gitlab.com/libvirt/libvirt/-/jobs/5880074910
_______________________________________________
Devel mailing list -- devel@lists.libvirt.org
To unsubscribe send an email to devel-leave@lists.libvirt.org
Re: [PATCH 0/2] ci: Update to Fedora 39
Posted by Peter Krempa 3 months, 3 weeks ago 
On Mon, Jan 08, 2024 at 10:35:53 +0100, Peter Krempa wrote:
> On Thu, Dec 14, 2023 at 09:28:15 +0100, Michal Privoznik wrote:
> > Green pipeline:
> > 
> > https://gitlab.com/MichalPrivoznik/libvirt/-/pipelines/1106643445
> > 
> > Michal Prívozník (2):
> >   ci: integration: Switch upstream integration tests to Fedora 39
> 
> For future reference, please note that the integration test suite makes
> use of artifacts from libvirt/libvirt-perl and libvirt/libvirt-python
> projects, which thus must be bumped to new Fedora prior to bumping the
> main project.
> 
> I've approved and merged
> 
> https://gitlab.com/libvirt/libvirt-perl/-/merge_requests/109
> 
> and posted
> 
> https://gitlab.com/libvirt/libvirt-python/-/merge_requests/130
> 
> which will need to be approved.
> 
> This should fix the following integration test failure:
> 
> https://gitlab.com/libvirt/libvirt/-/jobs/5880074910

Grrr, this broke because debian-10 was dropped from lcitool and
libvirt-python doesn't build trivially neither in debian-11 nor in
debian-12.

I might check it later, but honestly got demotivated ...
_______________________________________________
Devel mailing list -- devel@lists.libvirt.org
To unsubscribe send an email to devel-leave@lists.libvirt.org
Re: [PATCH 0/2] ci: Update to Fedora 39
Posted by Daniel P. Berrangé 3 months, 3 weeks ago 
On Mon, Jan 08, 2024 at 10:48:58AM +0100, Peter Krempa wrote:
> On Mon, Jan 08, 2024 at 10:35:53 +0100, Peter Krempa wrote:
> > I've approved and merged
> > 
> > https://gitlab.com/libvirt/libvirt-perl/-/merge_requests/109
> > 
> > and posted
> > 
> > https://gitlab.com/libvirt/libvirt-python/-/merge_requests/130
> > 
> > which will need to be approved.
> > 
> > This should fix the following integration test failure:
> > 
> > https://gitlab.com/libvirt/libvirt/-/jobs/5880074910
> 
> Grrr, this broke because debian-10 was dropped from lcitool and
> libvirt-python doesn't build trivially neither in debian-11 nor in
> debian-12.
> 
> I might check it later, but honestly got demotivated ...

Yes, it is very frustrating when updating CI with lcitool when youj
want to update the version of one particlar distro, and lcitool forces
you to also replace a different distro, and the latter cause breakage
for some reason.  This has hit me time and time and time again.

IMHO it is time to change the policy for lcitool, such that we do
NOT remove old distro versions for *at least* 1 year.

This will give us flexibility to update individual distros without
having to do every distro in lockstep. It will let us debug problems
with certain new distros, without blocking updates of the rest of the
world.

With regards,
Daniel
-- 
|: https://berrange.com      -o-    https://www.flickr.com/photos/dberrange :|
|: https://libvirt.org         -o-            https://fstop138.berrange.com :|
|: https://entangle-photo.org    -o-    https://www.instagram.com/dberrange :|
_______________________________________________
Devel mailing list -- devel@lists.libvirt.org
To unsubscribe send an email to devel-leave@lists.libvirt.org
Re: [PATCH 0/2] ci: Update to Fedora 39
Posted by Peter Krempa 3 months, 3 weeks ago 
On Tue, Jan 09, 2024 at 11:41:17 +0000, Daniel P. Berrangé wrote:
> On Mon, Jan 08, 2024 at 10:48:58AM +0100, Peter Krempa wrote:
> > On Mon, Jan 08, 2024 at 10:35:53 +0100, Peter Krempa wrote:
> > > I've approved and merged
> > > 
> > > https://gitlab.com/libvirt/libvirt-perl/-/merge_requests/109
> > > 
> > > and posted
> > > 
> > > https://gitlab.com/libvirt/libvirt-python/-/merge_requests/130
> > > 
> > > which will need to be approved.
> > > 
> > > This should fix the following integration test failure:
> > > 
> > > https://gitlab.com/libvirt/libvirt/-/jobs/5880074910
> > 
> > Grrr, this broke because debian-10 was dropped from lcitool and
> > libvirt-python doesn't build trivially neither in debian-11 nor in
> > debian-12.
> > 
> > I might check it later, but honestly got demotivated ...
> 
> Yes, it is very frustrating when updating CI with lcitool when youj
> want to update the version of one particlar distro, and lcitool forces
> you to also replace a different distro, and the latter cause breakage
> for some reason.  This has hit me time and time and time again.
> 
> IMHO it is time to change the policy for lcitool, such that we do
> NOT remove old distro versions for *at least* 1 year.
> 
> This will give us flexibility to update individual distros without
> having to do every distro in lockstep. It will let us debug problems
> with certain new distros, without blocking updates of the rest of the
> world.

I'd suggest to flag the older distros which would be deleted with a flag
which will produce a warning, when regenerating the CI stuff.

It might be nice to notify that the distro is out of our support policy
but without forcing update.
_______________________________________________
Devel mailing list -- devel@lists.libvirt.org
To unsubscribe send an email to devel-leave@lists.libvirt.org
Re: [PATCH 0/2] ci: Update to Fedora 39
Posted by Daniel P. Berrangé 3 months, 3 weeks ago 
On Tue, Jan 09, 2024 at 01:12:35PM +0100, Peter Krempa wrote:
> On Tue, Jan 09, 2024 at 11:41:17 +0000, Daniel P. Berrangé wrote:
> > On Mon, Jan 08, 2024 at 10:48:58AM +0100, Peter Krempa wrote:
> > > On Mon, Jan 08, 2024 at 10:35:53 +0100, Peter Krempa wrote:
> > > > I've approved and merged
> > > > 
> > > > https://gitlab.com/libvirt/libvirt-perl/-/merge_requests/109
> > > > 
> > > > and posted
> > > > 
> > > > https://gitlab.com/libvirt/libvirt-python/-/merge_requests/130
> > > > 
> > > > which will need to be approved.
> > > > 
> > > > This should fix the following integration test failure:
> > > > 
> > > > https://gitlab.com/libvirt/libvirt/-/jobs/5880074910
> > > 
> > > Grrr, this broke because debian-10 was dropped from lcitool and
> > > libvirt-python doesn't build trivially neither in debian-11 nor in
> > > debian-12.
> > > 
> > > I might check it later, but honestly got demotivated ...
> > 
> > Yes, it is very frustrating when updating CI with lcitool when youj
> > want to update the version of one particlar distro, and lcitool forces
> > you to also replace a different distro, and the latter cause breakage
> > for some reason.  This has hit me time and time and time again.
> > 
> > IMHO it is time to change the policy for lcitool, such that we do
> > NOT remove old distro versions for *at least* 1 year.
> > 
> > This will give us flexibility to update individual distros without
> > having to do every distro in lockstep. It will let us debug problems
> > with certain new distros, without blocking updates of the rest of the
> > world.
> 
> I'd suggest to flag the older distros which would be deleted with a flag
> which will produce a warning, when regenerating the CI stuff.
> 
> It might be nice to notify that the distro is out of our support policy
> but without forcing update.

Yep, that's a good idea, as its nice if 'lcitool manifest' warns us
about outdated stuff.


With regards,
Daniel
-- 
|: https://berrange.com      -o-    https://www.flickr.com/photos/dberrange :|
|: https://libvirt.org         -o-            https://fstop138.berrange.com :|
|: https://entangle-photo.org    -o-    https://www.instagram.com/dberrange :|
_______________________________________________
Devel mailing list -- devel@lists.libvirt.org
To unsubscribe send an email to devel-leave@lists.libvirt.org
Re: Re: [PATCH 0/2] ci: Update to Fedora 39
Posted by Andrea Bolognani 3 months, 3 weeks ago 
On Tue, Jan 09, 2024 at 12:14:38PM +0000, Daniel P. Berrangé wrote:
> On Tue, Jan 09, 2024 at 01:12:35PM +0100, Peter Krempa wrote:
> > On Tue, Jan 09, 2024 at 11:41:17 +0000, Daniel P. Berrangé wrote:
> > > On Mon, Jan 08, 2024 at 10:48:58AM +0100, Peter Krempa wrote:
> > > > Grrr, this broke because debian-10 was dropped from lcitool and
> > > > libvirt-python doesn't build trivially neither in debian-11 nor in
> > > > debian-12.
> > > >
> > > > I might check it later, but honestly got demotivated ...
> > >
> > > Yes, it is very frustrating when updating CI with lcitool when youj
> > > want to update the version of one particlar distro, and lcitool forces
> > > you to also replace a different distro, and the latter cause breakage
> > > for some reason.  This has hit me time and time and time again.
> > >
> > > IMHO it is time to change the policy for lcitool, such that we do
> > > NOT remove old distro versions for *at least* 1 year.
> > >
> > > This will give us flexibility to update individual distros without
> > > having to do every distro in lockstep. It will let us debug problems
> > > with certain new distros, without blocking updates of the rest of the
> > > world.

Considering that we have stopped aggressively deleting mappings, this
feels like a natural next step. Let's just make sure that we don't
end up keeping everything around forever.

> > I'd suggest to flag the older distros which would be deleted with a flag
> > which will produce a warning, when regenerating the CI stuff.
> >
> > It might be nice to notify that the distro is out of our support policy
> > but without forcing update.
>
> Yep, that's a good idea, as its nice if 'lcitool manifest' warns us
> about outdated stuff.

Agreed.

-- 
Andrea Bolognani / Red Hat / Virtualization
_______________________________________________
Devel mailing list -- devel@lists.libvirt.org
To unsubscribe send an email to devel-leave@lists.libvirt.org
Re: Re: [PATCH 0/2] ci: Update to Fedora 39
Posted by Andrea Bolognani 3 months, 3 weeks ago 
On Mon, Jan 08, 2024 at 10:48:58AM +0100, Peter Krempa wrote:
> On Mon, Jan 08, 2024 at 10:35:53 +0100, Peter Krempa wrote:
> > On Thu, Dec 14, 2023 at 09:28:15 +0100, Michal Privoznik wrote:
> > > Green pipeline:
> > >
> > > https://gitlab.com/MichalPrivoznik/libvirt/-/pipelines/1106643445
> > >
> > > Michal Prívozník (2):
> > >   ci: integration: Switch upstream integration tests to Fedora 39
> >
> > For future reference, please note that the integration test suite makes
> > use of artifacts from libvirt/libvirt-perl and libvirt/libvirt-python
> > projects, which thus must be bumped to new Fedora prior to bumping the
> > main project.

Right. We keep forgetting that. I've just posted patches[1] that add
notes to the file, so hopefully that doesn't happen again.

> > I've approved and merged
> >
> > https://gitlab.com/libvirt/libvirt-perl/-/merge_requests/109
> >
> > and posted
> >
> > https://gitlab.com/libvirt/libvirt-python/-/merge_requests/130
> >
> > which will need to be approved.
> >
> > This should fix the following integration test failure:
> >
> > https://gitlab.com/libvirt/libvirt/-/jobs/5880074910
>
> Grrr, this broke because debian-10 was dropped from lcitool and
> libvirt-python doesn't build trivially neither in debian-11 nor in
> debian-12.

From a quick look, the problem seems to be related to the somewhat
recent change in Debian (and other distros? Or was it Python itself?)
where 'pip install' is disabled outside of venvs. IIRC lcitool has
been patched to work around it already.

> I might check it later, but honestly got demotivated ...

No, that's fair. I'll take a better look later today.


[1] https://lists.libvirt.org/archives/list/devel@lists.libvirt.org/thread/CKXFH6PIV2YXROYNJLA2OILTT6VN4V6U/
-- 
Andrea Bolognani / Red Hat / Virtualization
_______________________________________________
Devel mailing list -- devel@lists.libvirt.org
To unsubscribe send an email to devel-leave@lists.libvirt.org
Re: [PATCH 0/2] ci: Update to Fedora 39
Posted by Andrea Bolognani 3 months, 4 weeks ago 
On Thu, Dec 14, 2023 at 09:28:15AM +0100, Michal Privoznik wrote:
> Green pipeline:
>
> https://gitlab.com/MichalPrivoznik/libvirt/-/pipelines/1106643445
>
> Michal Prívozník (2):
>   ci: integration: Switch upstream integration tests to Fedora 39
>   ci: Update Alpine and Fedora and regenerate

Reviewed-by: Andrea Bolognani <abologna@redhat.com>

-- 
Andrea Bolognani / Red Hat / Virtualization
_______________________________________________
Devel mailing list -- devel@lists.libvirt.org
To unsubscribe send an email to devel-leave@lists.libvirt.org

Patchew 2.1-devel-0870f84

© 2016 - 2024 Red Hat, Inc.