A bunch of trivial fixes

[PATCH 0/4] A bunch of trivial fixes

Posted by Michal Privoznik 5 months ago

*** BLURB HERE ***

Michal Prívozník (4):
  virpci: Decrease scope of VIR_PF_PHYS_PORT_NAME_REGEX macro
  qemu_command: Don't open code virPCIDeviceAddressAsString()
  vircpi: Decrease scope of VIR_PCI_DEVICE_ADDRESS_FMT macro
  ch: Don't leak ch_driver->chCaps

 src/ch/ch_driver.c      | 5 +++--
 src/qemu/qemu_command.c | 6 +-----
 src/util/virpci.c       | 9 +++++++++
 src/util/virpci.h       | 7 -------
 4 files changed, 13 insertions(+), 14 deletions(-)

-- 
2.41.0
_______________________________________________
Devel mailing list -- devel@lists.libvirt.org
To unsubscribe send an email to devel-leave@lists.libvirt.org

Re: [PATCH 0/4] A bunch of trivial fixes

Posted by Ján Tomko 5 months ago

On a Tuesday in 2023, Michal Privoznik wrote:
>*** BLURB HERE ***
>
>Michal Prívozník (4):
>  virpci: Decrease scope of VIR_PF_PHYS_PORT_NAME_REGEX macro
>  qemu_command: Don't open code virPCIDeviceAddressAsString()
>  vircpi: Decrease scope of VIR_PCI_DEVICE_ADDRESS_FMT macro
>  ch: Don't leak ch_driver->chCaps
>
> src/ch/ch_driver.c      | 5 +++--
> src/qemu/qemu_command.c | 6 +-----
> src/util/virpci.c       | 9 +++++++++
> src/util/virpci.h       | 7 -------
> 4 files changed, 13 insertions(+), 14 deletions(-)
>

Reviewed-by: Ján Tomko <jtomko@redhat.com>

Also, patch 4/4 might be worth including in this release.

Jano
_______________________________________________
Devel mailing list -- devel@lists.libvirt.org
To unsubscribe send an email to devel-leave@lists.libvirt.org

Re: [PATCH 0/4] A bunch of trivial fixes

Posted by Jonathon Jongsma 5 months ago

On 11/28/23 9:59 AM, Michal Privoznik wrote:
> *** BLURB HERE ***
> 
> Michal Prívozník (4):
>    virpci: Decrease scope of VIR_PF_PHYS_PORT_NAME_REGEX macro
>    qemu_command: Don't open code virPCIDeviceAddressAsString()
>    vircpi: Decrease scope of VIR_PCI_DEVICE_ADDRESS_FMT macro
>    ch: Don't leak ch_driver->chCaps
> 
>   src/ch/ch_driver.c      | 5 +++--
>   src/qemu/qemu_command.c | 6 +-----
>   src/util/virpci.c       | 9 +++++++++
>   src/util/virpci.h       | 7 -------
>   4 files changed, 13 insertions(+), 14 deletions(-)
> 


Reviewed-by: Jonathon Jongsma <jjongsma@redhat.com>
_______________________________________________
Devel mailing list -- devel@lists.libvirt.org
To unsubscribe send an email to devel-leave@lists.libvirt.org