storage_file_probe: Handle qcow2 images with 'protocol' driver name in 'backing file format' field (part 1 - the fix)

[PATCH 0/7] storage_file_probe: Handle qcow2 images with 'protocol' driver name in 'backing file format' field (part 1 - the fix)

Peter Krempa posted 7 patches 5 months ago

Download series mbox

Failed in applying to current master (apply log)

src/storage_file/storage_file_probe.c         |  71 ++++++++----------
tests/virstoragetest.c                        |  19 ++++-
.../images/qcow2-protocol-backing-file.qcow2  | Bin 0 -> 196616 bytes
.../images/qcow2-protocol-backing-nbd.qcow2   | Bin 0 -> 196616 bytes
tests/virstoragetestdata/out/directory-dir    |   5 +-
tests/virstoragetestdata/out/directory-none   |   5 +-
tests/virstoragetestdata/out/directory-raw    |   5 +-
.../out/qcow2-auto_qcow2-qcow2_raw-raw        |   5 +-
.../out/qcow2-auto_raw-raw-relative           |   5 +-
.../out/qcow2-protocol-backing-file           |  21 ++++++
.../out/qcow2-protocol-backing-nbd            |  21 ++++++
.../out/qcow2-qcow2_nbd-raw                   |  10 ++-
.../out/qcow2-qcow2_qcow2-auto                |  10 ++-
.../out/qcow2-qcow2_qcow2-qcow2_qcow2-auto    |  15 ++--
.../out/qcow2-qcow2_qcow2-qcow2_raw-auto      |  15 ++--
.../out/qcow2-qcow2_qcow2-qcow2_raw-raw       |  15 ++--
.../out/qcow2-qcow2_raw-raw-relative          |  10 ++-
tests/virstoragetestdata/out/qcow2-symlinks   |  15 ++--
tests/virstoragetestdata/out/qed-auto_raw     |   5 +-
tests/virstoragetestdata/out/qed-qed_raw      |  10 ++-
tests/virstoragetestdata/out/raw-auto         |   5 +-
tests/virstoragetestdata/out/raw-raw          |   5 +-
22 files changed, 173 insertions(+), 99 deletions(-)
create mode 100644 tests/virstoragetestdata/images/qcow2-protocol-backing-file.qcow2
create mode 100644 tests/virstoragetestdata/images/qcow2-protocol-backing-nbd.qcow2
create mode 100644 tests/virstoragetestdata/out/qcow2-protocol-backing-file
create mode 100644 tests/virstoragetestdata/out/qcow2-protocol-backing-nbd

Expand all Fold all

[PATCH 0/7] storage_file_probe: Handle qcow2 images with 'protocol' driver name in 'backing file format' field (part 1 - the fix)

Posted by Peter Krempa 5 months ago

See 6/7 and 7/7 for the rationale. Further patches will be posted to
refactor the rest of the parsers which are bitrotten.

Peter Krempa (7):
  storage_file_probe: Remove unused state 'BACKING_STORE_ERROR'
  virStorageFileProbeGetMetadata: Do not partially skip probing of the
    image
  storage_file_probe: Remove BACKING_STORE_OK,BACKING_STORE_INVALID
    states
  virstoragetest: Use strings for storage type and format in output data
  virstoragetest: Format detected/unprocessed backing store format into
    output files
  virstoragetest: Add test cases for QCOW2 files with a protocol name as
    backing file format
  storage_file_probe: Treat qcow2 images with protocol drivers in
    backing store field as raw

 src/storage_file/storage_file_probe.c         |  71 ++++++++----------
 tests/virstoragetest.c                        |  19 ++++-
 .../images/qcow2-protocol-backing-file.qcow2  | Bin 0 -> 196616 bytes
 .../images/qcow2-protocol-backing-nbd.qcow2   | Bin 0 -> 196616 bytes
 tests/virstoragetestdata/out/directory-dir    |   5 +-
 tests/virstoragetestdata/out/directory-none   |   5 +-
 tests/virstoragetestdata/out/directory-raw    |   5 +-
 .../out/qcow2-auto_qcow2-qcow2_raw-raw        |   5 +-
 .../out/qcow2-auto_raw-raw-relative           |   5 +-
 .../out/qcow2-protocol-backing-file           |  21 ++++++
 .../out/qcow2-protocol-backing-nbd            |  21 ++++++
 .../out/qcow2-qcow2_nbd-raw                   |  10 ++-
 .../out/qcow2-qcow2_qcow2-auto                |  10 ++-
 .../out/qcow2-qcow2_qcow2-qcow2_qcow2-auto    |  15 ++--
 .../out/qcow2-qcow2_qcow2-qcow2_raw-auto      |  15 ++--
 .../out/qcow2-qcow2_qcow2-qcow2_raw-raw       |  15 ++--
 .../out/qcow2-qcow2_raw-raw-relative          |  10 ++-
 tests/virstoragetestdata/out/qcow2-symlinks   |  15 ++--
 tests/virstoragetestdata/out/qed-auto_raw     |   5 +-
 tests/virstoragetestdata/out/qed-qed_raw      |  10 ++-
 tests/virstoragetestdata/out/raw-auto         |   5 +-
 tests/virstoragetestdata/out/raw-raw          |   5 +-
 22 files changed, 173 insertions(+), 99 deletions(-)
 create mode 100644 tests/virstoragetestdata/images/qcow2-protocol-backing-file.qcow2
 create mode 100644 tests/virstoragetestdata/images/qcow2-protocol-backing-nbd.qcow2
 create mode 100644 tests/virstoragetestdata/out/qcow2-protocol-backing-file
 create mode 100644 tests/virstoragetestdata/out/qcow2-protocol-backing-nbd

-- 
2.42.0
_______________________________________________
Devel mailing list -- devel@lists.libvirt.org
To unsubscribe send an email to devel-leave@lists.libvirt.org

Re: [PATCH 0/7] storage_file_probe: Handle qcow2 images with 'protocol' driver name in 'backing file format' field (part 1 - the fix)

Posted by Ján Tomko 5 months ago

On a Friday in 2023, Peter Krempa wrote:
>See 6/7 and 7/7 for the rationale. Further patches will be posted to
>refactor the rest of the parsers which are bitrotten.
>
>Peter Krempa (7):
>  storage_file_probe: Remove unused state 'BACKING_STORE_ERROR'
>  virStorageFileProbeGetMetadata: Do not partially skip probing of the
>    image
>  storage_file_probe: Remove BACKING_STORE_OK,BACKING_STORE_INVALID
>    states
>  virstoragetest: Use strings for storage type and format in output data
>  virstoragetest: Format detected/unprocessed backing store format into
>    output files
>  virstoragetest: Add test cases for QCOW2 files with a protocol name as
>    backing file format
>  storage_file_probe: Treat qcow2 images with protocol drivers in
>    backing store field as raw
>
> src/storage_file/storage_file_probe.c         |  71 ++++++++----------
> tests/virstoragetest.c                        |  19 ++++-
> .../images/qcow2-protocol-backing-file.qcow2  | Bin 0 -> 196616 bytes
[...]
> tests/virstoragetestdata/out/raw-raw          |   5 +-
> 22 files changed, 173 insertions(+), 99 deletions(-)
> create mode 100644 tests/virstoragetestdata/images/qcow2-protocol-backing-file.qcow2
> create mode 100644 tests/virstoragetestdata/images/qcow2-protocol-backing-nbd.qcow2
> create mode 100644 tests/virstoragetestdata/out/qcow2-protocol-backing-file
> create mode 100644 tests/virstoragetestdata/out/qcow2-protocol-backing-nbd
>

Reviewed-by: Ján Tomko <jtomko@redhat.com>

Jano
_______________________________________________
Devel mailing list -- devel@lists.libvirt.org
To unsubscribe send an email to devel-leave@lists.libvirt.org