[PATCH 00/31] qemu: Add accessors for 'storage' and 'format' nodenames and refactor callers ('raw' driver removal part 1)

Peter Krempa posted 31 patches 6 months, 2 weeks ago
Patches applied successfully (tree, apply log)
git fetch https://github.com/patchew-project/libvirt tags/patchew/cover.1697468414.git.pkrempa@redhat.com
src/conf/storage_source_conf.c                |   8 +-
src/conf/storage_source_conf.h                |   4 +-
src/qemu/qemu_backup.c                        |   8 +-
src/qemu/qemu_block.c                         | 238 ++++++++++++------
src/qemu/qemu_block.h                         |  25 +-
src/qemu/qemu_blockjob.c                      |  24 +-
src/qemu/qemu_checkpoint.c                    |   9 +-
src/qemu/qemu_command.c                       |  12 +-
src/qemu/qemu_domain.c                        |  68 ++---
src/qemu/qemu_driver.c                        |  25 +-
src/qemu/qemu_migration.c                     |  17 +-
src/qemu/qemu_migration_cookie.c              |   5 +-
src/qemu/qemu_nbdkit.c                        |   4 +-
src/qemu/qemu_process.c                       |   2 +-
src/qemu/qemu_snapshot.c                      |   6 +-
tests/qemublocktest.c                         |  16 +-
tests/qemumonitorjsontest.c                   |   4 +-
.../blockjob-blockdev-in.xml                  |  12 +-
tests/qemuxml2argvtest.c                      |   3 +-
19 files changed, 314 insertions(+), 176 deletions(-)
[PATCH 00/31] qemu: Add accessors for 'storage' and 'format' nodenames and refactor callers ('raw' driver removal part 1)
Posted by Peter Krempa 6 months, 2 weeks ago
This is a prequel series necessary for removing the dummy 'raw' driver
node if it isn't needed for performance reasons.

Peter Krempa (31):
  qemu: domain: Identify blockjobs by storage nodename in VM status XML
  qemu: block: Refactor logic in qemuBlockStorageSourceGetBlockdevProps
  qemu: block: Rename qemuBlockStorageSourceGetBlockdevProps
  qemu: block: Add accessors for protocol/storage node names
  tests: Use 'storage' layer nodename accessors in tests
  qemuDomainVirStorageSourceFindByNodeName: Use proper accessor
  qemu: block: Use proper accessors for image formatting/creation code
  qemu: domain: Convert the status XML code for 'storage' nodenames to
    new accessors
  qemu: block: Convert disk 'storage' backend JSON props generator to
    new accessors
  qemu: domain: Rework assignment of 'storage' nodenames to use new
    accessors
  qemu: Refactor storage backend attach/detach setup code to use
    'storage' nodename accessors
  qemu: Refactor storage backend 'storage' layer helepr object setup
  qemuDomainGetStatsBlockExportDisk: Use 'storage' node name accessors
  qemuDomainSetBlockThreshold: Use 'storage' node name accessor
  conf: Rename 'nodestorage' field of virStorageSource to
    'nodenamestorage'
  qemu: block: Add accessors for format layer node names
  qemu: block: Add accessors for storage source effective nodename
  qemuBlockStorageSourceGetFormatProps: Use new frontend name accessor
  qemu: backup: Use format nodename accessors
  qemu: blockjob: Use 'format' nodename accessors for job naming
  qemu: block: Use 'format' nodename accessors in '-blockdev' setup code
  qemu: domain: Use 'format' layer node name accessors for nodename
    setup code
  tests: Use 'format' layer nodename accessors in test code
  qemu: Convert disk backend setup code to use 'format' nodename
    accessors
  qemu: driver: Convert disk stats code to use 'format' nodename
    accessors
  qemu: Use 'format' nodename accessors for block dirty bitmap
    operations
  qemu: command: Use 'format' nodename accessors for 'pflash' backend
    setup
  qemu: Convert migration setup code to use 'format' layer node name
    accessors
  qemu: migration: Use 'format' nodename accessors in dirty bitmap
    migration
  qemu: driver: Use 'format' nodename accessors for disk resize
  conf: Rename 'nodeformat' field of virStorageSource to
    'nodenameformat'

 src/conf/storage_source_conf.c                |   8 +-
 src/conf/storage_source_conf.h                |   4 +-
 src/qemu/qemu_backup.c                        |   8 +-
 src/qemu/qemu_block.c                         | 238 ++++++++++++------
 src/qemu/qemu_block.h                         |  25 +-
 src/qemu/qemu_blockjob.c                      |  24 +-
 src/qemu/qemu_checkpoint.c                    |   9 +-
 src/qemu/qemu_command.c                       |  12 +-
 src/qemu/qemu_domain.c                        |  68 ++---
 src/qemu/qemu_driver.c                        |  25 +-
 src/qemu/qemu_migration.c                     |  17 +-
 src/qemu/qemu_migration_cookie.c              |   5 +-
 src/qemu/qemu_nbdkit.c                        |   4 +-
 src/qemu/qemu_process.c                       |   2 +-
 src/qemu/qemu_snapshot.c                      |   6 +-
 tests/qemublocktest.c                         |  16 +-
 tests/qemumonitorjsontest.c                   |   4 +-
 .../blockjob-blockdev-in.xml                  |  12 +-
 tests/qemuxml2argvtest.c                      |   3 +-
 19 files changed, 314 insertions(+), 176 deletions(-)

-- 
2.41.0
Re: [PATCH 00/31] qemu: Add accessors for 'storage' and 'format' nodenames and refactor callers ('raw' driver removal part 1)
Posted by Ján Tomko 6 months, 2 weeks ago
On a Monday in 2023, Peter Krempa wrote:
>This is a prequel series necessary for removing the dummy 'raw' driver
>node if it isn't needed for performance reasons.
>
>Peter Krempa (31):
>  qemu: domain: Identify blockjobs by storage nodename in VM status XML
>  qemu: block: Refactor logic in qemuBlockStorageSourceGetBlockdevProps
>  qemu: block: Rename qemuBlockStorageSourceGetBlockdevProps
>  qemu: block: Add accessors for protocol/storage node names
>  tests: Use 'storage' layer nodename accessors in tests
>  qemuDomainVirStorageSourceFindByNodeName: Use proper accessor
>  qemu: block: Use proper accessors for image formatting/creation code
>  qemu: domain: Convert the status XML code for 'storage' nodenames to
>    new accessors
>  qemu: block: Convert disk 'storage' backend JSON props generator to
>    new accessors
>  qemu: domain: Rework assignment of 'storage' nodenames to use new
>    accessors
>  qemu: Refactor storage backend attach/detach setup code to use
>    'storage' nodename accessors
>  qemu: Refactor storage backend 'storage' layer helepr object setup
>  qemuDomainGetStatsBlockExportDisk: Use 'storage' node name accessors
>  qemuDomainSetBlockThreshold: Use 'storage' node name accessor
>  conf: Rename 'nodestorage' field of virStorageSource to
>    'nodenamestorage'
>  qemu: block: Add accessors for format layer node names
>  qemu: block: Add accessors for storage source effective nodename
>  qemuBlockStorageSourceGetFormatProps: Use new frontend name accessor
>  qemu: backup: Use format nodename accessors
>  qemu: blockjob: Use 'format' nodename accessors for job naming
>  qemu: block: Use 'format' nodename accessors in '-blockdev' setup code
>  qemu: domain: Use 'format' layer node name accessors for nodename
>    setup code
>  tests: Use 'format' layer nodename accessors in test code
>  qemu: Convert disk backend setup code to use 'format' nodename
>    accessors
>  qemu: driver: Convert disk stats code to use 'format' nodename
>    accessors
>  qemu: Use 'format' nodename accessors for block dirty bitmap
>    operations
>  qemu: command: Use 'format' nodename accessors for 'pflash' backend
>    setup
>  qemu: Convert migration setup code to use 'format' layer node name
>    accessors
>  qemu: migration: Use 'format' nodename accessors in dirty bitmap
>    migration
>  qemu: driver: Use 'format' nodename accessors for disk resize
>  conf: Rename 'nodeformat' field of virStorageSource to
>    'nodenameformat'
>
> src/conf/storage_source_conf.c                |   8 +-
> src/conf/storage_source_conf.h                |   4 +-
> src/qemu/qemu_backup.c                        |   8 +-
> src/qemu/qemu_block.c                         | 238 ++++++++++++------
> src/qemu/qemu_block.h                         |  25 +-
> src/qemu/qemu_blockjob.c                      |  24 +-
> src/qemu/qemu_checkpoint.c                    |   9 +-
> src/qemu/qemu_command.c                       |  12 +-
> src/qemu/qemu_domain.c                        |  68 ++---
> src/qemu/qemu_driver.c                        |  25 +-
> src/qemu/qemu_migration.c                     |  17 +-
> src/qemu/qemu_migration_cookie.c              |   5 +-
> src/qemu/qemu_nbdkit.c                        |   4 +-
> src/qemu/qemu_process.c                       |   2 +-
> src/qemu/qemu_snapshot.c                      |   6 +-
> tests/qemublocktest.c                         |  16 +-
> tests/qemumonitorjsontest.c                   |   4 +-
> .../blockjob-blockdev-in.xml                  |  12 +-
> tests/qemuxml2argvtest.c                      |   3 +-
> 19 files changed, 314 insertions(+), 176 deletions(-)
>

Reviewed-by: Ján Tomko <jtomko@redhat.com>

Jano