From nobody Fri May 10 06:40:01 2024 Delivered-To: importer@patchew.org Received-SPF: pass (zohomail.com: domain of redhat.com designates 170.10.129.124 as permitted sender) client-ip=170.10.129.124; envelope-from=libvir-list-bounces@redhat.com; helo=us-smtp-delivery-124.mimecast.com; Authentication-Results: mx.zohomail.com; dkim=pass; spf=pass (zohomail.com: domain of redhat.com designates 170.10.129.124 as permitted sender) smtp.mailfrom=libvir-list-bounces@redhat.com; dmarc=pass(p=none dis=none) header.from=redhat.com ARC-Seal: i=1; a=rsa-sha256; t=1694440361; cv=none; d=zohomail.com; s=zohoarc; b=iuYuPArVc5wxtDEwm/NYddQXyPV2zYvJOxryvJeqwjRyITjF74ofHR0CbzAJcli1QoSyHyj0MN5G5OmS5eMTrf9czVLdf10SUGNz49vzvH530hsz13+H/GjVQYGq8OXXA5z2O1NMNIQF0EAl1GwShze5TBZWuHsC+Kd0Si35LhU= ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=zohomail.com; s=zohoarc; t=1694440361; h=Content-Type:Content-Transfer-Encoding:Date:From:In-Reply-To:List-Subscribe:List-Post:List-Id:List-Archive:List-Help:List-Unsubscribe:MIME-Version:Message-ID:References:Sender:Subject:To; bh=IRxukKwj38ZFQxoBkxsTsUXs+YLpMpG5r3FSRD1pkUU=; b=k5xcEOecdNeGLTbHwTLPvEsSZaFDAaxZ2aGQIDGEoa6FzgEGTm1taCGpzDKXsPsEbft21y3J80/ajrHi75WB8+SSz23tvmhpy+BXHM+cVL8H1XHP/NMk7aKNoloD9W0Xk4qUrIfqXxYHgBUKF7PhK1g1y466EwVpcFgQnAeqIOw= ARC-Authentication-Results: i=1; mx.zohomail.com; dkim=pass; spf=pass (zohomail.com: domain of redhat.com designates 170.10.129.124 as permitted sender) smtp.mailfrom=libvir-list-bounces@redhat.com; dmarc=pass header.from= (p=none dis=none) Return-Path: Received: from us-smtp-delivery-124.mimecast.com (us-smtp-delivery-124.mimecast.com [170.10.129.124]) by mx.zohomail.com with SMTPS id 169444036108759.86838984384201; Mon, 11 Sep 2023 06:52:41 -0700 (PDT) Received: from mimecast-mx02.redhat.com (mx-ext.redhat.com [66.187.233.73]) by relay.mimecast.com with ESMTP with STARTTLS (version=TLSv1.2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id us-mta-147-cinLSmbtOqaE522S2DNRVA-1; Mon, 11 Sep 2023 09:52:34 -0400 Received: from smtp.corp.redhat.com (int-mx02.intmail.prod.int.rdu2.redhat.com [10.11.54.2]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by mimecast-mx02.redhat.com (Postfix) with ESMTPS id ACFC31C18C6A; Mon, 11 Sep 2023 13:52:31 +0000 (UTC) Received: from mm-prod-listman-01.mail-001.prod.us-east-1.aws.redhat.com (mm-prod-listman-01.mail-001.prod.us-east-1.aws.redhat.com [10.30.29.100]) by smtp.corp.redhat.com (Postfix) with ESMTP id 9739940C6EC0; Mon, 11 Sep 2023 13:52:31 +0000 (UTC) Received: from mm-prod-listman-01.mail-001.prod.us-east-1.aws.redhat.com (localhost [IPv6:::1]) by mm-prod-listman-01.mail-001.prod.us-east-1.aws.redhat.com (Postfix) with ESMTP id 94F4319465BB; Mon, 11 Sep 2023 13:52:30 +0000 (UTC) Received: from smtp.corp.redhat.com (int-mx03.intmail.prod.int.rdu2.redhat.com [10.11.54.3]) by mm-prod-listman-01.mail-001.prod.us-east-1.aws.redhat.com (Postfix) with ESMTP id 2BBF51946597 for ; Mon, 11 Sep 2023 13:52:29 +0000 (UTC) Received: by smtp.corp.redhat.com (Postfix) id 0DA6C10F1BE7; Mon, 11 Sep 2023 13:52:29 +0000 (UTC) Received: from fedora.. (unknown [10.43.2.118]) by smtp.corp.redhat.com (Postfix) with ESMTP id A8DBA10005D2 for ; Mon, 11 Sep 2023 13:52:28 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=redhat.com; s=mimecast20190719; t=1694440360; h=from:from:sender:sender:reply-to:subject:subject:date:date: message-id:message-id:to:to:cc:mime-version:mime-version: content-type:content-type: content-transfer-encoding:content-transfer-encoding: in-reply-to:in-reply-to:references:references:list-id:list-help: list-unsubscribe:list-subscribe:list-post; bh=IRxukKwj38ZFQxoBkxsTsUXs+YLpMpG5r3FSRD1pkUU=; b=SLxTTbVY9LNBs3vTSQmvK2yrBSFpm+us41Fy7z1p3K7JHknrQwLCI0LyL0zcR3dWGizhoC yRfTKPQsEs8agX5AmQI4XyIsdsizaZIckrFX+wpxczYr8VfGPhISPepQsZaudBFxfqVqco A8sdNvVd29kkbcRL+Tr0Z7JjsClRk9o= X-MC-Unique: cinLSmbtOqaE522S2DNRVA-1 X-Original-To: libvir-list@listman.corp.redhat.com From: =?UTF-8?q?J=C3=A1n=20Tomko?= To: libvir-list@redhat.com Subject: [libvirt PATCHv1 1/8] qemu: fix indentation Date: Mon, 11 Sep 2023 15:51:21 +0200 Message-ID: <7e010d653f78e7ce84b44f6dad8236c461ca2602.1694440288.git.jtomko@redhat.com> In-Reply-To: References: MIME-Version: 1.0 X-Scanned-By: MIMEDefang 3.1 on 10.11.54.3 X-BeenThere: libvir-list@redhat.com X-Mailman-Version: 2.1.29 Precedence: list List-Id: Development discussions about the libvirt library & tools List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: libvir-list-bounces@redhat.com Sender: "libvir-list" X-Scanned-By: MIMEDefang 3.1 on 10.11.54.2 X-Mimecast-Spam-Score: 0 X-Mimecast-Originator: redhat.com Content-Type: text/plain; charset="utf-8" Content-Transfer-Encoding: quoted-printable X-ZohoMail-DKIM: pass (identity @redhat.com) X-ZM-MESSAGEID: 1694440394640100001 Signed-off-by: J=C3=A1n Tomko --- src/qemu/qemu_validate.c | 24 ++++++++++++------------ 1 file changed, 12 insertions(+), 12 deletions(-) diff --git a/src/qemu/qemu_validate.c b/src/qemu/qemu_validate.c index 1346bbfb44..e3c34eca3d 100644 --- a/src/qemu/qemu_validate.c +++ b/src/qemu/qemu_validate.c @@ -4282,24 +4282,24 @@ qemuValidateDomainDeviceDefFS(virDomainFSDef *fs, case VIR_DOMAIN_FS_DRIVER_TYPE_VIRTIOFS: if (!fs->sock) { if (fs->readonly) { - virReportError(VIR_ERR_CONFIG_UNSUPPORTED, "%s", - _("virtiofs does not yet support read-only mode= ")); - return -1; + virReportError(VIR_ERR_CONFIG_UNSUPPORTED, "%s", + _("virtiofs does not yet support read-only = mode")); + return -1; } if (!driver->privileged) { - virReportError(VIR_ERR_CONFIG_UNSUPPORTED, "%s", - _("virtiofs is not yet supported in session mod= e")); - return -1; + virReportError(VIR_ERR_CONFIG_UNSUPPORTED, "%s", + _("virtiofs is not yet supported in session= mode")); + return -1; } if (fs->accessmode !=3D VIR_DOMAIN_FS_ACCESSMODE_PASSTHROUGH) { - virReportError(VIR_ERR_CONFIG_UNSUPPORTED, "%s", - _("virtiofs only supports passthrough accessmod= e")); - return -1; + virReportError(VIR_ERR_CONFIG_UNSUPPORTED, "%s", + _("virtiofs only supports passthrough acces= smode")); + return -1; } if (fs->wrpolicy !=3D VIR_DOMAIN_FS_WRPOLICY_DEFAULT) { - virReportError(VIR_ERR_CONFIG_UNSUPPORTED, "%s", - _("virtiofs does not support wrpolicy")); - return -1; + virReportError(VIR_ERR_CONFIG_UNSUPPORTED, "%s", + _("virtiofs does not support wrpolicy")); + return -1; } } =20 --=20 2.41.0 From nobody Fri May 10 06:40:01 2024 Delivered-To: importer@patchew.org Received-SPF: pass (zohomail.com: domain of redhat.com designates 170.10.133.124 as permitted sender) client-ip=170.10.133.124; envelope-from=libvir-list-bounces@redhat.com; helo=us-smtp-delivery-124.mimecast.com; Authentication-Results: mx.zohomail.com; dkim=pass; spf=pass (zohomail.com: domain of redhat.com designates 170.10.133.124 as permitted sender) smtp.mailfrom=libvir-list-bounces@redhat.com; dmarc=pass(p=none dis=none) header.from=redhat.com ARC-Seal: i=1; a=rsa-sha256; t=1694440358; cv=none; d=zohomail.com; s=zohoarc; b=bs1vPLamGbIhYDpVodNrVHBq/3kAFqJy84kIjpwBrVomTZNmwSvzNPiAP5Nyeqn1lYbPMwSkJOcuYVETXkoJyBUoMwc9nPsjcex4WT1Fh0UFBA8nH99dN7Skn8aLAQA3fv3bN5C+cbsqFGxeF7lUpynK0RrUupYkuK8jIFUtRc4= ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=zohomail.com; s=zohoarc; t=1694440358; h=Content-Type:Content-Transfer-Encoding:Date:From:In-Reply-To:List-Subscribe:List-Post:List-Id:List-Archive:List-Help:List-Unsubscribe:MIME-Version:Message-ID:References:Sender:Subject:To; bh=Icw+GmGWSwbs/Puo2aOv1M+2Rb4+FTZ7Je7ss5po/r8=; b=gBe+9rbL+L68j150Fc/ZDiTZIlFXJC/fzq2OxmwISw7ANHQkDL5rqaZsHJsFs7x0j+FUkAVndNGW8ScQNvlN59WMZmWnl+kSq7EHXP4wVdpa6VhSJwUeKWOdoHepMix/rozOcwTL9mtZh3xtUSJVrW+0ydp3HhEZVdPamGU4ynI= ARC-Authentication-Results: i=1; mx.zohomail.com; dkim=pass; spf=pass (zohomail.com: domain of redhat.com designates 170.10.133.124 as permitted sender) smtp.mailfrom=libvir-list-bounces@redhat.com; dmarc=pass header.from= (p=none dis=none) Return-Path: Received: from us-smtp-delivery-124.mimecast.com (us-smtp-delivery-124.mimecast.com [170.10.133.124]) by mx.zohomail.com with SMTPS id 1694440358323845.9980878752947; Mon, 11 Sep 2023 06:52:38 -0700 (PDT) Received: from mimecast-mx02.redhat.com (mimecast-mx02.redhat.com [66.187.233.88]) by relay.mimecast.com with ESMTP with STARTTLS (version=TLSv1.2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id us-mta-52-VG_3DRpmODmibTiz2hKWWQ-1; Mon, 11 Sep 2023 09:52:35 -0400 Received: from smtp.corp.redhat.com (int-mx04.intmail.prod.int.rdu2.redhat.com [10.11.54.4]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by mimecast-mx02.redhat.com (Postfix) with ESMTPS id 1A5B88F8763; Mon, 11 Sep 2023 13:52:32 +0000 (UTC) Received: from mm-prod-listman-01.mail-001.prod.us-east-1.aws.redhat.com (mm-prod-listman-01.mail-001.prod.us-east-1.aws.redhat.com [10.30.29.100]) by smtp.corp.redhat.com (Postfix) with ESMTP id 003692026D4B; Mon, 11 Sep 2023 13:52:31 +0000 (UTC) Received: from mm-prod-listman-01.mail-001.prod.us-east-1.aws.redhat.com (localhost [IPv6:::1]) by mm-prod-listman-01.mail-001.prod.us-east-1.aws.redhat.com (Postfix) with ESMTP id CD2801946A4B; Mon, 11 Sep 2023 13:52:30 +0000 (UTC) Received: from smtp.corp.redhat.com (int-mx03.intmail.prod.int.rdu2.redhat.com [10.11.54.3]) by mm-prod-listman-01.mail-001.prod.us-east-1.aws.redhat.com (Postfix) with ESMTP id BCA831946597 for ; Mon, 11 Sep 2023 13:52:29 +0000 (UTC) Received: by smtp.corp.redhat.com (Postfix) id 9D7A610005D2; Mon, 11 Sep 2023 13:52:29 +0000 (UTC) Received: from fedora.. (unknown [10.43.2.118]) by smtp.corp.redhat.com (Postfix) with ESMTP id 4500810F1BE7 for ; Mon, 11 Sep 2023 13:52:29 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=redhat.com; s=mimecast20190719; t=1694440357; h=from:from:sender:sender:reply-to:subject:subject:date:date: message-id:message-id:to:to:cc:mime-version:mime-version: content-type:content-type: content-transfer-encoding:content-transfer-encoding: in-reply-to:in-reply-to:references:references:list-id:list-help: list-unsubscribe:list-subscribe:list-post; bh=Icw+GmGWSwbs/Puo2aOv1M+2Rb4+FTZ7Je7ss5po/r8=; b=UJ0qjveFKF3HTM10kC39cJFZh42nsstSdb0TM6WzwR7bR4Xix/cddXEU4EKGLPut4Rsvs6 oCS9Sd4hslGdueDXwE3orj2sRaMJrWZ3U0QsnvxAmhFP/nL7NtgOuNytATSGdB4Nkt6rvG G7PSPtp102KWdBM7Tv0myX46KMUGQYE= X-MC-Unique: VG_3DRpmODmibTiz2hKWWQ-1 X-Original-To: libvir-list@listman.corp.redhat.com From: =?UTF-8?q?J=C3=A1n=20Tomko?= To: libvir-list@redhat.com Subject: [libvirt PATCHv1 2/8] conf: move idmap definition earlier Date: Mon, 11 Sep 2023 15:51:22 +0200 Message-ID: <0bfee163f95f5bab8e21c1687313bc9e0d7fd01b.1694440288.git.jtomko@redhat.com> In-Reply-To: References: MIME-Version: 1.0 X-Scanned-By: MIMEDefang 3.1 on 10.11.54.3 X-BeenThere: libvir-list@redhat.com X-Mailman-Version: 2.1.29 Precedence: list List-Id: Development discussions about the libvirt library & tools List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: libvir-list-bounces@redhat.com Sender: "libvir-list" X-Scanned-By: MIMEDefang 3.1 on 10.11.54.4 X-Mimecast-Spam-Score: 0 X-Mimecast-Originator: redhat.com Content-Type: text/plain; charset="utf-8" Content-Transfer-Encoding: quoted-printable X-ZohoMail-DKIM: pass (identity @redhat.com) X-ZM-MESSAGEID: 1694440397652100001 Signed-off-by: J=C3=A1n Tomko --- src/conf/domain_conf.h | 28 ++++++++++++++-------------- 1 file changed, 14 insertions(+), 14 deletions(-) diff --git a/src/conf/domain_conf.h b/src/conf/domain_conf.h index ca195a52d2..8937968e3b 100644 --- a/src/conf/domain_conf.h +++ b/src/conf/domain_conf.h @@ -802,6 +802,20 @@ struct _virDomainControllerDef { virDomainVirtioOptions *virtio; }; =20 +struct _virDomainIdMapEntry { + unsigned int start; + unsigned int target; + unsigned int count; +}; + +struct _virDomainIdMapDef { + size_t nuidmap; + virDomainIdMapEntry *uidmap; + + size_t ngidmap; + virDomainIdMapEntry *gidmap; +}; + =20 /* Types of disk backends */ typedef enum { @@ -2695,20 +2709,6 @@ virDomainMemoryDef *virDomainMemoryDefNew(virDomainM= emoryModel model); void virDomainMemoryDefFree(virDomainMemoryDef *def); G_DEFINE_AUTOPTR_CLEANUP_FUNC(virDomainMemoryDef, virDomainMemoryDefFree); =20 -struct _virDomainIdMapEntry { - unsigned int start; - unsigned int target; - unsigned int count; -}; - -struct _virDomainIdMapDef { - size_t nuidmap; - virDomainIdMapEntry *uidmap; - - size_t ngidmap; - virDomainIdMapEntry *gidmap; -}; - =20 typedef enum { VIR_DOMAIN_PANIC_MODEL_DEFAULT, --=20 2.41.0 From nobody Fri May 10 06:40:01 2024 Delivered-To: importer@patchew.org Received-SPF: pass (zohomail.com: domain of redhat.com designates 170.10.129.124 as permitted sender) client-ip=170.10.129.124; envelope-from=libvir-list-bounces@redhat.com; helo=us-smtp-delivery-124.mimecast.com; Authentication-Results: mx.zohomail.com; dkim=pass; spf=pass (zohomail.com: domain of redhat.com designates 170.10.129.124 as permitted sender) smtp.mailfrom=libvir-list-bounces@redhat.com; dmarc=pass(p=none dis=none) header.from=redhat.com ARC-Seal: i=1; a=rsa-sha256; t=1694440487; cv=none; d=zohomail.com; s=zohoarc; b=cqwedR6MA3NgkKhRBKwRR3EeO8pg/K+97+VLRR1FQHY+I+7l4J8WfSs1WJhYF0jMfdJX+kT3kIPKszzzHg73/rOfaQhRu0/5Kf9yfwL//bLhorJCPhDA+rkX9t0JEK+vJWIrtETDC0pBADT+8Hb5w/h96gzD6zHC1qmLidOTB2o= ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=zohomail.com; s=zohoarc; t=1694440487; h=Content-Type:Content-Transfer-Encoding:Date:From:In-Reply-To:List-Subscribe:List-Post:List-Id:List-Archive:List-Help:List-Unsubscribe:MIME-Version:Message-ID:References:Sender:Subject:To; bh=L/kDh95e5MBzb3BY0xfYsUsPUrcKjk1VJdpOBGh8HQw=; b=QvXLO7dN9IEn+Nl7dxiAcd0ZkFWvKwikQLKPXm2+yh6dQSrTYHiVDAG7BL12OrqS78hcfHrJ+grOHGfXVzofpYYXqihwW956jJjEMxUANzv2nssmmMyFjwiugApBx19fq7YehToA7EdPw/BNCtpTELGbdfpfhLLIRH+YAJGiZl4= ARC-Authentication-Results: i=1; mx.zohomail.com; dkim=pass; spf=pass (zohomail.com: domain of redhat.com designates 170.10.129.124 as permitted sender) smtp.mailfrom=libvir-list-bounces@redhat.com; dmarc=pass header.from= (p=none dis=none) Return-Path: Received: from us-smtp-delivery-124.mimecast.com (us-smtp-delivery-124.mimecast.com [170.10.129.124]) by mx.zohomail.com with SMTPS id 1694440487842570.6052639468348; Mon, 11 Sep 2023 06:54:47 -0700 (PDT) Received: from mimecast-mx02.redhat.com (mx-ext.redhat.com [66.187.233.73]) by relay.mimecast.com with ESMTP with STARTTLS (version=TLSv1.2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id us-mta-255-blkUOZg8PT-izlJwP2Y_7A-1; Mon, 11 Sep 2023 09:52:35 -0400 Received: from smtp.corp.redhat.com (int-mx06.intmail.prod.int.rdu2.redhat.com [10.11.54.6]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by mimecast-mx02.redhat.com (Postfix) with ESMTPS id 83EA73815F00; Mon, 11 Sep 2023 13:52:32 +0000 (UTC) Received: from mm-prod-listman-01.mail-001.prod.us-east-1.aws.redhat.com (mm-prod-listman-01.mail-001.prod.us-east-1.aws.redhat.com [10.30.29.100]) by smtp.corp.redhat.com (Postfix) with ESMTP id 6E4F421B2413; Mon, 11 Sep 2023 13:52:32 +0000 (UTC) Received: from mm-prod-listman-01.mail-001.prod.us-east-1.aws.redhat.com (localhost [IPv6:::1]) by mm-prod-listman-01.mail-001.prod.us-east-1.aws.redhat.com (Postfix) with ESMTP id 147CA19465B3; Mon, 11 Sep 2023 13:52:32 +0000 (UTC) Received: from smtp.corp.redhat.com (int-mx03.intmail.prod.int.rdu2.redhat.com [10.11.54.3]) by mm-prod-listman-01.mail-001.prod.us-east-1.aws.redhat.com (Postfix) with ESMTP id 5B7F619465A2 for ; Mon, 11 Sep 2023 13:52:30 +0000 (UTC) Received: by smtp.corp.redhat.com (Postfix) id 3A0BD1006B56; Mon, 11 Sep 2023 13:52:30 +0000 (UTC) Received: from fedora.. (unknown [10.43.2.118]) by smtp.corp.redhat.com (Postfix) with ESMTP id D55C610F1BE8 for ; Mon, 11 Sep 2023 13:52:29 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=redhat.com; s=mimecast20190719; t=1694440486; h=from:from:sender:sender:reply-to:subject:subject:date:date: message-id:message-id:to:to:cc:mime-version:mime-version: content-type:content-type: content-transfer-encoding:content-transfer-encoding: in-reply-to:in-reply-to:references:references:list-id:list-help: list-unsubscribe:list-subscribe:list-post; bh=L/kDh95e5MBzb3BY0xfYsUsPUrcKjk1VJdpOBGh8HQw=; b=HvkP+uYeKlgDWW9+Uo7dEUCTLFaM61Jp+8Wk9iz90a9UbvGWGCNwk0HuVJjkGuKrkEK89j ORTQHpt5PG3stZ1m7waAsTx4bRTsobs4RIMSROcpWTcO8YxfNkOGslOMe9MdYBwsDWtSF/ DV9sZM5c1552y9+7wJCyzxj9u5cYKk0= X-MC-Unique: blkUOZg8PT-izlJwP2Y_7A-1 X-Original-To: libvir-list@listman.corp.redhat.com From: =?UTF-8?q?J=C3=A1n=20Tomko?= To: libvir-list@redhat.com Subject: [libvirt PATCHv1 3/8] conf: move idmap parsing earlier Date: Mon, 11 Sep 2023 15:51:23 +0200 Message-ID: <2e68dabe3777c95215755eed6a0477a6a79f8aed.1694440288.git.jtomko@redhat.com> In-Reply-To: References: MIME-Version: 1.0 X-Scanned-By: MIMEDefang 3.1 on 10.11.54.3 X-BeenThere: libvir-list@redhat.com X-Mailman-Version: 2.1.29 Precedence: list List-Id: Development discussions about the libvirt library & tools List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: libvir-list-bounces@redhat.com Sender: "libvir-list" X-Scanned-By: MIMEDefang 3.1 on 10.11.54.6 X-Mimecast-Spam-Score: 0 X-Mimecast-Originator: redhat.com Content-Type: text/plain; charset="utf-8" Content-Transfer-Encoding: quoted-printable X-ZohoMail-DKIM: pass (identity @redhat.com) X-ZM-MESSAGEID: 1694440490114100001 Signed-off-by: J=C3=A1n Tomko --- src/conf/domain_conf.c | 98 +++++++++++++++++++++--------------------- 1 file changed, 49 insertions(+), 49 deletions(-) diff --git a/src/conf/domain_conf.c b/src/conf/domain_conf.c index 2c8727de54..dd67e7f21b 100644 --- a/src/conf/domain_conf.c +++ b/src/conf/domain_conf.c @@ -8581,6 +8581,55 @@ virDomainNetGenerateMAC(virDomainXMLOption *xmlopt, } =20 =20 +static int virDomainIdMapEntrySort(const void *a, const void *b) +{ + const virDomainIdMapEntry *entrya =3D a; + const virDomainIdMapEntry *entryb =3D b; + + if (entrya->start > entryb->start) + return 1; + else if (entrya->start < entryb->start) + return -1; + else + return 0; +} + +/* Parse the XML definition for user namespace id map. + * + * idmap has the form of + * + * + * + */ +static virDomainIdMapEntry * +virDomainIdmapDefParseXML(xmlXPathContextPtr ctxt, + xmlNodePtr *node, + size_t num) +{ + size_t i; + virDomainIdMapEntry *idmap =3D NULL; + VIR_XPATH_NODE_AUTORESTORE(ctxt) + + idmap =3D g_new0(virDomainIdMapEntry, num); + + for (i =3D 0; i < num; i++) { + ctxt->node =3D node[i]; + if (virXPathUInt("string(./@start)", ctxt, &idmap[i].start) < 0 || + virXPathUInt("string(./@target)", ctxt, &idmap[i].target) < 0 = || + virXPathUInt("string(./@count)", ctxt, &idmap[i].count) < 0) { + virReportError(VIR_ERR_XML_ERROR, "%s", + _("invalid idmap start/target/count settings")); + VIR_FREE(idmap); + return NULL; + } + } + + qsort(idmap, num, sizeof(idmap[0]), virDomainIdMapEntrySort); + + return idmap; +} + + static virDomainFSDef * virDomainFSDefParseXML(virDomainXMLOption *xmlopt, xmlNodePtr node, @@ -15711,55 +15760,6 @@ virDomainDefParseBootXML(xmlXPathContextPtr ctxt, return 0; } =20 - -static int virDomainIdMapEntrySort(const void *a, const void *b) -{ - const virDomainIdMapEntry *entrya =3D a; - const virDomainIdMapEntry *entryb =3D b; - - if (entrya->start > entryb->start) - return 1; - else if (entrya->start < entryb->start) - return -1; - else - return 0; -} - -/* Parse the XML definition for user namespace id map. - * - * idmap has the form of - * - * - * - */ -static virDomainIdMapEntry * -virDomainIdmapDefParseXML(xmlXPathContextPtr ctxt, - xmlNodePtr *node, - size_t num) -{ - size_t i; - virDomainIdMapEntry *idmap =3D NULL; - VIR_XPATH_NODE_AUTORESTORE(ctxt) - - idmap =3D g_new0(virDomainIdMapEntry, num); - - for (i =3D 0; i < num; i++) { - ctxt->node =3D node[i]; - if (virXPathUInt("string(./@start)", ctxt, &idmap[i].start) < 0 || - virXPathUInt("string(./@target)", ctxt, &idmap[i].target) < 0 = || - virXPathUInt("string(./@count)", ctxt, &idmap[i].count) < 0) { - virReportError(VIR_ERR_XML_ERROR, "%s", - _("invalid idmap start/target/count settings")); - VIR_FREE(idmap); - return NULL; - } - } - - qsort(idmap, num, sizeof(idmap[0]), virDomainIdMapEntrySort); - - return idmap; -} - /* Parse the XML definition for an IOThread ID * * Format is : --=20 2.41.0 From nobody Fri May 10 06:40:01 2024 Delivered-To: importer@patchew.org Received-SPF: pass (zohomail.com: domain of redhat.com designates 170.10.129.124 as permitted sender) client-ip=170.10.129.124; envelope-from=libvir-list-bounces@redhat.com; helo=us-smtp-delivery-124.mimecast.com; Authentication-Results: mx.zohomail.com; dkim=pass; spf=pass (zohomail.com: domain of redhat.com designates 170.10.129.124 as permitted sender) smtp.mailfrom=libvir-list-bounces@redhat.com; dmarc=pass(p=none dis=none) header.from=redhat.com ARC-Seal: i=1; a=rsa-sha256; t=1694440378; cv=none; d=zohomail.com; s=zohoarc; b=luBm9hTPy6AbQaZ9R527Ipqjua3sVT4EKWE//Z2g8ZPOTqUdMiQalI8N0mrlScdASxQDPZ18AJcYmHrvBOsxL60k//jZVqG+TjDZK8hNmB4imClxDIFomXNC74JEE+++KCt7nukdNVDjgIREc8lxum35GlQQe0Z+m46tn0EVw2M= ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=zohomail.com; s=zohoarc; t=1694440378; h=Content-Type:Content-Transfer-Encoding:Date:From:In-Reply-To:List-Subscribe:List-Post:List-Id:List-Archive:List-Help:List-Unsubscribe:MIME-Version:Message-ID:References:Sender:Subject:To; bh=qNyMjYQlnBGIwMbY0flRh2D8ic0X9z0+FahLXFCncZg=; b=K1IiwCRWm3JDBjIQaC9a+sKpK8RKnq7FDgc3h4TDuhw2JtQlpAPNPcG7gON0omnTr/ESVVTvC7ZNTHehTUTkzPcjjgYg5Au56J+pxLOItuondyDleEmdhxA8vPWq+rh0OxOCJSJpTQxayozdBtjl93hwe3NEgasXz2F53B4Fxww= ARC-Authentication-Results: i=1; mx.zohomail.com; dkim=pass; spf=pass (zohomail.com: domain of redhat.com designates 170.10.129.124 as permitted sender) smtp.mailfrom=libvir-list-bounces@redhat.com; dmarc=pass header.from= (p=none dis=none) Return-Path: Received: from us-smtp-delivery-124.mimecast.com (us-smtp-delivery-124.mimecast.com [170.10.129.124]) by mx.zohomail.com with SMTPS id 1694440378970768.9693849261336; Mon, 11 Sep 2023 06:52:58 -0700 (PDT) Received: from mimecast-mx02.redhat.com (mimecast-mx02.redhat.com [66.187.233.88]) by relay.mimecast.com with ESMTP with STARTTLS (version=TLSv1.2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id us-mta-523-QgqIN9r6P_SmYrxqwMEv6A-1; Mon, 11 Sep 2023 09:52:47 -0400 Received: from smtp.corp.redhat.com (int-mx04.intmail.prod.int.rdu2.redhat.com [10.11.54.4]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by mimecast-mx02.redhat.com (Postfix) with ESMTPS id 0559F80523C; Mon, 11 Sep 2023 13:52:34 +0000 (UTC) Received: from mm-prod-listman-01.mail-001.prod.us-east-1.aws.redhat.com (mm-prod-listman-01.mail-001.prod.us-east-1.aws.redhat.com [10.30.29.100]) by smtp.corp.redhat.com (Postfix) with ESMTP id DF7C82026D4B; Mon, 11 Sep 2023 13:52:33 +0000 (UTC) Received: from mm-prod-listman-01.mail-001.prod.us-east-1.aws.redhat.com (localhost [IPv6:::1]) by mm-prod-listman-01.mail-001.prod.us-east-1.aws.redhat.com (Postfix) with ESMTP id 7282719465B8; Mon, 11 Sep 2023 13:52:33 +0000 (UTC) Received: from smtp.corp.redhat.com (int-mx03.intmail.prod.int.rdu2.redhat.com [10.11.54.3]) by mm-prod-listman-01.mail-001.prod.us-east-1.aws.redhat.com (Postfix) with ESMTP id DB1911946A50 for ; Mon, 11 Sep 2023 13:52:30 +0000 (UTC) Received: by smtp.corp.redhat.com (Postfix) id CAD0E10EE859; Mon, 11 Sep 2023 13:52:30 +0000 (UTC) Received: from fedora.. (unknown [10.43.2.118]) by smtp.corp.redhat.com (Postfix) with ESMTP id 716CC10F1BE9 for ; Mon, 11 Sep 2023 13:52:30 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=redhat.com; s=mimecast20190719; t=1694440378; h=from:from:sender:sender:reply-to:subject:subject:date:date: message-id:message-id:to:to:cc:mime-version:mime-version: content-type:content-type: content-transfer-encoding:content-transfer-encoding: in-reply-to:in-reply-to:references:references:list-id:list-help: list-unsubscribe:list-subscribe:list-post; bh=qNyMjYQlnBGIwMbY0flRh2D8ic0X9z0+FahLXFCncZg=; b=AdCoDztbX3M+IYz3xarXiW6WUuyNeUSNMCtxsOQ4VuN6ZHTxmXzRqQmJ8KV0kN/07d7/Hd Fs341rI26jH89FzUlOLFPwL/2ucTcn0RWJvLA06WoEe/p38xkbTbqvXVW/b4PqaKX/3zIq +SOmB8ycJUFewrGwWzA9+sCD6osXvuI= X-MC-Unique: QgqIN9r6P_SmYrxqwMEv6A-1 X-Original-To: libvir-list@listman.corp.redhat.com From: =?UTF-8?q?J=C3=A1n=20Tomko?= To: libvir-list@redhat.com Subject: [libvirt PATCHv1 4/8] conf: add idmap element to filesystem Date: Mon, 11 Sep 2023 15:51:24 +0200 Message-ID: <2682cd5d0fba149f3d66ef988b4b48641fd8cdf9.1694440288.git.jtomko@redhat.com> In-Reply-To: References: MIME-Version: 1.0 X-Scanned-By: MIMEDefang 3.1 on 10.11.54.3 X-BeenThere: libvir-list@redhat.com X-Mailman-Version: 2.1.29 Precedence: list List-Id: Development discussions about the libvirt library & tools List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: libvir-list-bounces@redhat.com Sender: "libvir-list" X-Scanned-By: MIMEDefang 3.1 on 10.11.54.4 X-Mimecast-Spam-Score: 0 X-Mimecast-Originator: redhat.com Content-Type: text/plain; charset="utf-8" Content-Transfer-Encoding: quoted-printable X-ZohoMail-DKIM: pass (identity @redhat.com) X-ZM-MESSAGEID: 1694440407155100005 Let unprivileged virtiofs use user namespace. Signed-off-by: J=C3=A1n Tomko --- docs/formatdomain.rst | 7 +++ src/conf/domain_conf.c | 51 +++++++++++++++++++ src/conf/domain_conf.h | 1 + src/conf/schemas/domaincommon.rng | 3 ++ .../vhost-user-fs-fd-memory.xml | 4 ++ 5 files changed, 66 insertions(+) diff --git a/docs/formatdomain.rst b/docs/formatdomain.rst index bc469e5f9f..0f10b3043f 100644 --- a/docs/formatdomain.rst +++ b/docs/formatdomain.rst @@ -3501,6 +3501,10 @@ A directory on the host that can be accessed directl= y from the guest. + + + + @@ -3650,6 +3654,9 @@ A directory on the host that can be accessed directly= from the guest. Where the ``source`` can be accessed in the guest. For most drivers thi= s is an automatic mount point, but for QEMU/KVM this is merely an arbitrary = string tag that is exported to the guest as a hint for where to mount. +``idmap`` + For ``virtiofs``, an ``idmap`` element can be specified to map IDs in t= he user + namespace. See the `Container boot`_ section for the syntax of the elem= ent. ``readonly`` Enables exporting filesystem as a readonly mount for guest, by default read-write access is given (currently only works for QEMU/KVM driver). diff --git a/src/conf/domain_conf.c b/src/conf/domain_conf.c index dd67e7f21b..2379a9204f 100644 --- a/src/conf/domain_conf.c +++ b/src/conf/domain_conf.c @@ -2585,6 +2585,8 @@ void virDomainFSDefFree(virDomainFSDef *def) virObjectUnref(def->privateData); g_free(def->binary); g_free(def->sock); + g_free(def->idmap.uidmap); + g_free(def->idmap.gidmap); =20 g_free(def); } @@ -8767,6 +8769,8 @@ virDomainFSDefParseXML(virDomainXMLOption *xmlopt, xmlNodePtr binary_lock_node =3D virXPathNode("./binary/lock", ctxt= ); xmlNodePtr binary_cache_node =3D virXPathNode("./binary/cache", ct= xt); xmlNodePtr binary_sandbox_node =3D virXPathNode("./binary/sandbox"= , ctxt); + ssize_t n; + xmlNodePtr *nodes =3D NULL; =20 if (queue_size && virStrToLong_ull(queue_size, NULL, 10, &def->que= ue_size) < 0) { virReportError(VIR_ERR_XML_ERROR, @@ -8812,6 +8816,30 @@ virDomainFSDefParseXML(virDomainXMLOption *xmlopt, VIR_XML_PROP_NONZERO, &def->sandbox) < 0) goto error; + + if ((n =3D virXPathNodeSet("./idmap/uid", ctxt, &nodes)) < 0) + return NULL; + + if (n) { + def->idmap.uidmap =3D virDomainIdmapDefParseXML(ctxt, nodes, n= ); + if (!def->idmap.uidmap) + return NULL; + + def->idmap.nuidmap =3D n; + } + VIR_FREE(nodes); + + if ((n =3D virXPathNodeSet("./idmap/gid", ctxt, &nodes)) < 0) + return NULL; + + if (n) { + def->idmap.gidmap =3D virDomainIdmapDefParseXML(ctxt, nodes, = n); + if (!def->idmap.gidmap) + return NULL; + + def->idmap.ngidmap =3D n; + } + VIR_FREE(nodes); } =20 if (source =3D=3D NULL && def->type !=3D VIR_DOMAIN_FS_TYPE_RAM @@ -23164,6 +23192,29 @@ virDomainFSDefFormat(virBuffer *buf, virXMLFormatElement(buf, "driver", &driverAttrBuf, &driverBuf); virXMLFormatElement(buf, "binary", &binaryAttrBuf, &binaryBuf); =20 + if (def->idmap.uidmap) { + size_t i; + + virBufferAddLit(buf, "\n"); + virBufferAdjustIndent(buf, 2); + for (i =3D 0; i < def->idmap.nuidmap; i++) { + virBufferAsprintf(buf, + "\n", + def->idmap.uidmap[i].start, + def->idmap.uidmap[i].target, + def->idmap.uidmap[i].count); + } + for (i =3D 0; i < def->idmap.ngidmap; i++) { + virBufferAsprintf(buf, + "\n", + def->idmap.gidmap[i].start, + def->idmap.gidmap[i].target, + def->idmap.gidmap[i].count); + } + virBufferAdjustIndent(buf, -2); + virBufferAddLit(buf, "\n"); + } + switch (def->type) { case VIR_DOMAIN_FS_TYPE_MOUNT: case VIR_DOMAIN_FS_TYPE_BIND: diff --git a/src/conf/domain_conf.h b/src/conf/domain_conf.h index 8937968e3b..b84719b01d 100644 --- a/src/conf/domain_conf.h +++ b/src/conf/domain_conf.h @@ -925,6 +925,7 @@ struct _virDomainFSDef { virTristateSwitch flock; virDomainFSSandboxMode sandbox; int thread_pool_size; + virDomainIdMapDef idmap; virDomainVirtioOptions *virtio; virObject *privateData; }; diff --git a/src/conf/schemas/domaincommon.rng b/src/conf/schemas/domaincom= mon.rng index 2f9ba31c0a..2ca0e92f00 100644 --- a/src/conf/schemas/domaincommon.rng +++ b/src/conf/schemas/domaincommon.rng @@ -3052,6 +3052,9 @@ + + + diff --git a/tests/qemuxml2argvdata/vhost-user-fs-fd-memory.xml b/tests/qem= uxml2argvdata/vhost-user-fs-fd-memory.xml index 81de8c0dd7..1d0bc26c46 100644 --- a/tests/qemuxml2argvdata/vhost-user-fs-fd-memory.xml +++ b/tests/qemuxml2argvdata/vhost-user-fs-fd-memory.xml @@ -34,6 +34,10 @@ + + + +
--=20 2.41.0 From nobody Fri May 10 06:40:01 2024 Delivered-To: importer@patchew.org Received-SPF: pass (zohomail.com: domain of redhat.com designates 170.10.133.124 as permitted sender) client-ip=170.10.133.124; envelope-from=libvir-list-bounces@redhat.com; helo=us-smtp-delivery-124.mimecast.com; Authentication-Results: mx.zohomail.com; dkim=pass; spf=pass (zohomail.com: domain of redhat.com designates 170.10.133.124 as permitted sender) smtp.mailfrom=libvir-list-bounces@redhat.com; dmarc=pass(p=none dis=none) header.from=redhat.com ARC-Seal: i=1; a=rsa-sha256; t=1694440371; cv=none; d=zohomail.com; s=zohoarc; b=EEOlduf9xqln2P9oG0dRPsxrdJc9INHliHKXjJI5dsqHGFr4KQj3m+N9zLd1loEwnKOG/mZExIsr9s6ysaWJ5GmOV3ck/qUyZw5IiWLn4w9qIrf3LDuRwGW/kB7zdg00U8Te8sHnofa4v5WPFMo8m28EDWtnuJ2IbliyXDC7yII= ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=zohomail.com; s=zohoarc; t=1694440371; h=Content-Type:Content-Transfer-Encoding:Date:From:In-Reply-To:List-Subscribe:List-Post:List-Id:List-Archive:List-Help:List-Unsubscribe:MIME-Version:Message-ID:References:Sender:Subject:To; bh=8YFv3/655hOJCDA2NDqw1E3kMd+6rrozVh/l0lvGFdI=; b=hm78vzBWjuaObsL6t2WPu/9xGM7n9+/g1nRA1sk5nTmwFfveBdVLd95dQAo4ve5XHUOE5MzVXMCgWrsQ9jrVE83B28EPdwefa033BxtR9UE5c0Ijnr9OIpldMJTTvzheJdTD4UPcAaTwROCrnVCCaL9L9O+ZcBYrDVrngD32lW4= ARC-Authentication-Results: i=1; mx.zohomail.com; dkim=pass; spf=pass (zohomail.com: domain of redhat.com designates 170.10.133.124 as permitted sender) smtp.mailfrom=libvir-list-bounces@redhat.com; dmarc=pass header.from= (p=none dis=none) Return-Path: Received: from us-smtp-delivery-124.mimecast.com (us-smtp-delivery-124.mimecast.com [170.10.133.124]) by mx.zohomail.com with SMTPS id 1694440371081664.3034666174975; Mon, 11 Sep 2023 06:52:51 -0700 (PDT) Received: from mimecast-mx02.redhat.com (mx-ext.redhat.com [66.187.233.73]) by relay.mimecast.com with ESMTP with STARTTLS (version=TLSv1.2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id us-mta-260-4WJ6QRRJNeSXfcCivsrqPA-1; Mon, 11 Sep 2023 09:52:36 -0400 Received: from smtp.corp.redhat.com (int-mx06.intmail.prod.int.rdu2.redhat.com [10.11.54.6]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by mimecast-mx02.redhat.com (Postfix) with ESMTPS id DC4F629DD9A4; Mon, 11 Sep 2023 13:52:32 +0000 (UTC) Received: from mm-prod-listman-01.mail-001.prod.us-east-1.aws.redhat.com (mm-prod-listman-01.mail-001.prod.us-east-1.aws.redhat.com [10.30.29.100]) by smtp.corp.redhat.com (Postfix) with ESMTP id BA23D21CAC8E; Mon, 11 Sep 2023 13:52:32 +0000 (UTC) Received: from mm-prod-listman-01.mail-001.prod.us-east-1.aws.redhat.com (localhost [IPv6:::1]) by mm-prod-listman-01.mail-001.prod.us-east-1.aws.redhat.com (Postfix) with ESMTP id 50F321946A49; Mon, 11 Sep 2023 13:52:32 +0000 (UTC) Received: from smtp.corp.redhat.com (int-mx03.intmail.prod.int.rdu2.redhat.com [10.11.54.3]) by mm-prod-listman-01.mail-001.prod.us-east-1.aws.redhat.com (Postfix) with ESMTP id 752FF19465B2 for ; Mon, 11 Sep 2023 13:52:31 +0000 (UTC) Received: by smtp.corp.redhat.com (Postfix) id 6661110005D2; Mon, 11 Sep 2023 13:52:31 +0000 (UTC) Received: from fedora.. (unknown [10.43.2.118]) by smtp.corp.redhat.com (Postfix) with ESMTP id 0D9EE10EE6C9 for ; Mon, 11 Sep 2023 13:52:30 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=redhat.com; s=mimecast20190719; t=1694440370; h=from:from:sender:sender:reply-to:subject:subject:date:date: message-id:message-id:to:to:cc:mime-version:mime-version: content-type:content-type: content-transfer-encoding:content-transfer-encoding: in-reply-to:in-reply-to:references:references:list-id:list-help: list-unsubscribe:list-subscribe:list-post; bh=8YFv3/655hOJCDA2NDqw1E3kMd+6rrozVh/l0lvGFdI=; b=J9LxwWYIrdW8SUxCEH2l519vcG1UaepzHZzkcqBESZhV/WSdlgCA4lEAEIJqHdeMYAsq2t tZMSm7+1cutPzEYLb9r8aPkG5UjbmDOCbCMxSb41rodG19bBVJD6cZyVA3A5m0Vy0V3CG6 LlczWSPkTH7adkWXCYWUWeSIGv0Txrc= X-MC-Unique: 4WJ6QRRJNeSXfcCivsrqPA-1 X-Original-To: libvir-list@listman.corp.redhat.com From: =?UTF-8?q?J=C3=A1n=20Tomko?= To: libvir-list@redhat.com Subject: [libvirt PATCHv1 5/8] qemu: format uid/gid map for virtiofs Date: Mon, 11 Sep 2023 15:51:25 +0200 Message-ID: <9023fd862b7dd7b5f38001beef20f932a7d88b3d.1694440288.git.jtomko@redhat.com> In-Reply-To: References: MIME-Version: 1.0 X-Scanned-By: MIMEDefang 3.1 on 10.11.54.3 X-BeenThere: libvir-list@redhat.com X-Mailman-Version: 2.1.29 Precedence: list List-Id: Development discussions about the libvirt library & tools List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: libvir-list-bounces@redhat.com Sender: "libvir-list" X-Scanned-By: MIMEDefang 3.1 on 10.11.54.6 X-Mimecast-Spam-Score: 0 X-Mimecast-Originator: redhat.com Content-Type: text/plain; charset="utf-8" Content-Transfer-Encoding: quoted-printable X-ZohoMail-DKIM: pass (identity @redhat.com) X-ZM-MESSAGEID: 1694440401992100001 Pass the ID map to virtiofsd. https://bugzilla.redhat.com/show_bug.cgi?id=3D2034630 https://gitlab.com/libvirt/libvirt/-/issues/535 Signed-off-by: J=C3=A1n Tomko --- src/qemu/qemu_virtiofs.c | 13 +++++++++++++ 1 file changed, 13 insertions(+) diff --git a/src/qemu/qemu_virtiofs.c b/src/qemu/qemu_virtiofs.c index 230f85c291..94c8b4711e 100644 --- a/src/qemu/qemu_virtiofs.c +++ b/src/qemu/qemu_virtiofs.c @@ -169,6 +169,19 @@ qemuVirtioFSBuildCommandLine(virQEMUDriverConfig *cfg, if (cfg->virtiofsdDebug) virCommandAddArg(cmd, "-d"); =20 + if (fs->idmap.nuidmap > 0) { + virCommandAddArgFormat(cmd, "--uid-map=3D:%u:%u:%u:", + fs->idmap.uidmap[0].start, + fs->idmap.uidmap[0].target, + fs->idmap.uidmap[0].count); + } + if (fs->idmap.ngidmap > 0) { + virCommandAddArgFormat(cmd, "--gid-map=3D:%u:%u:%u:", + fs->idmap.gidmap[0].start, + fs->idmap.gidmap[0].target, + fs->idmap.gidmap[0].count); + } + return g_steal_pointer(&cmd); } =20 --=20 2.41.0 From nobody Fri May 10 06:40:01 2024 Delivered-To: importer@patchew.org Received-SPF: pass (zohomail.com: domain of redhat.com designates 170.10.129.124 as permitted sender) client-ip=170.10.129.124; envelope-from=libvir-list-bounces@redhat.com; helo=us-smtp-delivery-124.mimecast.com; Authentication-Results: mx.zohomail.com; dkim=pass; spf=pass (zohomail.com: domain of redhat.com designates 170.10.129.124 as permitted sender) smtp.mailfrom=libvir-list-bounces@redhat.com; dmarc=pass(p=none dis=none) header.from=redhat.com ARC-Seal: i=1; a=rsa-sha256; t=1694440381; cv=none; d=zohomail.com; s=zohoarc; b=fPHjmu927ioaWmKmnmm+Io+QzYXT7Rr+aqMxIZaOBaIvm28OwFEHbWwPISxOqS/YKxfy376n+v3+P9AcYuM/U63Y14PtxngIsGy0MyOWlOEgK7Nrs09N5/5W4Xu75Umutz+OZutjlS5LZ1hsiHUG8VCDlRS6K0p9ppHsg3nit4Q= ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=zohomail.com; s=zohoarc; t=1694440381; h=Content-Type:Content-Transfer-Encoding:Date:From:In-Reply-To:List-Subscribe:List-Post:List-Id:List-Archive:List-Help:List-Unsubscribe:MIME-Version:Message-ID:References:Sender:Subject:To; bh=iCLzO7oKYreuWQz6Dx+NZ6PZZEK7hV9/qlHmd3o3gHI=; b=f/UbflZYKByi7wE9gx56n33hNMZ2ChjLN2b7bU38g4D5/pDp3s4ttJ6j+dR4LhXDBzZEpEDpYzOfqpR8VIj2KGeVPQljbQDcqMKpN7P5JSu9PzQSZx8+KZgzhAtnXbV5AVybiqUf/Y5QMOw16qZeavaKIwl4KP1NLeInkxcg1Kk= ARC-Authentication-Results: i=1; mx.zohomail.com; dkim=pass; spf=pass (zohomail.com: domain of redhat.com designates 170.10.129.124 as permitted sender) smtp.mailfrom=libvir-list-bounces@redhat.com; dmarc=pass header.from= (p=none dis=none) Return-Path: Received: from us-smtp-delivery-124.mimecast.com (us-smtp-delivery-124.mimecast.com [170.10.129.124]) by mx.zohomail.com with SMTPS id 1694440381708152.82415484689852; Mon, 11 Sep 2023 06:53:01 -0700 (PDT) Received: from mimecast-mx02.redhat.com (mimecast-mx02.redhat.com [66.187.233.88]) by relay.mimecast.com with ESMTP with STARTTLS (version=TLSv1.2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id us-mta-553-Jx7_yolBOLqvnAf-Sxeuwg-1; Mon, 11 Sep 2023 09:52:46 -0400 Received: from smtp.corp.redhat.com (int-mx04.intmail.prod.int.rdu2.redhat.com [10.11.54.4]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by mimecast-mx02.redhat.com (Postfix) with ESMTPS id DD15C927AA4; Mon, 11 Sep 2023 13:52:36 +0000 (UTC) Received: from mm-prod-listman-01.mail-001.prod.us-east-1.aws.redhat.com (mm-prod-listman-01.mail-001.prod.us-east-1.aws.redhat.com [10.30.29.100]) by smtp.corp.redhat.com (Postfix) with ESMTP id C564C2026D4B; Mon, 11 Sep 2023 13:52:36 +0000 (UTC) Received: from mm-prod-listman-01.mail-001.prod.us-east-1.aws.redhat.com (localhost [IPv6:::1]) by mm-prod-listman-01.mail-001.prod.us-east-1.aws.redhat.com (Postfix) with ESMTP id A9DF51946A4B; Mon, 11 Sep 2023 13:52:34 +0000 (UTC) Received: from smtp.corp.redhat.com (int-mx03.intmail.prod.int.rdu2.redhat.com [10.11.54.3]) by mm-prod-listman-01.mail-001.prod.us-east-1.aws.redhat.com (Postfix) with ESMTP id 2287819465BB for ; Mon, 11 Sep 2023 13:52:32 +0000 (UTC) Received: by smtp.corp.redhat.com (Postfix) id 042B910005D2; Mon, 11 Sep 2023 13:52:32 +0000 (UTC) Received: from fedora.. (unknown [10.43.2.118]) by smtp.corp.redhat.com (Postfix) with ESMTP id 9FFA310F1BE8 for ; Mon, 11 Sep 2023 13:52:31 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=redhat.com; s=mimecast20190719; t=1694440380; h=from:from:sender:sender:reply-to:subject:subject:date:date: message-id:message-id:to:to:cc:mime-version:mime-version: content-type:content-type: content-transfer-encoding:content-transfer-encoding: in-reply-to:in-reply-to:references:references:list-id:list-help: list-unsubscribe:list-subscribe:list-post; bh=iCLzO7oKYreuWQz6Dx+NZ6PZZEK7hV9/qlHmd3o3gHI=; b=QCnSPB4oLsPG3Hlmp1cWSmcCoWzqUdAaP4KbM7MPevOcGzMOtMga3GTwI0k4HkdDmyFCer +LCcSXfH6nZ7udo+lDJwaW8wpvFoQGIZ4+FpESORhVEPYVKmXHd8FK8iSxEzAwpvlUJtEp EXk67cKDLSSThLCDIJFK5IjCusGvm8w= X-MC-Unique: Jx7_yolBOLqvnAf-Sxeuwg-1 X-Original-To: libvir-list@listman.corp.redhat.com From: =?UTF-8?q?J=C3=A1n=20Tomko?= To: libvir-list@redhat.com Subject: [libvirt PATCHv1 6/8] qemu: virtiofs: do not force UID 0 Date: Mon, 11 Sep 2023 15:51:26 +0200 Message-ID: <6624348bb4085ee824feb27cafe513dbb51fd4da.1694440288.git.jtomko@redhat.com> In-Reply-To: References: MIME-Version: 1.0 X-Scanned-By: MIMEDefang 3.1 on 10.11.54.3 X-BeenThere: libvir-list@redhat.com X-Mailman-Version: 2.1.29 Precedence: list List-Id: Development discussions about the libvirt library & tools List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: libvir-list-bounces@redhat.com Sender: "libvir-list" X-Scanned-By: MIMEDefang 3.1 on 10.11.54.4 X-Mimecast-Spam-Score: 0 X-Mimecast-Originator: redhat.com Content-Type: text/plain; charset="utf-8" Content-Transfer-Encoding: quoted-printable X-ZohoMail-DKIM: pass (identity @redhat.com) X-ZM-MESSAGEID: 1694440404580100001 Signed-off-by: J=C3=A1n Tomko --- src/qemu/qemu_virtiofs.c | 4 ---- 1 file changed, 4 deletions(-) diff --git a/src/qemu/qemu_virtiofs.c b/src/qemu/qemu_virtiofs.c index 94c8b4711e..4871bad801 100644 --- a/src/qemu/qemu_virtiofs.c +++ b/src/qemu/qemu_virtiofs.c @@ -255,10 +255,6 @@ qemuVirtioFSStart(virQEMUDriver *driver, if (!(cmd =3D qemuVirtioFSBuildCommandLine(cfg, fs, &fd))) goto error; =20 - /* so far only running as root is supported */ - virCommandSetUID(cmd, 0); - virCommandSetGID(cmd, 0); - virCommandSetPidFile(cmd, pidfile); virCommandSetOutputFD(cmd, &logfd); virCommandSetErrorFD(cmd, &logfd); --=20 2.41.0 From nobody Fri May 10 06:40:01 2024 Delivered-To: importer@patchew.org Received-SPF: pass (zohomail.com: domain of redhat.com designates 170.10.133.124 as permitted sender) client-ip=170.10.133.124; envelope-from=libvir-list-bounces@redhat.com; helo=us-smtp-delivery-124.mimecast.com; Authentication-Results: mx.zohomail.com; dkim=pass; spf=pass (zohomail.com: domain of redhat.com designates 170.10.133.124 as permitted sender) smtp.mailfrom=libvir-list-bounces@redhat.com; dmarc=pass(p=none dis=none) header.from=redhat.com ARC-Seal: i=1; a=rsa-sha256; t=1694440371; cv=none; d=zohomail.com; s=zohoarc; b=cGWJBLsZ7j8w0fchuFhJmTEkxDgSp6Uj4skAnr33PsnANUpH7VjQSARgDVOJ5mWxFpuwTxvDXLE9ci8/4aZlCq5fzgol+YJ25PqgvGU/M+5HiDSzo76QuaIvm/3hkn5N/ZnEsd0yGiyK+Z0LV1xcpqjgoE5rf6bm/NELWyUo9AE= ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=zohomail.com; s=zohoarc; t=1694440371; h=Content-Type:Content-Transfer-Encoding:Date:From:In-Reply-To:List-Subscribe:List-Post:List-Id:List-Archive:List-Help:List-Unsubscribe:MIME-Version:Message-ID:References:Sender:Subject:To; bh=3sBc5Q4BdOUIhn2uPKDmubHxlxQjf1JAEvEVSUMwqmM=; b=E+mXXL7D8mH16BOj7IQblovS+eNQrYE03UHaUVha1cJolC8YAJBZ/JLffFlXlc3xxuXwcywG2ZuNd7h9h5M0YGRpbrph+bl96xAaSSp8HrSFkEVgITI6SJ+TOv7TBOm4Srhjlzh7FyW7ZkWoWKgz+0VXe8XChBzFOQW0LcN06KU= ARC-Authentication-Results: i=1; mx.zohomail.com; dkim=pass; spf=pass (zohomail.com: domain of redhat.com designates 170.10.133.124 as permitted sender) smtp.mailfrom=libvir-list-bounces@redhat.com; dmarc=pass header.from= (p=none dis=none) Return-Path: Received: from us-smtp-delivery-124.mimecast.com (us-smtp-delivery-124.mimecast.com [170.10.133.124]) by mx.zohomail.com with SMTPS id 1694440371829283.1827128678465; Mon, 11 Sep 2023 06:52:51 -0700 (PDT) Received: from mimecast-mx02.redhat.com (mx-ext.redhat.com [66.187.233.73]) by relay.mimecast.com with ESMTP with STARTTLS (version=TLSv1.2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id us-mta-512-_FweAKryMtWIZDP1LVxy6Q-1; Mon, 11 Sep 2023 09:52:41 -0400 Received: from smtp.corp.redhat.com (int-mx02.intmail.prod.int.rdu2.redhat.com [10.11.54.2]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by mimecast-mx02.redhat.com (Postfix) with ESMTPS id 652C529DD99E; Mon, 11 Sep 2023 13:52:36 +0000 (UTC) Received: from mm-prod-listman-01.mail-001.prod.us-east-1.aws.redhat.com (mm-prod-listman-01.mail-001.prod.us-east-1.aws.redhat.com [10.30.29.100]) by smtp.corp.redhat.com (Postfix) with ESMTP id 4C3A440C6EC0; Mon, 11 Sep 2023 13:52:36 +0000 (UTC) Received: from mm-prod-listman-01.mail-001.prod.us-east-1.aws.redhat.com (localhost [IPv6:::1]) by mm-prod-listman-01.mail-001.prod.us-east-1.aws.redhat.com (Postfix) with ESMTP id 90BCE19465B3; Mon, 11 Sep 2023 13:52:34 +0000 (UTC) Received: from smtp.corp.redhat.com (int-mx03.intmail.prod.int.rdu2.redhat.com [10.11.54.3]) by mm-prod-listman-01.mail-001.prod.us-east-1.aws.redhat.com (Postfix) with ESMTP id BF09B19465A4 for ; Mon, 11 Sep 2023 13:52:32 +0000 (UTC) Received: by smtp.corp.redhat.com (Postfix) id 980B21006B5C; Mon, 11 Sep 2023 13:52:32 +0000 (UTC) Received: from fedora.. (unknown [10.43.2.118]) by smtp.corp.redhat.com (Postfix) with ESMTP id 3B96610F1BE9 for ; Mon, 11 Sep 2023 13:52:32 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=redhat.com; s=mimecast20190719; t=1694440370; h=from:from:sender:sender:reply-to:subject:subject:date:date: message-id:message-id:to:to:cc:mime-version:mime-version: content-type:content-type: content-transfer-encoding:content-transfer-encoding: in-reply-to:in-reply-to:references:references:list-id:list-help: list-unsubscribe:list-subscribe:list-post; bh=3sBc5Q4BdOUIhn2uPKDmubHxlxQjf1JAEvEVSUMwqmM=; b=ZCs8u3VCeaYDzKVUqE3Yf3QtCOG3zCpcnbqo/bUJhZkFxpHPCOGK6ZY57saocacpRsOWxz CdgjBZwnzFLr/JetoY8Vr0NxbWRz1mRsCaWLoV63Ou92mND1zlQrbrkMfboKqkE3B49tkJ 144LvscKZjkGM8fxVl12gncRpFWWXbY= X-MC-Unique: _FweAKryMtWIZDP1LVxy6Q-1 X-Original-To: libvir-list@listman.corp.redhat.com From: =?UTF-8?q?J=C3=A1n=20Tomko?= To: libvir-list@redhat.com Subject: [libvirt PATCHv1 7/8] qemu: allow running virtiofsd in session mode Date: Mon, 11 Sep 2023 15:51:27 +0200 Message-ID: <38e48dc7244221084ab3232f46db1e860bd7d81d.1694440288.git.jtomko@redhat.com> In-Reply-To: References: MIME-Version: 1.0 X-Scanned-By: MIMEDefang 3.1 on 10.11.54.3 X-BeenThere: libvir-list@redhat.com X-Mailman-Version: 2.1.29 Precedence: list List-Id: Development discussions about the libvirt library & tools List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: libvir-list-bounces@redhat.com Sender: "libvir-list" X-Scanned-By: MIMEDefang 3.1 on 10.11.54.2 X-Mimecast-Spam-Score: 0 X-Mimecast-Originator: redhat.com Content-Type: text/plain; charset="utf-8" Content-Transfer-Encoding: quoted-printable X-ZohoMail-DKIM: pass (identity @redhat.com) X-ZM-MESSAGEID: 1694440404983100003 https://gitlab.com/libvirt/libvirt/-/issues/535 Signed-off-by: J=C3=A1n Tomko --- src/qemu/qemu_validate.c | 7 +------ 1 file changed, 1 insertion(+), 6 deletions(-) diff --git a/src/qemu/qemu_validate.c b/src/qemu/qemu_validate.c index e3c34eca3d..da7b0ff419 100644 --- a/src/qemu/qemu_validate.c +++ b/src/qemu/qemu_validate.c @@ -4229,7 +4229,7 @@ qemuValidateDomainDeviceDefGraphics(const virDomainGr= aphicsDef *graphics, static int qemuValidateDomainDeviceDefFS(virDomainFSDef *fs, const virDomainDef *def, - virQEMUDriver *driver, + virQEMUDriver *driver G_GNUC_UNUSED, virQEMUCaps *qemuCaps) { if (fs->type !=3D VIR_DOMAIN_FS_TYPE_MOUNT) { @@ -4286,11 +4286,6 @@ qemuValidateDomainDeviceDefFS(virDomainFSDef *fs, _("virtiofs does not yet support read-only = mode")); return -1; } - if (!driver->privileged) { - virReportError(VIR_ERR_CONFIG_UNSUPPORTED, "%s", - _("virtiofs is not yet supported in session= mode")); - return -1; - } if (fs->accessmode !=3D VIR_DOMAIN_FS_ACCESSMODE_PASSTHROUGH) { virReportError(VIR_ERR_CONFIG_UNSUPPORTED, "%s", _("virtiofs only supports passthrough acces= smode")); --=20 2.41.0 From nobody Fri May 10 06:40:01 2024 Delivered-To: importer@patchew.org Received-SPF: pass (zohomail.com: domain of redhat.com designates 170.10.133.124 as permitted sender) client-ip=170.10.133.124; envelope-from=libvir-list-bounces@redhat.com; helo=us-smtp-delivery-124.mimecast.com; Authentication-Results: mx.zohomail.com; dkim=pass; spf=pass (zohomail.com: domain of redhat.com designates 170.10.133.124 as permitted sender) smtp.mailfrom=libvir-list-bounces@redhat.com; dmarc=pass(p=none dis=none) header.from=redhat.com ARC-Seal: i=1; a=rsa-sha256; t=1694440389; cv=none; d=zohomail.com; s=zohoarc; b=V93HtRGvuGkdOR0xE8gaggD0I8he91HqNRndqmMg174N4h6UwvGWO7n8GGU6ZOS+NQ/UXQYPuzOiqN/IgiNb9LK+b8YW059DQ4xYa0W//NB1d6lqbKAaSRVDlw9zzOPRsoFNv/T7H/9aMCdkx6mI2c10YcDOxd4ciE627z5eI50= ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=zohomail.com; s=zohoarc; t=1694440389; h=Content-Type:Content-Transfer-Encoding:Date:From:In-Reply-To:List-Subscribe:List-Post:List-Id:List-Archive:List-Help:List-Unsubscribe:MIME-Version:Message-ID:References:Sender:Subject:To; bh=krp47eWzE4WHj/zQSRvIRCRMYkZE4Qe2NJLntOl90ps=; b=SxWx5qHXJ/mh6SZTJgZK7X6TIbsikdEarF5u+eov7BCFqLJ+sqha+Seqe1ZhAugWZnwJL2U+PXsQ67gvmI0Cy+rtbHyeIzD88ksPi90PqxLe56/dQjJOw3hEv6oN9q58U3L6TxZhx/hnV64+5Kq/jAntQdwA7jAr4Nrf6p/TOso= ARC-Authentication-Results: i=1; mx.zohomail.com; dkim=pass; spf=pass (zohomail.com: domain of redhat.com designates 170.10.133.124 as permitted sender) smtp.mailfrom=libvir-list-bounces@redhat.com; dmarc=pass header.from= (p=none dis=none) Return-Path: Received: from us-smtp-delivery-124.mimecast.com (us-smtp-delivery-124.mimecast.com [170.10.133.124]) by mx.zohomail.com with SMTPS id 1694440389510409.01491113042766; Mon, 11 Sep 2023 06:53:09 -0700 (PDT) Received: from mimecast-mx02.redhat.com (mx-ext.redhat.com [66.187.233.73]) by relay.mimecast.com with ESMTP with STARTTLS (version=TLSv1.2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id us-mta-410-LW6mJEULMo2fa5cY77NRyA-1; Mon, 11 Sep 2023 09:52:59 -0400 Received: from smtp.corp.redhat.com (int-mx05.intmail.prod.int.rdu2.redhat.com [10.11.54.5]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by mimecast-mx02.redhat.com (Postfix) with ESMTPS id 9FEC23820EF4; Mon, 11 Sep 2023 13:52:43 +0000 (UTC) Received: from mm-prod-listman-01.mail-001.prod.us-east-1.aws.redhat.com (mm-prod-listman-01.mail-001.prod.us-east-1.aws.redhat.com [10.30.29.100]) by smtp.corp.redhat.com (Postfix) with ESMTP id 89FAC4407D; Mon, 11 Sep 2023 13:52:43 +0000 (UTC) Received: from mm-prod-listman-01.mail-001.prod.us-east-1.aws.redhat.com (localhost [IPv6:::1]) by mm-prod-listman-01.mail-001.prod.us-east-1.aws.redhat.com (Postfix) with ESMTP id C82B71946A6A; Mon, 11 Sep 2023 13:52:34 +0000 (UTC) Received: from smtp.corp.redhat.com (int-mx03.intmail.prod.int.rdu2.redhat.com [10.11.54.3]) by mm-prod-listman-01.mail-001.prod.us-east-1.aws.redhat.com (Postfix) with ESMTP id 505F119465B8 for ; Mon, 11 Sep 2023 13:52:33 +0000 (UTC) Received: by smtp.corp.redhat.com (Postfix) id 326FA10005D2; Mon, 11 Sep 2023 13:52:33 +0000 (UTC) Received: from fedora.. (unknown [10.43.2.118]) by smtp.corp.redhat.com (Postfix) with ESMTP id CE1851006B5C for ; Mon, 11 Sep 2023 13:52:32 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=redhat.com; s=mimecast20190719; t=1694440388; h=from:from:sender:sender:reply-to:subject:subject:date:date: message-id:message-id:to:to:cc:mime-version:mime-version: content-type:content-type: content-transfer-encoding:content-transfer-encoding: in-reply-to:in-reply-to:references:references:list-id:list-help: list-unsubscribe:list-subscribe:list-post; bh=krp47eWzE4WHj/zQSRvIRCRMYkZE4Qe2NJLntOl90ps=; b=S4HiCKVbiWYWarLz0dHAqqdKs1+gGTvq8e/ycxEw0wZjuhhHfk5xwGOknI3lZ03VXZyGX6 TIdUlpymDT/G7e6eZlhO+/CIUaN8e1f7Y/DDIAUqzZlUD2uUwZVdPTYAyd0/hZ3FMsAOVp ENvxELs1PL2RMn0kNXXDOV6sLoOdZuU= X-MC-Unique: LW6mJEULMo2fa5cY77NRyA-1 X-Original-To: libvir-list@listman.corp.redhat.com From: =?UTF-8?q?J=C3=A1n=20Tomko?= To: libvir-list@redhat.com Subject: [libvirt PATCHv1 8/8] docs: virtiofs: add section about ID remapping Date: Mon, 11 Sep 2023 15:51:28 +0200 Message-ID: <8fb68f05d63ea8c32c731971c8c315c8764d7ccf.1694440288.git.jtomko@redhat.com> In-Reply-To: References: MIME-Version: 1.0 X-Scanned-By: MIMEDefang 3.1 on 10.11.54.3 X-BeenThere: libvir-list@redhat.com X-Mailman-Version: 2.1.29 Precedence: list List-Id: Development discussions about the libvirt library & tools List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: libvir-list-bounces@redhat.com Sender: "libvir-list" X-Scanned-By: MIMEDefang 3.1 on 10.11.54.5 X-Mimecast-Spam-Score: 0 X-Mimecast-Originator: redhat.com Content-Type: text/plain; charset="utf-8" Content-Transfer-Encoding: quoted-printable X-ZohoMail-DKIM: pass (identity @redhat.com) X-ZM-MESSAGEID: 1694440408836100007 Signed-off-by: J=C3=A1n Tomko --- docs/kbase/virtiofs.rst | 29 +++++++++++++++++++++++++++++ 1 file changed, 29 insertions(+) diff --git a/docs/kbase/virtiofs.rst b/docs/kbase/virtiofs.rst index 5940092db5..ecfb8e4236 100644 --- a/docs/kbase/virtiofs.rst +++ b/docs/kbase/virtiofs.rst @@ -59,6 +59,35 @@ Sharing a host directory with a guest =20 Note: this requires virtiofs support in the guest kernel (Linux v5.4 or= later) =20 +ID mapping +=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D + +In unprivileged mode (``qemu:///session``), mapping user/group IDs is avai= lable +(since libvirt version TBD). After reserving an ID range from the host for= your +regular user + +:: + + $ cat /etc/subuid + jtomko:100000:65536 + $ cat /etc/subgid + jtomko:100000:65536 + +you can let virtiofsd map guest UIDs from 0 to 65535 +to host IDs 100000 to 165535 for example: + +:: + + + + ... + + + + + + + Optional parameters =3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D =20 --=20 2.41.0