Check for capng_*() retvals

[PATCH 0/2] Check for capng_*() retvals

Posted by Michal Privoznik 7 months, 2 weeks ago

There's a commit inside of (yet-unreleased) libcap-ng which marks some
functions as 'warned unused result'. Fedora rawhide already picked up
the commit, but since we are not checking for all retvals we got a build
failure on rawhide.

https://src.fedoraproject.org/rpms/libcap-ng/c/fed9b23c8d0020e07c937a3ac0d6dcc4534715fb?branch=rawhide

Green pipeline:

https://gitlab.com/MichalPrivoznik/libvirt/-/pipelines/999435445

Michal Prívozník (2):
  lxc_container: Check retval of capng_get_caps_process()
  virutil: Check retval of capng_apply()

 src/lxc/lxc_container.c | 8 +++++++-
 src/util/virutil.c      | 8 ++++++--
 2 files changed, 13 insertions(+), 3 deletions(-)

-- 
2.41.0

Re: [PATCH 0/2] Check for capng_*() retvals

Posted by Martin Kletzander 7 months, 2 weeks ago

On Mon, Sep 11, 2023 at 12:18:28PM +0200, Michal Privoznik wrote:
>There's a commit inside of (yet-unreleased) libcap-ng which marks some
>functions as 'warned unused result'. Fedora rawhide already picked up
>the commit, but since we are not checking for all retvals we got a build
>failure on rawhide.
>
>https://src.fedoraproject.org/rpms/libcap-ng/c/fed9b23c8d0020e07c937a3ac0d6dcc4534715fb?branch=rawhide
>
>Green pipeline:
>
>https://gitlab.com/MichalPrivoznik/libvirt/-/pipelines/999435445
>
>Michal Prívozník (2):
>  lxc_container: Check retval of capng_get_caps_process()
>  virutil: Check retval of capng_apply()

Reviewed-by: Martin Kletzander <mkletzan@redhat.com>

Checking return values is nicer anyway.

>
> src/lxc/lxc_container.c | 8 +++++++-
> src/util/virutil.c      | 8 ++++++--
> 2 files changed, 13 insertions(+), 3 deletions(-)
>
>-- 
>2.41.0
>

Re: [PATCH 0/2] Check for capng_*() retvals

Posted by Ján Tomko 7 months, 2 weeks ago

On a Monday in 2023, Michal Privoznik wrote:
>There's a commit inside of (yet-unreleased) libcap-ng which marks some
>functions as 'warned unused result'. Fedora rawhide already picked up
>the commit, but since we are not checking for all retvals we got a build
>failure on rawhide.
>
>https://src.fedoraproject.org/rpms/libcap-ng/c/fed9b23c8d0020e07c937a3ac0d6dcc4534715fb?branch=rawhide
>
>Green pipeline:
>
>https://gitlab.com/MichalPrivoznik/libvirt/-/pipelines/999435445
>
>Michal Prívozník (2):
>  lxc_container: Check retval of capng_get_caps_process()
>  virutil: Check retval of capng_apply()
>
> src/lxc/lxc_container.c | 8 +++++++-
> src/util/virutil.c      | 8 ++++++--
> 2 files changed, 13 insertions(+), 3 deletions(-)
>

Please add a separating ':' between "capabilities" and the number,
as we do elsewhere when printing capng's error codes.

Reviewed-by: Ján Tomko <jtomko@redhat.com>

Jano