[PATCH 0/9] qemu: Rework probing of vCPU hotplug support

Peter Krempa posted 9 patches 8 months, 1 week ago
Patches applied successfully (tree, apply log)
git fetch https://github.com/patchew-project/libvirt tags/patchew/cover.1693227408.git.pkrempa@redhat.com
tests/qemuxml2argvtest.c                      |  2 +-
50 files changed, 126 insertions(+), 177 deletions(-)
rename tests/qemuxml2argvdata/{cpu-hotplug-startup.args => cpu-hotplug-startup.x86_64-latest.args} (55%)
[PATCH 0/9] qemu: Rework probing of vCPU hotplug support
Posted by Peter Krempa 8 months, 1 week ago
Nowadays all qemu's support the command which was used as witness, but
was gated on machine type's support of vCPU hotplug.  Directly probe the
machine type.


Peter Krempa (9):
  qemu: Rename qemuDomainSupportsNewVcpuHotplug to
    qemuDomainSupportsVcpuHotplug
  qemu: capabilities: Export functions necessary for probing machine
    types
  qemu: process: Probe machine type data on reconnect to qemu
  qemuxml2argvtest: Modernize 'cpu-hotplug-startup' case
  tests: qemuhotplugtest: Fix arch-specific parts of 'ppc64' test XMLs
  qemuhotplugtest: Remove 'modern' field for cpu hotplug tests
  qemuDomainSupportsVcpuHotplug: Base return value on
    virQEMUCapsGetMachineHotplugCpus
  qemu: capabilities: Retire QEMU_CAPS_QUERY_HOTPLUGGABLE_CPUS
  qemu: capabilities: Remove unused 'virQEMUCapsFilterByMachineType'

 src/qemu/qemu_capabilities.c                  | 53 ++-----------------
 src/qemu/qemu_capabilities.h                  | 18 ++++---
 src/qemu/qemu_domain.c                        | 12 ++---
 src/qemu/qemu_domain.h                        |  2 +-
 src/qemu/qemu_hotplug.c                       |  4 +-
 src/qemu/qemu_process.c                       | 41 ++++++++++++--
 .../caps_4.2.0_aarch64.xml                    |  1 -
 .../qemucapabilitiesdata/caps_4.2.0_ppc64.xml |  1 -
 .../qemucapabilitiesdata/caps_4.2.0_s390x.xml |  1 -
 .../caps_4.2.0_x86_64.xml                     |  1 -
 .../caps_5.0.0_aarch64.xml                    |  1 -
 .../qemucapabilitiesdata/caps_5.0.0_ppc64.xml |  1 -
 .../caps_5.0.0_riscv64.xml                    |  1 -
 .../caps_5.0.0_x86_64.xml                     |  1 -
 .../qemucapabilitiesdata/caps_5.1.0_sparc.xml |  1 -
 .../caps_5.1.0_x86_64.xml                     |  1 -
 .../caps_5.2.0_aarch64.xml                    |  1 -
 .../qemucapabilitiesdata/caps_5.2.0_ppc64.xml |  1 -
 .../caps_5.2.0_riscv64.xml                    |  1 -
 .../qemucapabilitiesdata/caps_5.2.0_s390x.xml |  1 -
 .../caps_5.2.0_x86_64.xml                     |  1 -
 .../caps_6.0.0_aarch64.xml                    |  1 -
 .../qemucapabilitiesdata/caps_6.0.0_s390x.xml |  1 -
 .../caps_6.0.0_x86_64.xml                     |  1 -
 .../caps_6.1.0_x86_64.xml                     |  1 -
 .../caps_6.2.0_aarch64.xml                    |  1 -
 .../qemucapabilitiesdata/caps_6.2.0_ppc64.xml |  1 -
 .../caps_6.2.0_x86_64.xml                     |  1 -
 .../caps_7.0.0_aarch64+hvf.xml                |  1 -
 .../caps_7.0.0_aarch64.xml                    |  1 -
 .../qemucapabilitiesdata/caps_7.0.0_ppc64.xml |  1 -
 .../caps_7.0.0_x86_64.xml                     |  1 -
 .../qemucapabilitiesdata/caps_7.1.0_ppc64.xml |  1 -
 .../caps_7.1.0_x86_64.xml                     |  1 -
 tests/qemucapabilitiesdata/caps_7.2.0_ppc.xml |  1 -
 .../caps_7.2.0_x86_64+hvf.xml                 |  1 -
 .../caps_7.2.0_x86_64.xml                     |  1 -
 .../caps_8.0.0_riscv64.xml                    |  1 -
 .../caps_8.0.0_x86_64.xml                     |  1 -
 .../qemucapabilitiesdata/caps_8.1.0_s390x.xml |  1 -
 .../caps_8.1.0_x86_64.xml                     |  1 -
 tests/qemuhotplugtest.c                       | 40 +++++---------
 .../ppc64-modern-bulk-domain.xml              |  4 +-
 .../ppc64-modern-bulk-result-conf.xml         | 18 ++++---
 .../ppc64-modern-bulk-result-live.xml         | 19 +++----
 .../ppc64-modern-individual-domain.xml        |  4 +-
 .../ppc64-modern-individual-result-conf.xml   | 18 ++++---
 .../ppc64-modern-individual-result-live.xml   | 19 +++----
 ...=> cpu-hotplug-startup.x86_64-latest.args} | 14 ++---
 tests/qemuxml2argvtest.c                      |  2 +-
 50 files changed, 126 insertions(+), 177 deletions(-)
 rename tests/qemuxml2argvdata/{cpu-hotplug-startup.args => cpu-hotplug-startup.x86_64-latest.args} (55%)

-- 
2.41.0
Re: [PATCH 0/9] qemu: Rework probing of vCPU hotplug support
Posted by Michal Prívozník 8 months, 1 week ago
On 8/28/23 15:11, Peter Krempa wrote:
> Nowadays all qemu's support the command which was used as witness, but
> was gated on machine type's support of vCPU hotplug.  Directly probe the
> machine type.
> 
> 
> Peter Krempa (9):
>   qemu: Rename qemuDomainSupportsNewVcpuHotplug to
>     qemuDomainSupportsVcpuHotplug
>   qemu: capabilities: Export functions necessary for probing machine
>     types
>   qemu: process: Probe machine type data on reconnect to qemu
>   qemuxml2argvtest: Modernize 'cpu-hotplug-startup' case
>   tests: qemuhotplugtest: Fix arch-specific parts of 'ppc64' test XMLs
>   qemuhotplugtest: Remove 'modern' field for cpu hotplug tests
>   qemuDomainSupportsVcpuHotplug: Base return value on
>     virQEMUCapsGetMachineHotplugCpus
>   qemu: capabilities: Retire QEMU_CAPS_QUERY_HOTPLUGGABLE_CPUS
>   qemu: capabilities: Remove unused 'virQEMUCapsFilterByMachineType'
> 
>  src/qemu/qemu_capabilities.c                  | 53 ++-----------------
>  src/qemu/qemu_capabilities.h                  | 18 ++++---
>  src/qemu/qemu_domain.c                        | 12 ++---
>  src/qemu/qemu_domain.h                        |  2 +-
>  src/qemu/qemu_hotplug.c                       |  4 +-
>  src/qemu/qemu_process.c                       | 41 ++++++++++++--
>  .../caps_4.2.0_aarch64.xml                    |  1 -
>  .../qemucapabilitiesdata/caps_4.2.0_ppc64.xml |  1 -
>  .../qemucapabilitiesdata/caps_4.2.0_s390x.xml |  1 -
>  .../caps_4.2.0_x86_64.xml                     |  1 -
>  .../caps_5.0.0_aarch64.xml                    |  1 -
>  .../qemucapabilitiesdata/caps_5.0.0_ppc64.xml |  1 -
>  .../caps_5.0.0_riscv64.xml                    |  1 -
>  .../caps_5.0.0_x86_64.xml                     |  1 -
>  .../qemucapabilitiesdata/caps_5.1.0_sparc.xml |  1 -
>  .../caps_5.1.0_x86_64.xml                     |  1 -
>  .../caps_5.2.0_aarch64.xml                    |  1 -
>  .../qemucapabilitiesdata/caps_5.2.0_ppc64.xml |  1 -
>  .../caps_5.2.0_riscv64.xml                    |  1 -
>  .../qemucapabilitiesdata/caps_5.2.0_s390x.xml |  1 -
>  .../caps_5.2.0_x86_64.xml                     |  1 -
>  .../caps_6.0.0_aarch64.xml                    |  1 -
>  .../qemucapabilitiesdata/caps_6.0.0_s390x.xml |  1 -
>  .../caps_6.0.0_x86_64.xml                     |  1 -
>  .../caps_6.1.0_x86_64.xml                     |  1 -
>  .../caps_6.2.0_aarch64.xml                    |  1 -
>  .../qemucapabilitiesdata/caps_6.2.0_ppc64.xml |  1 -
>  .../caps_6.2.0_x86_64.xml                     |  1 -
>  .../caps_7.0.0_aarch64+hvf.xml                |  1 -
>  .../caps_7.0.0_aarch64.xml                    |  1 -
>  .../qemucapabilitiesdata/caps_7.0.0_ppc64.xml |  1 -
>  .../caps_7.0.0_x86_64.xml                     |  1 -
>  .../qemucapabilitiesdata/caps_7.1.0_ppc64.xml |  1 -
>  .../caps_7.1.0_x86_64.xml                     |  1 -
>  tests/qemucapabilitiesdata/caps_7.2.0_ppc.xml |  1 -
>  .../caps_7.2.0_x86_64+hvf.xml                 |  1 -
>  .../caps_7.2.0_x86_64.xml                     |  1 -
>  .../caps_8.0.0_riscv64.xml                    |  1 -
>  .../caps_8.0.0_x86_64.xml                     |  1 -
>  .../qemucapabilitiesdata/caps_8.1.0_s390x.xml |  1 -
>  .../caps_8.1.0_x86_64.xml                     |  1 -
>  tests/qemuhotplugtest.c                       | 40 +++++---------
>  .../ppc64-modern-bulk-domain.xml              |  4 +-
>  .../ppc64-modern-bulk-result-conf.xml         | 18 ++++---
>  .../ppc64-modern-bulk-result-live.xml         | 19 +++----
>  .../ppc64-modern-individual-domain.xml        |  4 +-
>  .../ppc64-modern-individual-result-conf.xml   | 18 ++++---
>  .../ppc64-modern-individual-result-live.xml   | 19 +++----
>  ...=> cpu-hotplug-startup.x86_64-latest.args} | 14 ++---
>  tests/qemuxml2argvtest.c                      |  2 +-
>  50 files changed, 126 insertions(+), 177 deletions(-)
>  rename tests/qemuxml2argvdata/{cpu-hotplug-startup.args => cpu-hotplug-startup.x86_64-latest.args} (55%)
> 

Reviewed-by: Michal Privoznik <mprivozn@redhat.com>

Michal