This is inspired by the following discussion:

https://listman.redhat.com/archives/libvir-list/2023-August/241361.html

And ideally I'd present a green pipeline but for some reason, I can't:

https://gitlab.com/MichalPrivoznik/libvirt/-/pipelines/981105262

But the problem is not with my code rather than our CI.

Michal Prívozník (27):
  bhyve: Move error messages onto a single line
  ch: Move error messages onto a single line
  conf: Move error messages onto a single line
  cpu: Move error messages onto a single line
  esx: Move error messages onto a single line
  hypervisor: Move error messages onto a single line
  libxl: Move error messages onto a single line
  locking: Move error messages onto a single line
  lxc: Move error messages onto a single line
  network: Move error messages onto a single line
  node_device: Move error messages onto a single line
  nwfilter: Move error messages onto a single line
  openvz: Move error messages onto a single line
  qemu: Move error messages onto a single line
  remote: Move error messages onto a single line
  rpc: Move error messages onto a single line
  security: Move error messages onto a single line
  storage: Move error messages onto a single line
  storage_file: Move error messages onto a single line
  test: Move error messages onto a single line
  util: Move error messages onto a single line
  vbox: Move error messages onto a single line
  vmware: Move error messages onto a single line
  vmx: Move error messages onto a single line
  vz: Move error messages onto a single line
  src: Move error messages onto a single line
  tools: Move error messages onto a single line

 src/bhyve/bhyve_command.c                     |  31 +--
 src/bhyve/bhyve_domain.c                      |   3 +-
 src/bhyve/bhyve_driver.c                      |   3 +-
 src/ch/ch_driver.c                            |   3 +-
 src/ch/ch_monitor.c                           |   3 +-
 src/conf/cpu_conf.c                           |   9 +-
 src/conf/domain_addr.c                        |   3 +-
 src/conf/domain_conf.c                        | 138 ++++--------
 src/conf/domain_validate.c                    |  54 ++---
 src/conf/netdev_bandwidth_conf.c              |   3 +-
 src/conf/netdev_vlan_conf.c                   |   6 +-
 src/conf/network_conf.c                       |  27 +--
 src/conf/node_device_conf.c                   |   3 +-
 src/conf/node_device_util.c                   |   3 +-
 src/conf/numa_conf.c                          |  25 +--
 src/conf/nwfilter_params.c                    |   6 +-
 src/conf/snapshot_conf.c                      |   3 +-
 src/conf/storage_adapter_conf.c               |  18 +-
 src/conf/virdomainjob.c                       |   3 +-
 src/conf/virnetworkobj.c                      |   3 +-
 src/cpu/cpu_x86.c                             |   6 +-
 src/esx/esx_driver.c                          |  21 +-
 src/esx/esx_network_driver.c                  |   3 +-
 src/esx/esx_storage_backend_vmfs.c            |   3 +-
 src/esx/esx_util.c                            |   3 +-
 src/esx/esx_vi.c                              |  19 +-
 src/esx/esx_vi_types.c                        |   3 +-
 src/hypervisor/domain_cgroup.c                |   3 +-
 src/hypervisor/virhostdev.c                   |   9 +-
 src/libvirt-domain.c                          |  54 ++---
 src/libxl/libxl_conf.c                        |  12 +-
 src/libxl/libxl_driver.c                      |   6 +-
 src/libxl/libxl_migration.c                   |  11 +-
 src/locking/lock_driver_sanlock.c             |   3 +-
 src/lxc/lxc_container.c                       |   3 +-
 src/lxc/lxc_driver.c                          |   3 +-
 src/lxc/lxc_native.c                          |   3 +-
 src/lxc/lxc_process.c                         |   3 +-
 src/network/bridge_driver.c                   |  14 +-
 src/network/bridge_driver_linux.c             |  10 +-
 src/node_device/node_device_udev.c            |   3 +-
 src/nwfilter/nwfilter_dhcpsnoop.c             |  12 +-
 src/nwfilter/nwfilter_learnipaddr.c           |   8 +-
 src/openvz/openvz_driver.c                    |   3 +-
 src/qemu/qemu_agent.c                         |  18 +-
 src/qemu/qemu_capabilities.c                  |  45 ++--
 src/qemu/qemu_command.c                       |  42 ++--
 src/qemu/qemu_conf.c                          |   5 +-
 src/qemu/qemu_domain.c                        |  51 ++---
 src/qemu/qemu_domain_address.c                |  15 +-
 src/qemu/qemu_driver.c                        | 120 ++++------
 src/qemu/qemu_hostdev.c                       |   3 +-
 src/qemu/qemu_hotplug.c                       |  18 +-
 src/qemu/qemu_migration.c                     |  48 ++--
 src/qemu/qemu_migration_params.c              |   6 +-
 src/qemu/qemu_monitor.c                       |   3 +-
 src/qemu/qemu_monitor_json.c                  | 102 +++------
 src/qemu/qemu_process.c                       |  20 +-
 src/qemu/qemu_snapshot.c                      |  27 +--
 src/qemu/qemu_tpm.c                           |   4 +-
 src/qemu/qemu_validate.c                      | 209 ++++++------------
 src/remote/remote_daemon.c                    |   3 +-
 src/remote/remote_driver.c                    |  27 +--
 src/remote/remote_sockets.c                   |   3 +-
 src/rpc/virnetclient.c                        |   9 +-
 src/rpc/virnetlibsshsession.c                 |  28 +--
 src/rpc/virnetserver.c                        |   9 +-
 src/rpc/virnetserverclient.c                  |   3 +-
 src/rpc/virnetsshsession.c                    |  45 ++--
 src/rpc/virnettlscontext.c                    |   6 +-
 src/security/security_dac.c                   |   3 +-
 src/storage/storage_backend_disk.c            |   3 +-
 src/storage/storage_backend_fs.c              |   3 +-
 src/storage/storage_backend_zfs.c             |   3 +-
 src/storage/storage_driver.c                  |  21 +-
 src/storage/storage_util.c                    |  48 ++--
 src/storage_file/storage_source.c             |   3 +-
 .../storage_source_backingstore.c             |  36 +--
 src/test/test_driver.c                        |  39 ++--
 src/util/vircgroupv2devices.c                 |  13 +-
 src/util/vircommand.c                         |   3 +-
 src/util/virfile.c                            |   3 +-
 src/util/virhostcpu.c                         |   3 +-
 src/util/virhostmem.c                         |   6 +-
 src/util/virjson.c                            |   3 +-
 src/util/virmdev.c                            |   3 +-
 src/util/virnetdev.c                          |  12 +-
 src/util/virnetdevbandwidth.c                 |   6 +-
 src/util/virnetdevopenvswitch.c               |   6 +-
 src/util/virnetdevvportprofile.c              |   6 +-
 src/util/virnetlink.c                         |   3 +-
 src/util/virnuma.c                            |   6 +-
 src/util/virpci.c                             |   3 +-
 src/util/virprocess.c                         |   9 +-
 src/util/virqemu.c                            |   3 +-
 src/util/virresctrl.c                         |   9 +-
 src/util/virthreadpool.c                      |   3 +-
 src/vbox/vbox_snapshot_conf.c                 |   6 +-
 src/vmware/vmware_conf.c                      |   9 +-
 src/vmware/vmware_driver.c                    |   6 +-
 src/vmx/vmx.c                                 |  21 +-
 src/vz/vz_driver.c                            |  15 +-
 src/vz/vz_sdk.c                               | 135 ++++-------
 src/vz/vz_utils.c                             |  66 ++----
 tools/virsh-domain-event.c                    |  15 +-
 tools/virsh-domain.c                          |  36 +--
 tools/virsh-host.c                            |   9 +-
 tools/virsh-network.c                         |   6 +-
 tools/virsh-nodedev.c                         |   3 +-
 tools/virsh-pool.c                            |   3 +-
 tools/virsh.c                                 |   9 +-
 tools/virt-admin.c                            |  21 +-
 tools/virt-host-validate-ch.c                 |  12 +-
 tools/virt-host-validate-qemu.c               |  15 +-
 tools/vsh.c                                   |  12 +-
 115 files changed, 689 insertions(+), 1403 deletions(-)

-- 
2.41.0

On Fri, Aug 25, 2023 at 09:39:57AM +0200, Michal Privoznik wrote:
> This is inspired by the following discussion:
> 
> https://listman.redhat.com/archives/libvir-list/2023-August/241361.html

We have it covered by coding style document so it would be nice to make
a syntax-check for it as well so there are no new multi-line errors
introduced in the future. Not sure how difficult it would be so
definitely as follow up.

Otherwise looks good and compiles without issues on my machine.

I would consider pushing it after release is done to make sure it will
not break anything as it affects basically the whole libvirt code base.

> And ideally I'd present a green pipeline but for some reason, I can't:
> 
> https://gitlab.com/MichalPrivoznik/libvirt/-/pipelines/981105262
> 
> But the problem is not with my code rather than our CI.

Unless there are objections from others

Reviewed-by: Pavel Hrdina <phrdina@redhat.com>

On 8/25/23 12:14, Pavel Hrdina wrote:
> On Fri, Aug 25, 2023 at 09:39:57AM +0200, Michal Privoznik wrote:
>> This is inspired by the following discussion:
>>
>> https://listman.redhat.com/archives/libvir-list/2023-August/241361.html
> 
> We have it covered by coding style document so it would be nice to make
> a syntax-check for it as well so there are no new multi-line errors
> introduced in the future. Not sure how difficult it would be so
> definitely as follow up.

Yeah, I was thinking about that, but I'm not that good with RE-s.

> 
> Otherwise looks good and compiles without issues on my machine.
> 
> I would consider pushing it after release is done to make sure it will
> not break anything as it affects basically the whole libvirt code base.

I hear you and I agree. And given how huge the change is I'd rather push
it right after the release to avoid any conflicts.

> 
>> And ideally I'd present a green pipeline but for some reason, I can't:
>>
>> https://gitlab.com/MichalPrivoznik/libvirt/-/pipelines/981105262
>>
>> But the problem is not with my code rather than our CI.
> 
> Unless there are objections from others
> 
> Reviewed-by: Pavel Hrdina <phrdina@redhat.com>

Thank you!

Michal