Fix one corner case when parsing 'mdevctl' output

[PATCH 0/6] Fix one corner case when parsing 'mdevctl' output

Michal Privoznik posted 6 patches 8 months, 2 weeks ago

Download series mbox

Patches applied successfully (tree, apply log)
git fetch https://github.com/patchew-project/libvirt tags/patchew/cover.1692867419.git.mprivozn@redhat.com

src/node_device/node_device_driver.c          | 40 ++++++-------------
.../mdevctl-list-empty-array.json             |  1 +
.../mdevctl-list-empty-array.out.xml          |  0
.../mdevctl-list-empty.json                   |  1 -
tests/nodedevmdevctltest.c                    |  1 +
tests/virjsontest.c                           |  1 +
6 files changed, 16 insertions(+), 28 deletions(-)
create mode 100644 tests/nodedevmdevctldata/mdevctl-list-empty-array.json
create mode 100644 tests/nodedevmdevctldata/mdevctl-list-empty-array.out.xml

Expand all Fold all

[PATCH 0/6] Fix one corner case when parsing 'mdevctl' output

Posted by Michal Privoznik 8 months, 2 weeks ago

See 2/6 for explanation.

Michal Prívozník (6):
  nodedevmdevctltest: Rename mdevctl-list-empty test case
  nodeDeviceParseMdevctlJSON: Accept empty string
  nodedevmdevctltest: Introduce a test case for empty mdevctl output
  node_device_driver: Deduplicate mediated devices listing
  virMdevctlList: Don't check for !output
  virjsontest: Introduce a test case for an empty array

 src/node_device/node_device_driver.c          | 40 ++++++-------------
 .../mdevctl-list-empty-array.json             |  1 +
 .../mdevctl-list-empty-array.out.xml          |  0
 .../mdevctl-list-empty.json                   |  1 -
 tests/nodedevmdevctltest.c                    |  1 +
 tests/virjsontest.c                           |  1 +
 6 files changed, 16 insertions(+), 28 deletions(-)
 create mode 100644 tests/nodedevmdevctldata/mdevctl-list-empty-array.json
 create mode 100644 tests/nodedevmdevctldata/mdevctl-list-empty-array.out.xml

-- 
2.41.0

Re: [PATCH 0/6] Fix one corner case when parsing 'mdevctl' output

Posted by Kristina Hanicova 8 months, 2 weeks ago

On Thu, Aug 24, 2023 at 10:57 AM Michal Privoznik <mprivozn@redhat.com>
wrote:

> See 2/6 for explanation.
>
> Michal Prívozník (6):
>   nodedevmdevctltest: Rename mdevctl-list-empty test case
>   nodeDeviceParseMdevctlJSON: Accept empty string
>   nodedevmdevctltest: Introduce a test case for empty mdevctl output
>   node_device_driver: Deduplicate mediated devices listing
>   virMdevctlList: Don't check for !output
>   virjsontest: Introduce a test case for an empty array
>
>  src/node_device/node_device_driver.c          | 40 ++++++-------------
>  .../mdevctl-list-empty-array.json             |  1 +
>  .../mdevctl-list-empty-array.out.xml          |  0
>  .../mdevctl-list-empty.json                   |  1 -
>  tests/nodedevmdevctltest.c                    |  1 +
>  tests/virjsontest.c                           |  1 +
>  6 files changed, 16 insertions(+), 28 deletions(-)
>  create mode 100644 tests/nodedevmdevctldata/mdevctl-list-empty-array.json
>  create mode 100644
> tests/nodedevmdevctldata/mdevctl-list-empty-array.out.xml


Reviewed-by: Kristina Hanicova <khanicov@redhat.com>
Kristina