Improve closing of FDs for child processes

[PATCH v2 0/5] Improve closing of FDs for child processes

Michal Privoznik posted 5 patches 8 months, 2 weeks ago

Download series mbox

Patches applied successfully (tree, apply log)
git fetch https://github.com/patchew-project/libvirt tags/patchew/cover.1692710969.git.mprivozn@redhat.com

src/libvirt.c            |   4 +
src/libvirt_private.syms |   4 +
src/util/vircommand.c    | 160 ++++++++++++++++++++++++---------------
src/util/virfile.c       | 110 +++++++++++++++++++++++++++
src/util/virfile.h       |   5 ++
tests/commandtest.c      |   2 +
6 files changed, 222 insertions(+), 63 deletions(-)

Expand all Fold all

[PATCH v2 0/5] Improve closing of FDs for child processes

Posted by Michal Privoznik 8 months, 2 weeks ago

This is a v2 of:

https://listman.redhat.com/archives/libvir-list/2023-June/240351.html

Hopefully, I've implemented all Dan's suggestions.

Michal Prívozník (5):
  virfile: Introduce virCloseRange()
  virfile: Introduce virCloseFrom()
  vircommand: Unify mass FD closing
  vircommand: Introduce virCommandMassCloseRange()
  src: Detect close_range syscall during virGlobalInit()

 src/libvirt.c            |   4 +
 src/libvirt_private.syms |   4 +
 src/util/vircommand.c    | 160 ++++++++++++++++++++++++---------------
 src/util/virfile.c       | 110 +++++++++++++++++++++++++++
 src/util/virfile.h       |   5 ++
 tests/commandtest.c      |   2 +
 6 files changed, 222 insertions(+), 63 deletions(-)

-- 
2.41.0

Re: [PATCH v2 0/5] Improve closing of FDs for child processes

Posted by Ján Tomko 8 months, 2 weeks ago

On a Tuesday in 2023, Michal Privoznik wrote:
>This is a v2 of:
>
>https://listman.redhat.com/archives/libvir-list/2023-June/240351.html
>
>Hopefully, I've implemented all Dan's suggestions.
>
>Michal Prívozník (5):
>  virfile: Introduce virCloseRange()
>  virfile: Introduce virCloseFrom()
>  vircommand: Unify mass FD closing
>  vircommand: Introduce virCommandMassCloseRange()
>  src: Detect close_range syscall during virGlobalInit()
>
> src/libvirt.c            |   4 +
> src/libvirt_private.syms |   4 +
> src/util/vircommand.c    | 160 ++++++++++++++++++++++++---------------
> src/util/virfile.c       | 110 +++++++++++++++++++++++++++
> src/util/virfile.h       |   5 ++
> tests/commandtest.c      |   2 +
> 6 files changed, 222 insertions(+), 63 deletions(-)
>

Reviewed-by: Ján Tomko <jtomko@redhat.com>

Jano

Re: [PATCH v2 0/5] Improve closing of FDs for child processes

Posted by Kristina Hanicova 8 months, 2 weeks ago

On Tue, Aug 22, 2023 at 3:35 PM Michal Privoznik <mprivozn@redhat.com>
wrote:

> This is a v2 of:
>
> https://listman.redhat.com/archives/libvir-list/2023-June/240351.html
>
> Hopefully, I've implemented all Dan's suggestions.
>
> Michal Prívozník (5):
>   virfile: Introduce virCloseRange()
>   virfile: Introduce virCloseFrom()
>   vircommand: Unify mass FD closing
>   vircommand: Introduce virCommandMassCloseRange()
>   src: Detect close_range syscall during virGlobalInit()
>
>  src/libvirt.c            |   4 +
>  src/libvirt_private.syms |   4 +
>  src/util/vircommand.c    | 160 ++++++++++++++++++++++++---------------
>  src/util/virfile.c       | 110 +++++++++++++++++++++++++++
>  src/util/virfile.h       |   5 ++
>  tests/commandtest.c      |   2 +
>  6 files changed, 222 insertions(+), 63 deletions(-)
>
>
Reviewed-by: Kristina Hanicova <khanicov@redhat.com>
Kristina