[PATCH v3 0/3] Add support for discard_no_unref qcow2 option

Peter Krempa posted 3 patches 10 months, 4 weeks ago
Patches applied successfully (tree, apply log)
git fetch https://github.com/patchew-project/libvirt tags/patchew/cover.1687523851.git.pkrempa@redhat.com
NEWS.rst                                      |  7 ++++
docs/formatdomain.rst                         |  7 ++++
src/conf/domain_conf.c                        |  8 ++++
src/conf/domain_conf.h                        |  1 +
src/conf/domain_validate.c                    | 14 +++++++
src/conf/schemas/domaincommon.rng             |  5 +++
src/conf/storage_source_conf.c                |  1 +
src/conf/storage_source_conf.h                |  1 +
src/qemu/qemu_block.c                         | 11 +++--
src/qemu/qemu_capabilities.c                  |  2 +
src/qemu/qemu_capabilities.h                  |  1 +
src/qemu/qemu_domain.c                        |  1 +
src/qemu/qemu_driver.c                        |  4 +-
src/qemu/qemu_validate.c                      |  7 ++++
src/vz/vz_utils.c                             |  6 +++
.../caps_8.1.0_x86_64.xml                     |  1 +
.../disk-discard_no_unref.x86_64-latest.args  | 36 ++++++++++++++++
.../disk-discard_no_unref.xml                 | 32 ++++++++++++++
tests/qemuxml2argvtest.c                      |  1 +
.../disk-discard_no_unref.x86_64-latest.xml   | 42 +++++++++++++++++++
tests/qemuxml2xmltest.c                       |  1 +
21 files changed, 182 insertions(+), 7 deletions(-)
create mode 100644 tests/qemuxml2argvdata/disk-discard_no_unref.x86_64-latest.args
create mode 100644 tests/qemuxml2argvdata/disk-discard_no_unref.xml
create mode 100644 tests/qemuxml2xmloutdata/disk-discard_no_unref.x86_64-latest.xml
[PATCH v3 0/3] Add support for discard_no_unref qcow2 option
Posted by Peter Krempa 10 months, 4 weeks ago
v3:
 - new PATCH 1 adds a qemu capability
 - PATCH 2:
    - tweaked a few error messages
    - added qemu capability validation
    - removed invocation of test from qemusecuritytest which is not
      needed
 - PATCH 3:
    - added some explanation for the news entry

Jean-Louis Dupond (2):
  Add discard_no_unref option for qcow2 images
  NEWS: Update NEWS with new discard_no_unref option

Peter Krempa (1):
  qemu: capabilities: Introduce QEMU_CAPS_QCOW2_DISCARD_NO_UNREF

 NEWS.rst                                      |  7 ++++
 docs/formatdomain.rst                         |  7 ++++
 src/conf/domain_conf.c                        |  8 ++++
 src/conf/domain_conf.h                        |  1 +
 src/conf/domain_validate.c                    | 14 +++++++
 src/conf/schemas/domaincommon.rng             |  5 +++
 src/conf/storage_source_conf.c                |  1 +
 src/conf/storage_source_conf.h                |  1 +
 src/qemu/qemu_block.c                         | 11 +++--
 src/qemu/qemu_capabilities.c                  |  2 +
 src/qemu/qemu_capabilities.h                  |  1 +
 src/qemu/qemu_domain.c                        |  1 +
 src/qemu/qemu_driver.c                        |  4 +-
 src/qemu/qemu_validate.c                      |  7 ++++
 src/vz/vz_utils.c                             |  6 +++
 .../caps_8.1.0_x86_64.xml                     |  1 +
 .../disk-discard_no_unref.x86_64-latest.args  | 36 ++++++++++++++++
 .../disk-discard_no_unref.xml                 | 32 ++++++++++++++
 tests/qemuxml2argvtest.c                      |  1 +
 .../disk-discard_no_unref.x86_64-latest.xml   | 42 +++++++++++++++++++
 tests/qemuxml2xmltest.c                       |  1 +
 21 files changed, 182 insertions(+), 7 deletions(-)
 create mode 100644 tests/qemuxml2argvdata/disk-discard_no_unref.x86_64-latest.args
 create mode 100644 tests/qemuxml2argvdata/disk-discard_no_unref.xml
 create mode 100644 tests/qemuxml2xmloutdata/disk-discard_no_unref.x86_64-latest.xml

-- 
2.40.1
Re: [PATCH v3 0/3] Add support for discard_no_unref qcow2 option
Posted by Ján Tomko 10 months, 3 weeks ago
On a Friday in 2023, Peter Krempa wrote:
>v3:
> - new PATCH 1 adds a qemu capability
> - PATCH 2:
>    - tweaked a few error messages
>    - added qemu capability validation
>    - removed invocation of test from qemusecuritytest which is not
>      needed
> - PATCH 3:
>    - added some explanation for the news entry
>
>Jean-Louis Dupond (2):
>  Add discard_no_unref option for qcow2 images
>  NEWS: Update NEWS with new discard_no_unref option
>
>Peter Krempa (1):
>  qemu: capabilities: Introduce QEMU_CAPS_QCOW2_DISCARD_NO_UNREF
>
> NEWS.rst                                      |  7 ++++
> docs/formatdomain.rst                         |  7 ++++
> src/conf/domain_conf.c                        |  8 ++++
> src/conf/domain_conf.h                        |  1 +
> src/conf/domain_validate.c                    | 14 +++++++
> src/conf/schemas/domaincommon.rng             |  5 +++
> src/conf/storage_source_conf.c                |  1 +
> src/conf/storage_source_conf.h                |  1 +
> src/qemu/qemu_block.c                         | 11 +++--
> src/qemu/qemu_capabilities.c                  |  2 +
> src/qemu/qemu_capabilities.h                  |  1 +
> src/qemu/qemu_domain.c                        |  1 +
> src/qemu/qemu_driver.c                        |  4 +-
> src/qemu/qemu_validate.c                      |  7 ++++
> src/vz/vz_utils.c                             |  6 +++
> .../caps_8.1.0_x86_64.xml                     |  1 +
> .../disk-discard_no_unref.x86_64-latest.args  | 36 ++++++++++++++++
> .../disk-discard_no_unref.xml                 | 32 ++++++++++++++
> tests/qemuxml2argvtest.c                      |  1 +
> .../disk-discard_no_unref.x86_64-latest.xml   | 42 +++++++++++++++++++
> tests/qemuxml2xmltest.c                       |  1 +
> 21 files changed, 182 insertions(+), 7 deletions(-)
> create mode 100644 tests/qemuxml2argvdata/disk-discard_no_unref.x86_64-latest.args
> create mode 100644 tests/qemuxml2argvdata/disk-discard_no_unref.xml
> create mode 100644 tests/qemuxml2xmloutdata/disk-discard_no_unref.x86_64-latest.xml
>

Reviewed-by: Ján Tomko <jtomko@redhat.com>

Jano