[v1] Setup iothread polling attributes in the XML

[PATCH 0/3] Setup iothread polling attributes in the XML

Peter Krempa posted 3 patches 1 year, 1 month ago

Diff against v3
Download series mbox

Patches applied successfully (tree, apply log)
git fetch https://github.com/patchew-project/libvirt tags/patchew/cover.1680262381.git.pkrempa@redhat.com

There is a newer version of this series

docs/formatdomain.rst                         | 53 +++++++++++--------
src/conf/domain_conf.c                        | 41 +++++++++++++-
src/conf/domain_conf.h                        |  7 +++
src/conf/schemas/domaincommon.rng             | 19 +++++++
src/qemu/qemu_command.c                       | 18 +++++++
src/qemu/qemu_driver.c                        | 30 ++++++-----
...othreads-ids-pool-sizes.x86_64-latest.args |  6 +--
.../iothreads-ids-pool-sizes.xml              | 12 +++--
8 files changed, 142 insertions(+), 44 deletions(-)

Expand all Fold all

[PATCH 0/3] Setup iothread polling attributes in the XML

Posted by Peter Krempa 1 year, 1 month ago

Peter Krempa (3):
  conf: Store the iothread 'poll' settings in the XML
  qemu: Use configured iothread poll parameters on startup
  docs: formatdomain: Properly indent example XML for setting
    'metadata_cache'

 docs/formatdomain.rst                         | 53 +++++++++++--------
 src/conf/domain_conf.c                        | 41 +++++++++++++-
 src/conf/domain_conf.h                        |  7 +++
 src/conf/schemas/domaincommon.rng             | 19 +++++++
 src/qemu/qemu_command.c                       | 18 +++++++
 src/qemu/qemu_driver.c                        | 30 ++++++-----
 ...othreads-ids-pool-sizes.x86_64-latest.args |  6 +--
 .../iothreads-ids-pool-sizes.xml              | 12 +++--
 8 files changed, 142 insertions(+), 44 deletions(-)

-- 
2.39.2

Re: [PATCH 0/3] Setup iothread polling attributes in the XML

Posted by Martin Kletzander 1 year, 1 month ago

On Fri, Mar 31, 2023 at 02:00:31PM +0200, Peter Krempa wrote:
>Peter Krempa (3):
>  conf: Store the iothread 'poll' settings in the XML
>  qemu: Use configured iothread poll parameters on startup

If you change all of them to the same type (ULL for example) and adjust
the type in JSON appropriately, then

Reviewed-by: Martin Kletzander <mkletzan@redhat.com>

for those two as well, I forgot to mention it in individual replies

>  docs: formatdomain: Properly indent example XML for setting
>    'metadata_cache'
>
> docs/formatdomain.rst                         | 53 +++++++++++--------
> src/conf/domain_conf.c                        | 41 +++++++++++++-
> src/conf/domain_conf.h                        |  7 +++
> src/conf/schemas/domaincommon.rng             | 19 +++++++
> src/qemu/qemu_command.c                       | 18 +++++++
> src/qemu/qemu_driver.c                        | 30 ++++++-----
> ...othreads-ids-pool-sizes.x86_64-latest.args |  6 +--
> .../iothreads-ids-pool-sizes.xml              | 12 +++--
> 8 files changed, 142 insertions(+), 44 deletions(-)
>
>-- 
>2.39.2
>