[PATCH 00/10] remote: Pass 'mode' and 'socket' URI parameters to virt-ssh-helper

Michal Privoznik posted 10 patches 1 year, 2 months ago
Patches applied successfully (tree, apply log)
git fetch https://github.com/patchew-project/libvirt tags/patchew/cover.1675674809.git.mprivozn@redhat.com
There is a newer version of this series
po/POTFILES                           |   1 +
src/admin/libvirt-admin.c             |  21 ++--
src/esx/esx_util.c                    |  96 ++++++++--------
src/hyperv/hyperv_util.c              |  30 +++--
src/libvirt-host.c                    |  10 +-
src/libvirt_private.syms              |   1 +
src/qemu/qemu_block.c                 |   3 +-
src/qemu/qemu_migration.c             |  24 ++--
src/remote/remote_driver.c            | 158 +++++++++++++-------------
src/remote/remote_ssh_helper.c        |  27 ++++-
src/storage/storage_backend_gluster.c |   6 +-
src/util/virauth.c                    |  12 +-
src/util/viruri.c                     |  24 +++-
src/util/viruri.h                     |  37 ++++++
tests/viruritest.c                    |   3 +-
15 files changed, 245 insertions(+), 208 deletions(-)
[PATCH 00/10] remote: Pass 'mode' and 'socket' URI parameters to virt-ssh-helper
Posted by Michal Privoznik 1 year, 2 months ago
The first couple of patches are cleanups, mostly. The last 5 patches are
the important ones. Now, the fix I went with in the 10/10 is to format
URI anew, just for the virt-ssh-helper's sake. I did not want to touch
@name as it's passed to sub-daemon's .open() method. If desired, I can
change the @name variable instead as it seems that no driver relies on
?mode or ?socket (they couldn't anyway). Thoughts?

Michal Prívozník (10):
  viruri: Search params case insensitively
  Drop checks for virURIFormat() retval
  doRemoteOpen(): Rename 'failed' label to 'error'
  remote_driver: Expose EXTRACT_URI_ARG_* macros
  src: Unify URI params parsing
  virt-ssh-helper: Accept ?mode= in connection URI
  virt-ssh-helper: Accept ?socket= in connection URI
  remote_driver: Move URI re-generation into a function
  viruri: Introduce virURIParamsSetIgnore()
  remote: Pass 'mode' and 'socket' URI parameters to virt-ssh-helper

 po/POTFILES                           |   1 +
 src/admin/libvirt-admin.c             |  21 ++--
 src/esx/esx_util.c                    |  96 ++++++++--------
 src/hyperv/hyperv_util.c              |  30 +++--
 src/libvirt-host.c                    |  10 +-
 src/libvirt_private.syms              |   1 +
 src/qemu/qemu_block.c                 |   3 +-
 src/qemu/qemu_migration.c             |  24 ++--
 src/remote/remote_driver.c            | 158 +++++++++++++-------------
 src/remote/remote_ssh_helper.c        |  27 ++++-
 src/storage/storage_backend_gluster.c |   6 +-
 src/util/virauth.c                    |  12 +-
 src/util/viruri.c                     |  24 +++-
 src/util/viruri.h                     |  37 ++++++
 tests/viruritest.c                    |   3 +-
 15 files changed, 245 insertions(+), 208 deletions(-)

-- 
2.39.1